Review feedback

Author: ConsoleCatzirl

mip_api/__init__.py

@@ -9,7 +9,11 @@
 
 
 def lambda_handler(event, context):
-    """Sample pure Lambda function
+    """Entry Point for Lambda
+
+    The Python process will continue to run for the entire lifecycle of
+    the Lambda execution environment (15 minutes). Subsequent Lambda
+    runs will re-enter this function.
 
     Parameters
     ----------

mip_api/chart.py

@@ -105,33 +105,20 @@ def process_chart(params, chart_dict, omit_list, other, no_program):
 
             if priority_codes is not None:
                 if short in priority_codes:
-                    # Since Python 3.7, python dictionaries preserve insertion
-                    # order, so to prepend an item to the top of the dictionary,
-                    # we create a new dictionary inserting the target code first,
-                    # then add the previous output, and finally save the new
-                    # dictionary as our output dictionary.
-                    new_chart = {short: name}
-                    new_chart.update(out_chart)
-                    out_chart = new_chart
-                    found_codes.append(short)
+                    out_chart = util.dict_prepend(out_chart, short, name)
                 else:
                     out_chart[short] = name
-                    found_codes.append(short)
             else:
                 out_chart[short] = name
-                found_codes.append(short)
+            found_codes.append(short)
 
     # inject "other" code
     if util.param_other_bool(params):
-        new_chart = {other: "Other"}
-        new_chart.update(out_chart)
-        out_chart = new_chart
+        out_chart = util.dict_prepend(out_chart, other, "Other")
 
     # inject "no program" code
     if util.param_no_program_bool(params):
-        new_chart = {no_program: "No Program"}
-        new_chart.update(out_chart)
-        out_chart = new_chart
+        out_chart = util.dict_prepend(out_chart, no_program, "No Program")
 
     return out_chart
 

mip_api/ssm.py

@@ -38,11 +38,14 @@ def get_secrets(ssm_path):
             ssm_secrets[name] = p["Value"]
             LOG.info(f"Loaded secret: {name}")
     else:
-        LOG.error(f"Invalid response from SSM client")
-        raise Exception
+        msg = "Invalid response from SSM client"
+        LOG.error(msg)
+        raise Exception(msg)
 
     for reqkey in ["user", "pass"]:
         if reqkey not in ssm_secrets:
-            raise Exception(f"Missing required secure parameter: {reqkey}")
+            msg = f"Missing required secure parameter: {reqkey}"
+            LOG.error(msg)
+            raise Exception(msg)
 
     return ssm_secrets

mip_api/util.py

@@ -1,6 +1,16 @@
 import os
 
 
+def dict_prepend(original, key, value):
+    # Since Python 3.7, python dictionaries preserve insertion
+    # order, so to prepend an item to the top of the dictionary,
+    # we create a new dictionary inserting the new key first,
+    # then add the previous output
+    new_dict = {key: value}
+    new_dict.update(original)
+    return new_dict
+
+
 def get_os_var(varnam):
     try:
         return os.environ[varnam]
@@ -37,10 +47,14 @@ def param_no_program_bool(params):
 def param_limit_int(params):
     if params and "limit" in params:
         try:
-            return int(params["limit"])
+            number = int(params["limit"])
         except ValueError as exc:
             err_str = "QueryStringParameter 'limit' must be an Integer"
             raise ValueError(err_str) from exc
+
+        if number < 0:
+            raise ValueError("QueryStringParameter 'limit' must be a positive Integer")
+        return number
     return 0
 
 

template.yaml

@@ -67,6 +67,9 @@ Resources:
             Transitions:
               - TransitionInDays: 3
                 StorageClass: INTELLIGENT_TIERING
+          - Id: ExpireOldObjectVersions
+            Status: Enabled
+            NoncurrentVersionExpirationInDays: 365
 
   CacheBucketPolicy:
     Type: AWS::S3::BucketPolicy