Skip to content

Commit ecf7e87

Browse files
committed
Merge branch 'stage' into stage-to-prod-remove-zipkin
2 parents 70bc853 + 166da99 commit ecf7e87

File tree

2 files changed

+1
-20
lines changed

2 files changed

+1
-20
lines changed

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ repos:
2020
hooks:
2121
- id: yamllint
2222
- repo: https://github.com/awslabs/cfn-python-lint
23-
rev: v1.34.2
23+
rev: v1.35.3
2424
hooks:
2525
- id: cfn-python-lint
2626
args:

app.py

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -165,22 +165,6 @@
165165
)
166166
service_registry_stack.add_dependency(config_server_stack)
167167

168-
zipkin_props = ServiceProps(
169-
"openchallenges-zipkin",
170-
9411,
171-
512,
172-
f"ghcr.io/sage-bionetworks/openchallenges-zipkin:{image_version}",
173-
{},
174-
)
175-
176-
zipkin_stack = ServiceStack(
177-
app,
178-
f"{stack_name_prefix}-zipkin",
179-
network_stack.vpc,
180-
ecs_stack.cluster,
181-
zipkin_props,
182-
)
183-
184168
image_service_props = ServiceProps(
185169
"openchallenges-image-service",
186170
8086,
@@ -205,7 +189,6 @@
205189
)
206190
image_service_stack.add_dependency(service_registry_stack)
207191
image_service_stack.add_dependency(thumbor_stack)
208-
image_service_stack.add_dependency(zipkin_stack)
209192

210193
challenge_service_props = ServiceProps(
211194
"openchallenges-challenge-service",
@@ -242,7 +225,6 @@
242225
challenge_service_stack.add_dependency(service_registry_stack)
243226
challenge_service_stack.add_dependency(mariadb_stack)
244227
challenge_service_stack.add_dependency(elasticsearch_stack)
245-
challenge_service_stack.add_dependency(zipkin_stack)
246228

247229

248230
organization_service_props = ServiceProps(
@@ -274,7 +256,6 @@
274256
organization_service_stack.add_dependency(image_service_stack)
275257
organization_service_stack.add_dependency(mariadb_stack)
276258
organization_service_stack.add_dependency(elasticsearch_stack)
277-
organization_service_stack.add_dependency(zipkin_stack)
278259

279260
api_gateway_props = ServiceProps(
280261
"openchallenges-api-gateway",

0 commit comments

Comments
 (0)