Skip to content

Commit 5e0713e

Browse files
authored
Throttle Sceptre deployment (#1498)
AWS is throttling cloudformation deployments to service catalog accounts because there are too many requests to the service catalog APIs. This is causing deployments to fail and put service catalog in a bad state. This reverts the temporary disabling of service catalog deployments in PR #1496. It also installs a development version of Sceptre containing a max-concurrency option that will throttle sceptre requests to avoid the AWS throttling.
1 parent 7aea11b commit 5e0713e

File tree

3 files changed

+27
-27
lines changed

3 files changed

+27
-27
lines changed

.github/workflows/aws-deploy.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
- name: Install dependencies
4646
run: |
4747
python -m pip install --upgrade pip
48-
pip install sceptre sceptre-json-resolver sceptre-request-resolver sceptre-ssm-resolver
48+
pip install git+https://github.com/zaro0508/sceptre@max-concurrency sceptre-json-resolver sceptre-request-resolver sceptre-ssm-resolver
4949
- name: Assume AWS Role
5050
uses: aws-actions/configure-aws-credentials@v2
5151
with:

.github/workflows/aws-scipool.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
- name: Install dependencies
4747
run: |
4848
python -m pip install --upgrade pip
49-
pip install sceptre sceptre-json-resolver sceptre-request-resolver sceptre-ssm-resolver
49+
pip install git+https://github.com/zaro0508/sceptre@max-concurrency sceptre-json-resolver sceptre-request-resolver sceptre-ssm-resolver
5050
- name: Assume AWS Role
5151
uses: aws-actions/configure-aws-credentials@v2
5252
with:

.github/workflows/deploy.yaml

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -110,38 +110,38 @@ jobs:
110110
role-to-assume: "arn:aws:iam::751556145034:role/github-oidc-sage-bionetworks-it"
111111
role-session-name: ${{ needs.org-formation.outputs.role-session-name }}
112112
working-dir: "sceptre/strides-ampad-workflows"
113-
# temporarily disabling scipool deployments due to AWS throttling issues
114-
# sceptre-scipooldev:
115-
# needs: [org-formation]
116-
# uses: "./.github/workflows/aws-deploy.yaml"
117-
# with:
118-
# role-to-assume: "arn:aws:iam::465877038949:role/sagebase-github-oidc-sage-bionetworks-it"
119-
# working-dir: "sceptre/scipool"
120-
# role-session-name: ${{ needs.org-formation.outputs.role-session-name }}
121-
# sceptre-command: "sceptre launch develop --prune --yes"
122-
# sceptre-scipoolprod:
123-
# needs: [org-formation]
124-
# uses: "./.github/workflows/aws-scipool.yaml"
125-
# with:
126-
# role-to-assume: "arn:aws:iam::237179673806:role/sagebase-github-oidc-sage-bionetworks-it"
127-
# role-session-name: ${{ needs.org-formation.outputs.role-session-name }}
128-
# working-dir: "sceptre/scipool"
129-
# sceptre-stridespool:
130-
# needs: [org-formation, sceptre-strides]
131-
# uses: "./.github/workflows/aws-scipool.yaml"
132-
# with:
133-
# role-to-assume: "arn:aws:iam::423819316185:role/github-oidc-sage-bionetworks-it"
134-
# role-session-name: ${{ needs.org-formation.outputs.role-session-name }}
135-
# working-dir: "sceptre/scipool"
136-
# sceptre-command: "sceptre launch strides --prune --yes"
113+
sceptre-scipooldev:
114+
needs: [org-formation]
115+
uses: "./.github/workflows/aws-deploy.yaml"
116+
with:
117+
role-to-assume: "arn:aws:iam::465877038949:role/sagebase-github-oidc-sage-bionetworks-it"
118+
working-dir: "sceptre/scipool"
119+
role-session-name: ${{ needs.org-formation.outputs.role-session-name }}
120+
sceptre-command: "sceptre launch develop --prune --yes --max-concurrency 1"
121+
sceptre-scipoolprod:
122+
needs: [org-formation]
123+
uses: "./.github/workflows/aws-scipool.yaml"
124+
with:
125+
role-to-assume: "arn:aws:iam::237179673806:role/sagebase-github-oidc-sage-bionetworks-it"
126+
role-session-name: ${{ needs.org-formation.outputs.role-session-name }}
127+
working-dir: "sceptre/scipool"
128+
sceptre-command: "sceptre launch prod --prune --yes --max-concurrency 1"
129+
sceptre-stridespool:
130+
needs: [org-formation, sceptre-strides]
131+
uses: "./.github/workflows/aws-scipool.yaml"
132+
with:
133+
role-to-assume: "arn:aws:iam::423819316185:role/github-oidc-sage-bionetworks-it"
134+
role-session-name: ${{ needs.org-formation.outputs.role-session-name }}
135+
working-dir: "sceptre/scipool"
136+
sceptre-command: "sceptre launch strides --prune --yes --max-concurrency 1"
137137
sceptre-sageit-staging:
138138
needs: [org-formation]
139139
uses: "./.github/workflows/aws-deploy.yaml"
140140
with:
141141
role-to-assume: "arn:aws:iam::797640923903:role/sagebase-github-oidc-sage-bionetworks-it"
142142
role-session-name: ${{ needs.org-formation.outputs.role-session-name }}
143143
working-dir: "sceptre/sageit"
144-
sceptre-command: "sceptre launch staging --prune --yes"
144+
sceptre-command: "sceptre launch staging --prune --yes --max-concurrency 1"
145145
sceptre-sageit-prod:
146146
needs: [org-formation]
147147
uses: "./.github/workflows/aws-deploy.yaml"

0 commit comments

Comments
 (0)