Skip to content

Commit 830c6ee

Browse files
authored
Update pre-commit linters (#1431)
* Update linters * Ignore linter warning `W3037` because it doesn't make sense.. ``` W3037 'listcertificates,' is not one of ['addtagstocertificate', 'deletecertificate', 'describecertificate', 'exportcertificate', 'getaccountconfiguration', 'getcertificate', 'importcertificate', 'listcertificates', 'listtagsforcertificate', 'putaccountconfiguration', 'removetagsfromcertificate', 'renewcertificate', 'requestcertificate', 'resendvalidationemail', 'revokecertificate', 'updatecertificateoptions'] sceptre/sageit/templates/accounts.yaml:24:11 ``` `listcertificates` is in the list of valid permissions.
1 parent 0533439 commit 830c6ee

File tree

5 files changed

+25
-3
lines changed

5 files changed

+25
-3
lines changed

.pre-commit-config.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ repos:
2222
hooks:
2323
- id: yamllint
2424
- repo: https://github.com/awslabs/cfn-python-lint
25-
rev: v1.27.0
25+
rev: v1.36.1
2626
hooks:
2727
- id: cfn-python-lint
2828
files: templates/.*\.(json|yml|yaml)$
@@ -32,7 +32,7 @@ repos:
3232
hooks:
3333
- id: remove-tabs
3434
- repo: https://github.com/sirosen/check-jsonschema
35-
rev: 0.33.0
35+
rev: 0.33.1
3636
hooks:
3737
- id: check-github-workflows
3838
- id: check-github-actions

sceptre/sageit/templates/accounts.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
---
22
Description: Setup IAM policies, groups and accounts
33
AWSTemplateFormatVersion: 2010-09-09
4+
Metadata:
5+
cfn-lint:
6+
config:
7+
ignore_checks: [W3037]
48
Resources:
59
# !! IMPORTANT !! - AWS API will refuse to remove users that have attached resources.
610
# Therefore you must do the following before deleting them from this file:

sceptre/synapsedev/templates/SynapseCMK-template.json

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
{
22
"AWSTemplateFormatVersion": "2010-09-09",
33
"Description": "The master encryption key used to encypt/decypt all Synapse master secrets",
4+
"Metadata": {
5+
"cfn-lint": {
6+
"config": {
7+
"ignore_checks": [
8+
"W3037"
9+
]
10+
}
11+
}
12+
},
413
"Parameters": {
514
"Stack": {
615
"Description": "The stack",

sceptre/synapsedev/templates/accounts.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ AWSTemplateFormatVersion: 2010-09-09
33
Metadata:
44
cfn-lint:
55
config:
6-
ignore_checks: [ "W1011" ]
6+
ignore_checks: [ "W1011", "W3037" ]
77
Parameters:
88
InitNewUserPassword:
99
Type: String

sceptre/synapseprod/templates/SynapseCMK-template.json

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
{
22
"AWSTemplateFormatVersion": "2010-09-09",
33
"Description": "The master encryption key used to encypt/decypt all Synapse master secrets",
4+
"Metadata": {
5+
"cfn-lint": {
6+
"config": {
7+
"ignore_checks": [
8+
"W3037"
9+
]
10+
}
11+
}
12+
},
413
"Parameters": {
514
"Stack": {
615
"Description": "The stack",

0 commit comments

Comments
 (0)