Skip to content

Commit 68f9564

Browse files
authored
Merge pull request #48 from Sage-Bionetworks-Workflows/bwmac/orca-269/tifftag306test_update
[ORCA-269] TiffTag306Test Update
2 parents 45bbcba + d0ecd4e commit 68f9564

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/dcqc/tests/tiff_tag_306_date_time_test.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,12 @@ def generate_process(self) -> Process:
1414
"tifftools",
1515
"dump",
1616
f"'{path.name}'",
17+
"--json",
18+
"--silent",
1719
"|",
18-
"grep", # pipe the output
19-
"-a", # treat input as text
20-
"-q", # suppress output
21-
"'DateTime 306 (0x132) ASCII'", # match the DateTime 306 tag
20+
"jq",
21+
"-e",
22+
"'.[].ifds[].tags[\"306\"]'",
2223
]
2324
process = Process(
2425
container="ghcr.io/sage-bionetworks-workflows/tifftools:latest",

tests/test_tests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ def test_that_the_tifftag306datetimetest_command_is_produced(test_targets):
267267
target = test_targets["tiff"]
268268
test = tests.TiffTag306DateTimeTest(target)
269269
process = test.generate_process()
270-
assert "grep" in process.command
270+
assert "jq" in process.command
271271

272272

273273
def test_that_the_tifftag306datetimetest_correctly_interprets_exit_code_0_and_1(

0 commit comments

Comments
 (0)