Update tests for new File staging behavior

Author: Bruno Grande

src/dcqc/file.py

@@ -220,6 +220,7 @@ def stage(self, destination: Optional[str] = None, overwrite: bool = False) -> P
             with destination_path.open("wb") as dest_file:
                 self.fs.download(self.fs_path, dest_file)
 
+        self.local_path = destination_path.as_posix()
         return destination_path
 
     def to_dict(self) -> SerializedObject:

tests/test_file.py

@@ -33,18 +33,18 @@ def test_that_a_local_file_is_not_moved_when_requesting_a_local_path(test_files)
 
 
 @pytest.mark.integration
-def test_for_an_error_when_requesting_a_local_path_for_a_remote_file(test_files):
+def test_for_an_error_when_getting_local_path_for_an_unstaged_remote_file(test_files):
     file = test_files["synapse"]
-    with pytest.raises(FileNotFoundError):
+    with pytest.raises(ValueError):
         file.get_local_path()
 
 
 @pytest.mark.integration
 def test_that_a_local_file_is_not_moved_when_staged_without_a_destination(test_files):
     test_file = test_files["good"]
-    url_before = test_file.url
-    url_after = test_file.stage()
-    assert url_before == url_after
+    path_before = test_file.get_local_path()
+    path_after = test_file.stage()
+    assert path_before == path_after
 
 
 @pytest.mark.integration
@@ -59,23 +59,20 @@ def test_that_a_local_file_is_symlinked_when_staged_with_a_destination(test_file
 
 
 @pytest.mark.integration
-def test_for_an_error_when_a_remote_file_is_staged_without_a_destination(test_files):
+def test_that_a_local_temporary_path_is_created_when_staging_a_remote_file(test_files):
     file = test_files["synapse"]
-    with pytest.raises(ValueError):
-        file.stage()
+    file.stage()
+    assert file.get_local_path() is not None
 
 
 @pytest.mark.integration
-def test_that_a_remote_file_is_moved_when_staged_with_a_destination(test_files):
+def test_that_a_remote_file_is_created_when_staged_with_a_destination(test_files):
     test_file = test_files["synapse"]
     with TemporaryDirectory() as tmp_dir:
-        original_url = test_file.url
         test_file.stage(tmp_dir)
-        after_url = test_file.url
-        after_path = Path(test_file.get_local_path())
-        assert original_url != after_url
-        assert after_path.exists()
-        assert not after_path.is_symlink()
+        local_path = test_file.get_local_path()
+        assert local_path.exists()
+        assert not local_path.is_symlink()
 
 
 def test_that_a_file_can_be_saved_and_restored_without_changing(test_files):