Skip to content

Commit 571ba37

Browse files
committed
remove includeinpanel
1 parent 531340b commit 571ba37

File tree

4 files changed

+21
-20
lines changed

4 files changed

+21
-20
lines changed

genie/database_to_staging.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1802,7 +1802,7 @@ def stagingToCbio(
18021802
bedDf = extract.get_syntabledf(
18031803
syn,
18041804
"SELECT Chromosome,Start_Position,End_Position,Hugo_Symbol,ID,"
1805-
"SEQ_ASSAY_ID,Feature_Type,includeInPanel,clinicalReported FROM"
1805+
"SEQ_ASSAY_ID,Feature_Type,clinicalReported FROM"
18061806
f" {bedSynId} where CENTER in ('{center_query_str}')",
18071807
)
18081808

genie_registry/bed.py

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -456,9 +456,12 @@ def create_gene_panel(self, beddf, seq_assay_id, gene_panel_path, parentid):
456456
"""
457457
LOGGER.info("CREATING GENE PANEL")
458458
if not beddf.empty:
459-
exonsdf = beddf[beddf["Feature_Type"] == "exon"]
459+
# exonsdf = beddf[beddf["Feature_Type"] == "exon"]
460460
# Only include genes that should be included in the panels
461-
include_exonsdf = exonsdf[exonsdf["includeInPanel"]]
461+
#include_exonsdf = exonsdf[exonsdf["includeInPanel"]]
462+
463+
# Include all genes in the panels
464+
include_exonsdf = beddf[beddf["Feature_Type"] == "exon"]
462465
# Write gene panel
463466
null_genes = include_exonsdf["Hugo_Symbol"].isnull()
464467
unique_genes = set(include_exonsdf["Hugo_Symbol"][~null_genes])
@@ -631,11 +634,11 @@ def _validate(self, beddf):
631634
"Start_Position",
632635
"End_Position",
633636
"Hugo_Symbol",
634-
"includeInPanel",
637+
#"includeInPanel",
635638
]
636639
if len(beddf.columns) < len(newcols):
637640
total_error += (
638-
"BED file: Must at least have five columns in this "
641+
"BED file: Must at least have four columns in this "
639642
"order: {}. Make sure there are "
640643
"no headers.\n".format(", ".join(newcols))
641644
)
@@ -675,15 +678,15 @@ def _validate(self, beddf):
675678
"Hugo_Symbol column, not the strand column\n"
676679
)
677680

678-
warn, error = process_functions.check_col_and_values(
679-
beddf,
680-
"includeInPanel",
681-
[True, False],
682-
filename="BED file",
683-
required=True,
684-
)
685-
warning += warn
686-
total_error += error
681+
#warn, error = process_functions.check_col_and_values(
682+
# beddf,
683+
# "includeInPanel",
684+
# [True, False],
685+
# filename="BED file",
686+
# required=True,
687+
#)
688+
#warning += warn
689+
#total_error += error
687690

688691
if to_validate_symbol:
689692
gene_position_table = self.syn.tableQuery("SELECT * FROM syn11806563")

templates/dashboardTemplate.Rmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,7 @@ A user of the GENIE data pointed out that the expected gene count numbers in the
645645

646646
```{r genepanel_diff, echo=F}
647647
if (!is.null(assay_infodf) & !is.null(this_bed)) {
648-
gene_panel_bed = this_bed[this_bed$Feature_Type == "exon" & this_bed$includeInPanel == "True" & this_bed$Hugo_Symbol != "", ]
648+
gene_panel_bed = this_bed[this_bed$Feature_Type == "exon" & this_bed$Hugo_Symbol != "", ]
649649
# Get count of symbols per panel
650650
symbol_count_per_panel = table(gene_panel_bed$Hugo_Symbol, gene_panel_bed$SEQ_ASSAY_ID)
651651
# Get whether or not a panel contains a certain symbol

tests/test_bed.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -309,9 +309,9 @@ def test_missingcols_failure__validate(bed_class):
309309
emptydf = pd.DataFrame()
310310
error, warning = bed_class._validate(emptydf)
311311
expected_errors = (
312-
"BED file: Must at least have five columns in this order: "
313-
"Chromosome, Start_Position, End_Position, Hugo_Symbol, "
314-
"includeInPanel. Make sure there are no headers.\n"
312+
"BED file: Must at least have four columns in this order: "
313+
"Chromosome, Start_Position, End_Position, Hugo_Symbol. "
314+
"Make sure there are no headers.\n"
315315
)
316316
assert error == expected_errors
317317
assert warning == ""
@@ -353,8 +353,6 @@ def test_badinputs_failure__validate(bed_class):
353353
"Make sure there are no headers.\n"
354354
"BED file: The End_Position column must only be integers. "
355355
"Make sure there are no headers.\n"
356-
"BED file: Please double check your includeInPanel column. "
357-
"This column must only be these values: True, False\n"
358356
"BED file: Please double check your Chromosome column. "
359357
"This column must only be these values: {possible_vals}\n".format(
360358
possible_vals=", ".join(validate.ACCEPTED_CHROMOSOMES)

0 commit comments

Comments
 (0)