Skip to content

Commit aa8159b

Browse files
committed
fix spacing, change env var hierarchy
1 parent 3260418 commit aa8159b

File tree

1 file changed

+27
-25
lines changed

1 file changed

+27
-25
lines changed

.github/workflows/build_genome_nexus_annotator.yml

Lines changed: 27 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -9,23 +9,22 @@ on:
99
required: true
1010
default: "2e67ebd08cf7c26bf1f55f2baf4b73ac36531119"
1111

12+
env:
13+
# versions for dependencies used in annotator.jar build
14+
MAVEN_VERSION: '3.9.9'
15+
COMMIT_HASH: 2e67ebd08cf7c26bf1f55f2baf4b73ac36531119
16+
JAVA_VERSION: "21"
17+
JAVA_DISTRIBUTION: "corretto"
18+
# synapse id of the Genome Nexus folder
19+
OUTPUT_FOLDER_SYNAPSE_ID: syn22105656
20+
# env vars related to testing the annotator.jar
21+
PROD_DOCKER: ghcr.io/sage-bionetworks/genie:main
22+
SYNAPSE_AUTH_TOKEN: ${{ secrets.SYNAPSE_AUTH_TOKEN }}
23+
TEST_PROJECT_SYNID: syn7208886
1224
jobs:
1325
build-annotator:
1426
runs-on: ubuntu-latest
1527

16-
env:
17-
# versions for dependencies used in annotator.jar build
18-
MAVEN_VERSION: '3.9.9'
19-
COMMIT_HASH: ${{ github.event.inputs.commit_hash }}
20-
JAVA_VERSION: "21"
21-
JAVA_DISTRIBUTION: "corretto"
22-
# synapse id of the Genome Nexus folder
23-
OUTPUT_FOLDER_SYNAPSE_ID: syn22105656
24-
# env vars related to testing the annotator.jar
25-
PROD_DOCKER: ghcr.io/sage-bionetworks/genie:main
26-
SYNAPSE_AUTH_TOKEN: ${{ secrets.SYNAPSE_AUTH_TOKEN }}
27-
TEST_PROJECT_SYNID: syn7208886
28-
2928
steps:
3029
- name: Checkout workflow repo
3130
uses: actions/checkout@v4
@@ -51,7 +50,7 @@ jobs:
5150
run: |
5251
git clone https://github.com/genome-nexus/genome-nexus-annotation-pipeline.git
5352
cd genome-nexus-annotation-pipeline
54-
git checkout ${{ github.event.inputs.commit_hash }}
53+
git checkout ${{ env.COMMIT_HASH }}
5554
5655
- name: Configure application.properties and log4j.properties to be genie specific
5756
run: |
@@ -60,19 +59,22 @@ jobs:
6059
mkdir -p $CONFIG_PATH
6160
6261
# Create or overwrite application.properties
63-
cat <<EOF > ${CONFIG_PATH}/application.properties
64-
spring.batch.job.enabled=false
65-
spring.jmx.enabled=false
66-
chunk=100
67-
genomenexus.enrichment_fields=annotation_summary,sift,polyphen,my_variant_info
68-
genomenexus.isoform_query_parameter=isoformOverrideSource
69-
genomenexus.base=https://genie.genomenexus.org/
70-
EOF
62+
cat <<'EOF' > "${CONFIG_PATH}/application.properties"
63+
spring.batch.job.enabled=false
64+
spring.jmx.enabled=false
65+
chunk=100
66+
genomenexus.enrichment_fields=annotation_summary,sift,polyphen,my_variant_info
67+
genomenexus.isoform_query_parameter=isoformOverrideSource
68+
genomenexus.base=https://genie.genomenexus.org/
69+
EOF
7170

7271
# Create or overwrite log4j.properties
73-
cat <<EOF > ${CONFIG_PATH}/log4j.properties
74-
log4j.appender.a.File=/tmp/genomenexus-logfile.log
75-
EOF
72+
cat <<'EOF' > "${CONFIG_PATH}/log4j.properties"
73+
log4j.appender.a.File=/tmp/genomenexus-logfile.log
74+
EOF
75+
76+
echo "[INFO] Application and log configs written."
77+
7678

7779
echo "[INFO] Application and log configs written."
7880

0 commit comments

Comments
 (0)