switch name to _validation_errors

Author: rxu17

genie/write_invalid_reasons.py

@@ -33,15 +33,15 @@ def write(
         errors_synid = center_mapping_df["errorsSynId"][
             center_mapping_df["center"] == center
         ][0]
-        with open(center + "_errors.txt", "w") as errorfile:
+        with open(center + "_validation_errors.txt", "w") as errorfile:
             if center not in center_errors:
                 errorfile.write("No errors!")
             else:
                 errorfile.write(center_errors[center])
 
-        ent = synapseclient.File(center + "_errors.txt", parentId=errors_synid)
+        ent = synapseclient.File(center + "_validation_errors.txt", parentId=errors_synid)
         syn.store(ent)
-        os.remove(center + "_errors.txt")
+        os.remove(center + "_validation_errors.txt")
 
 
 def _combine_center_file_errors(

tests/test_write_invalid_reasons.py

@@ -100,17 +100,17 @@ def _open_side_effect(filename, mode):
             )
 
     # assertions: open + writes
-    m_open.assert_any_call("A_errors.txt", "w")
-    m_open.assert_any_call("B_errors.txt", "w")
+    m_open.assert_any_call("A_validation_errors.txt", "w")
+    m_open.assert_any_call("B_validation_errors.txt", "w")
 
-    file_handles["A_errors.txt"].write.assert_called_once_with("A had errors")
-    file_handles["B_errors.txt"].write.assert_called_once_with("No errors!")
+    file_handles["A_validation_errors.txt"].write.assert_called_once_with("A had errors")
+    file_handles["B_validation_errors.txt"].write.assert_called_once_with("No errors!")
 
     # assertions: correct Synapse folder IDs used (parentId)
-    m_file_cls.assert_any_call("A_errors.txt", parentId="synErrA")
-    m_file_cls.assert_any_call("B_errors.txt", parentId="synErrB")
+    m_file_cls.assert_any_call("A_validation_errors.txt", parentId="synErrA")
+    m_file_cls.assert_any_call("B_validation_errors.txt", parentId="synErrB")
 
     # Synapse store + cleanup
     assert syn.store.call_args_list == [mock.call(ent_a), mock.call(ent_b)]
-    m_remove.assert_any_call("A_errors.txt")
-    m_remove.assert_any_call("B_errors.txt")
+    m_remove.assert_any_call("A_validation_errors.txt")
+    m_remove.assert_any_call("B_validation_errors.txt")