Merge pull request #5507 from brucehoff/PLFM-9441

PLFM-9441

Author: brucehoff

lib/jdomodels/src/main/resources/schema/RealmIdentityProvider-ddl.sql

@@ -1,6 +1,6 @@
 CREATE TABLE IF NOT EXISTS `SYNAPSE_REALM_IDP` (
   `REALM_ID` BIGINT NOT NULL,
-  `PROVIDER` ENUM('SYNAPSE', 'GOOGLE_OAUTH_2_0', 'ORCID', 'ARCUS_BIOSCIENCES') NOT NULL,
+  `PROVIDER` ENUM('SYNAPSE', 'GOOGLE_OAUTH_2_0', 'ORCID', 'ARCUS_BIOSCIENCES', 'SAGE_BIONETWORKS') NOT NULL,
   PRIMARY KEY (`REALM_ID`, `PROVIDER`),
   UNIQUE (`PROVIDER`),
   CONSTRAINT `REALM_ID_REALM_FK` FOREIGN KEY (`REALM_ID`) REFERENCES `SYNAPSE_REALM` (`ID`) ON DELETE CASCADE

lib/jdomodels/src/test/java/org/sagebionetworks/repo/model/dbo/auth/RealmDaoImplTest.java

@@ -255,9 +255,15 @@ void testValidateAllOAuthProviders() {
 		Realm realm = new Realm();
 		realm.setName(NAME);
 		realm.setIdentityProvider(idps);
+		
 		// method under test
 		Realm created = realmDao.createRealm(realm);
+		
 		idsToDelete.add(created.getId());
+
+		// 'createRealm' may not raise an exception when it fails
+		// but the following will
+		realmDao.getRealm(created.getId());
 	}
 
 	@Test