Skip to content

Commit b52411b

Browse files
authored
Merge pull request #86 from Sage-Bionetworks/etl-567
[ETL-567] Use ECS logging in S3 to JSON job
2 parents fc5d945 + 8f15a6e commit b52411b

File tree

8 files changed

+526
-350
lines changed

8 files changed

+526
-350
lines changed

.github/workflows/upload-and-deploy.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,10 @@ jobs:
7878
role_session_name: ${{ github.event.repository.name }}-${{ github.run_id }}-nonglue-unit-tests
7979
python_version: ${{ env.PYTHON_VERSION }}
8080

81+
- name: Install additional python dependency
82+
run: |
83+
pipenv install ecs_logging~=2.0
84+
8185
- name: Test lambda scripts with pytest
8286
run: |
8387
pipenv run python -m pytest tests/test_s3_event_config_lambda.py -v

Pipfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,4 @@ pandas = "<1.5"
1717
moto = "~=4.1"
1818
datacompy = "~=0.8"
1919
docker = "~=6.1"
20+
ecs_logging = "~=2.0"

config/develop/namespaced/glue-job-S3ToJsonS3.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,6 @@ parameters:
1111
S3ScriptKey: '{{ stack_group_config.namespace }}/src/glue/jobs/s3_to_json.py'
1212
GluePythonShellVersion: "{{ stack_group_config.glue_python_shell_python_version }}"
1313
GlueVersion: "{{ stack_group_config.glue_python_shell_glue_version }}"
14+
AdditionalPythonModules: ecs_logging~=2.0
1415
stack_tags:
1516
{{ stack_group_config.default_stack_tags }}

config/prod/namespaced/glue-job-S3ToJsonS3.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,6 @@ parameters:
1111
S3ScriptKey: '{{ stack_group_config.namespace }}/src/glue/jobs/s3_to_json.py'
1212
GluePythonShellVersion: "{{ stack_group_config.glue_python_shell_python_version }}"
1313
GlueVersion: "{{ stack_group_config.glue_python_shell_glue_version }}"
14+
AdditionalPythonModules: ecs_logging~=2.0
1415
stack_tags:
1516
{{ stack_group_config.default_stack_tags }}

0 commit comments

Comments
 (0)