add value error

Author: andrewelamb

synapseclient/extensions/curator/schema_generation.py

@@ -5516,6 +5516,9 @@ def generate_jsonschema(
             - A list of JSON schema dictionaries, each corresponding to a data type
             - A list of file paths where the schemas were written
 
+    Raises:
+        ValueError: If a single output file is specified but multiple data types are requested.
+
     Example: Using this function to generate JSON Schema files:
         Generate schema for one datatype:
 
@@ -5560,15 +5563,19 @@ def generate_jsonschema(
         path_to_data_model=data_model_source, logger=synapse_client.logger
     )
     parsed_data_model = data_model_parser.parse_model()
-    data_model_grapher = DataModelGraph(parsed_data_model)
-    graph_data_model = data_model_grapher.graph
+    data_model_graph = DataModelGraph(parsed_data_model)
+    graph_data_model = data_model_graph.graph
     dmge = DataModelGraphExplorer(graph_data_model, logger=synapse_client.logger)
 
     if output is not None and not output.endswith(".json"):
         dirname = output
         os.makedirs(dirname, exist_ok=True)
     else:
         dirname = "./"
+        if data_types is None or len(data_types) != 1:
+            raise ValueError(
+                "When specifying more than a single output file, don't provide a file path."
+            )
 
     # Gets all data types if none are specified
     if data_types is None or len(data_types) == 0:

tests/unit/synapseclient/extensions/unit_test_curator.py

@@ -2333,3 +2333,36 @@ def test_generate_jsonschema_specify_file(self):
         finally:
             if os.path.isfile("./test.json"):
                 os.remove("./test.json")
+
+    def test_generate_jsonschema_exception_no_datatypes(self):
+        """Test that an exception is raised when no datatypes are provided, and a JSON path is"""
+        try:
+            # GIVEN a CSV schema file
+            # WHEN I generate a schema with specific output file, and no datatype
+            # THEN a ValueError should be raised
+            with pytest.raises(ValueError):
+                generate_jsonschema(
+                    data_model_source=self.test_schema_path,
+                    output="./test.json",
+                    synapse_client=self.syn,
+                )
+        finally:
+            if os.path.isfile("./test.json"):
+                os.remove("./test.json")
+
+    def test_generate_jsonschema_exception_multiple_datatypes(self):
+        """Test that an exception is raised when multiple datatypes are provided, and a JSON path is"""
+        try:
+            # GIVEN a CSV schema file
+            # WHEN I generate a schema with specific output file, and no datatype
+            # THEN a ValueError should be raised
+            with pytest.raises(ValueError):
+                generate_jsonschema(
+                    data_model_source=self.test_schema_path,
+                    output="./test.json",
+                    data_types=["Patient", "Biospecimen"],
+                    synapse_client=self.syn,
+                )
+        finally:
+            if os.path.isfile("./test.json"):
+                os.remove("./test.json")