add new minimal data model and tests

Author: andrewelamb

synapseclient/extensions/curator/schema_generation.py

@@ -2955,7 +2955,7 @@ def define_data_model_relationships(self) -> dict:
                 "edge_dir": "out",
                 "type": list,
                 "edge_rel": True,
-                "required_header": True,
+                "required_header": False,
             },
             "required": {
                 "jsonld_key": "sms:required",
@@ -3004,7 +3004,7 @@ def define_data_model_relationships(self) -> dict:
                 "edge_dir": "in",
                 "type": list,
                 "edge_rel": True,
-                "required_header": True,
+                "required_header": False,
             },
             "isPartOf": {
                 "jsonld_key": "schema:isPartOf",
@@ -3023,7 +3023,7 @@ def define_data_model_relationships(self) -> dict:
                 "node_label": "uri",
                 "type": str,
                 "edge_rel": False,
-                "required_header": True,
+                "required_header": False,
                 "node_attr_dict": {
                     "default": get_label_from_display_name,
                     "standard": get_label_from_display_name,

tests/unit/synapseclient/extensions/schema_files/data_models/minimal_model.csv

@@ -0,0 +1,3 @@
+Attribute,Description,Valid Values,DependsOn,Required,Parent,Validation Rules
+datatype,,,attribute,,DataType,
+attribute,,,,TRUE,DataProperty,

tests/unit/synapseclient/extensions/unit_test_curator.py

@@ -1947,6 +1947,11 @@ def setUp(self):
             "schema_files",
             "data_models/example.model.csv",
         )
+        self.minimal_test_schema_path = os.path.join(
+            os.path.dirname(__file__),
+            "schema_files",
+            "data_models/minimal_model.csv",
+        )
 
     def test_generate_jsonschema_from_csv(self):
         """Test generate_jsonschema from CSV file."""
@@ -1980,6 +1985,38 @@ def test_generate_jsonschema_from_csv(self):
         finally:
             shutil.rmtree(temp_dir)
 
+    def test_generate_jsonschema_from_minimal_csv(self):
+        """Test generate_jsonschema from a minimal CSV file."""
+        # GIVEN a CSV schema file
+        temp_dir = tempfile.mkdtemp()
+        try:
+            # WHEN I generate JSON schemas
+            schemas, file_paths = generate_jsonschema(
+                data_model_source=self.minimal_test_schema_path,
+                output=temp_dir,
+                data_types=None,
+                data_model_labels="class_label",
+                synapse_client=self.syn,
+            )
+
+            # THEN schemas should be generated
+            assert isinstance(schemas, list)
+            assert len(schemas) > 0
+            assert isinstance(file_paths, list)
+            assert len(file_paths) == len(schemas)
+
+            # AND files should exist
+            for file_path in file_paths:
+                assert os.path.exists(file_path), f"Expected file at {file_path}"
+
+            # AND each schema should be valid JSON Schema
+            for schema in schemas:
+                assert isinstance(schema, dict)
+                assert "$schema" in schema
+                assert "properties" in schema
+        finally:
+            shutil.rmtree(temp_dir)
+
     def test_generate_jsonschema_from_jsonld(self):
         """Test generate_jsonschema from JSONLD file."""
         # GIVEN a JSONLD file (first generate it from CSV)

tests/unit/synapseclient/extensions/unit_test_data_model_relationships.py

@@ -39,12 +39,9 @@ def test_define_required_csv_headers(self, dmr: DataModelRelationships):
             "Description",
             "Valid Values",
             "DependsOn",
-            "DependsOn Component",
             "Required",
             "Parent",
             "Validation Rules",
-            "Properties",
-            "Source",
         ]
 
     @pytest.mark.parametrize("edge", [True, False], ids=["True", "False"])