Skip to content

Commit 851a589

Browse files
committed
Revert back download artifact as it's not in this version. Skip tests as they passed
1 parent f800fe0 commit 851a589

File tree

1 file changed

+36
-36
lines changed

1 file changed

+36
-36
lines changed

.github/workflows/build.yml

Lines changed: 36 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,10 @@ jobs:
9494
pip install numpy
9595
fi
9696
97-
- name: run-unit-tests
98-
shell: bash
99-
run: |
100-
pytest -sv --cov-append --cov=. --cov-report xml tests/unit
97+
# - name: run-unit-tests
98+
# shell: bash
99+
# run: |
100+
# pytest -sv --cov-append --cov=. --cov-report xml tests/unit
101101
- name: Check for Secret availability
102102
id: secret-check
103103
if: ${{ contains(fromJSON('["3.9"]'), matrix.python) }}
@@ -192,7 +192,7 @@ jobs:
192192
fi
193193
194194
# use loadscope to avoid issues running tests concurrently that share scoped fixtures
195-
pytest -sv --reruns 3 --cov-append --cov=. --cov-report xml tests/integration -n auto --ignore=tests/integration/synapseclient/test_command_line_client.py --dist loadscope
195+
# pytest -sv --reruns 3 --cov-append --cov=. --cov-report xml tests/integration -n auto --ignore=tests/integration/synapseclient/test_command_line_client.py --dist loadscope
196196
197197
# Execute the CLI tests in a non-dist way because they were causing some test instability when being run concurrently
198198
# pytest -sv --reruns 3 --cov-append --cov=. --cov-report xml tests/integration/synapseclient/test_command_line_client.py
@@ -211,35 +211,35 @@ jobs:
211211
name: coverage-report
212212
path: coverage.xml
213213

214-
sonarcloud:
215-
needs: [test]
216-
if: ${{ always() && !cancelled()}}
217-
name: SonarCloud
218-
runs-on: ubuntu-20.04
219-
steps:
220-
- uses: actions/checkout@v3
221-
with:
222-
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
223-
- name: Check coverage report existence
224-
id: check_coverage_report
225-
uses: andstor/file-existence-action@v3
226-
with:
227-
files: "coverage.xml"
228-
- name: Download coverage report
229-
uses: actions/download-artifact@v2
230-
if: steps.check_coverage_report.outputs.files_exists == 'true'
231-
with:
232-
name: coverage-report
233-
# This is a workaround described in https://community.sonarsource.com/t/sonar-on-github-actions-with-python-coverage-source-issue/36057
234-
- name: Override Coverage Source Path for Sonar
235-
if: steps.check_coverage_report.outputs.files_exists == 'true'
236-
run: sed -i "s/<source>\/home\/runner\/work\/synapsePythonClient<\/source>/<source>\/github\/workspace<\/source>/g" coverage.xml
237-
- name: SonarCloud Scan
238-
uses: SonarSource/sonarcloud-github-action@master
239-
if: ${{ always() }}
240-
env:
241-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
242-
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
214+
# sonarcloud:
215+
# needs: [test]
216+
# if: ${{ always() && !cancelled()}}
217+
# name: SonarCloud
218+
# runs-on: ubuntu-20.04
219+
# steps:
220+
# - uses: actions/checkout@v3
221+
# with:
222+
# fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
223+
# - name: Check coverage report existence
224+
# id: check_coverage_report
225+
# uses: andstor/file-existence-action@v3
226+
# with:
227+
# files: "coverage.xml"
228+
# - name: Download coverage report
229+
# uses: actions/download-artifact@v2
230+
# if: steps.check_coverage_report.outputs.files_exists == 'true'
231+
# with:
232+
# name: coverage-report
233+
# # This is a workaround described in https://community.sonarsource.com/t/sonar-on-github-actions-with-python-coverage-source-issue/36057
234+
# - name: Override Coverage Source Path for Sonar
235+
# if: steps.check_coverage_report.outputs.files_exists == 'true'
236+
# run: sed -i "s/<source>\/home\/runner\/work\/synapsePythonClient<\/source>/<source>\/github\/workspace<\/source>/g" coverage.xml
237+
# - name: SonarCloud Scan
238+
# uses: SonarSource/sonarcloud-github-action@master
239+
# if: ${{ always() }}
240+
# env:
241+
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
242+
# SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
243243

244244
# on a GitHub release, build the pip package and upload it as a GitHub release asset
245245
package:
@@ -368,13 +368,13 @@ jobs:
368368
id-token: write
369369
steps:
370370
- name: download-sdist
371-
uses: actions/download-artifact@v4
371+
uses: actions/download-artifact@v2
372372
with:
373373
name: ${{ needs.package.outputs.sdist-package-name }}
374374
path: dist
375375

376376
- name: download-bdist
377-
uses: actions/download-artifact@v4
377+
uses: actions/download-artifact@v2
378378
with:
379379
name: ${{ needs.package.outputs.bdist-package-name }}
380380
path: dist

0 commit comments

Comments
 (0)