Add support for external URLs in File model and update related tests

Author: BryanFauble

synapseclient/models/file.py

@@ -813,7 +813,7 @@ async def store_async(
 
             File with an external URL and a parent folder with the ID `syn456`:
 
-                file_instance = await File(name="my_file.txt", external_url="s3://bucket/key", parent_id="syn456", synapse_store=False).store_async()
+                file_instance = await File(name="my_file.txt", external_url="https://example.com/link/to/thing", parent_id="syn456", synapse_store=False).store_async()
 
             File with a parent and existing file handle (This allows multiple entities to reference the underlying file):
 
@@ -1337,7 +1337,7 @@ async def _needs_upload(
                         entity_to_upload.file_handle.id, entity_to_upload.path
                     )
                 )
-            )
+            ) and entity_to_upload.path
 
             md5_stored_in_synapse = (
                 entity_to_upload.file_handle.content_md5

synapseclient/models/protocols/file_protocol.py

@@ -61,6 +61,10 @@ def store(
 
                 file_instance = File(path="path/to/file.txt").store(parent=Folder(id="syn456"))
 
+            File with an external URL and a parent folder with the ID `syn456`:
+
+                file_instance = File(name="my_file.txt", external_url="https://example.com/link/to/thing", parent_id="syn456", synapse_store=False).store()
+
             Rename a file (Does not update the file on disk or the name of the downloaded file):
 
                 file_instance = File(id="syn123", download_file=False).get()

tests/unit/synapseclient/models/async/unit_test_file_async.py

@@ -44,7 +44,7 @@
 MODIFIED_DESCRIPTION = "This is a modified description."
 ACTUAL_PARENT_ID = "syn999"
 
-CANNOT_STORE_FILE_ERROR = "The file must have an (ID with a (path or `data_file_handle_id`)), or a (path with a (`parent_id` or parent with an id)), or a (data_file_handle_id with a (`parent_id` or parent with an id)) to store."
+CANNOT_STORE_FILE_ERROR = "The file must have an (ID with a (path, external_url, or `data_file_handle_id`)), or a ((path or external_url) with a (`parent_id` or parent with an id)), or a (data_file_handle_id with a (`parent_id` or parent with an id)) to store."
 
 
 class TestFile:

tests/unit/synapseclient/models/synchronous/unit_test_file.py

@@ -43,7 +43,7 @@
 MODIFIED_DESCRIPTION = "This is a modified description."
 ACTUAL_PARENT_ID = "syn999"
 
-CANNOT_STORE_FILE_ERROR = "The file must have an (ID with a (path or `data_file_handle_id`)), or a (path with a (`parent_id` or parent with an id)), or a (data_file_handle_id with a (`parent_id` or parent with an id)) to store."
+CANNOT_STORE_FILE_ERROR = "The file must have an (ID with a (path, external_url, or `data_file_handle_id`)), or a ((path or external_url) with a (`parent_id` or parent with an id)), or a (data_file_handle_id with a (`parent_id` or parent with an id)) to store."
 
 
 class TestFile: