Skip to content

Commit d8d7343

Browse files
committed
Correct integration test
1 parent 65c4827 commit d8d7343

File tree

2 files changed

+17
-9
lines changed

2 files changed

+17
-9
lines changed

tests/integration/synapseclient/models/async/test_permissions_async.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -736,17 +736,21 @@ async def test_delete_permissions_recursive(self, project_model: Project) -> Non
736736
await self._set_custom_permissions(file_3)
737737

738738
# WHEN I delete permissions recursively but without container content
739-
await top_level_folder.delete_permissions_async(
740-
recursive=True, include_container_content=False
741-
)
739+
with pytest.raises(
740+
ValueError,
741+
match="When recursive=True, include_container_content must also be True",
742+
) as exc_info:
743+
await top_level_folder.delete_permissions_async(
744+
recursive=True, include_container_content=False
745+
)
742746

743747
# THEN the top_level_folder permissions should be deleted
744748
await self._verify_permissions_deleted(top_level_folder)
745749

746750
# AND the folder_1 permissions should remain (because include_container_content=False)
747751
await self._verify_permissions_not_deleted(folder_1)
748752

749-
# BUT the file_3 permissions should remain (because include_container_content=False)
753+
# AND the file_3 permissions should remain (because include_container_content=False)
750754
assert await self._verify_permissions_not_deleted(file_3)
751755

752756
async def test_delete_permissions_recursive_with_container_content(

tests/integration/synapseclient/models/synchronous/test_permissions.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -727,18 +727,22 @@ async def test_delete_permissions_recursive(self, project_model: Project) -> Non
727727
await self._set_custom_permissions(folder_1)
728728
await self._set_custom_permissions(file_3)
729729

730-
# WHEN I delete permissions recursively but without container content
731-
top_level_folder.delete_permissions(
732-
recursive=True, include_container_content=False
733-
)
730+
with pytest.raises(
731+
ValueError,
732+
match="When recursive=True, include_container_content must also be True",
733+
) as exc_info:
734+
# WHEN I delete permissions recursively but without container content
735+
top_level_folder.delete_permissions(
736+
recursive=True, include_container_content=False
737+
)
734738

735739
# THEN the top_level_folder permissions should be deleted
736740
await self._verify_permissions_deleted(top_level_folder)
737741

738742
# AND the folder_1 permissions should remain (because include_container_content=False)
739743
await self._verify_permissions_not_deleted(folder_1)
740744

741-
# BUT the file_3 permissions should remain (because include_container_content=False)
745+
# AND the file_3 permissions should remain (because include_container_content=False)
742746
assert await self._verify_permissions_not_deleted(file_3)
743747

744748
async def test_delete_permissions_recursive_with_container_content(

0 commit comments

Comments
 (0)