Skip to content

Commit 2767ade

Browse files
committed
remove commented code, change getting user info from query data to use batch command, remove confusing per user/per day plot
1 parent 2c5ceb4 commit 2767ade

File tree

2 files changed

+20
-24
lines changed

2 files changed

+20
-24
lines changed

inst/downloads.Rmd

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -119,19 +119,17 @@ aclUserList <- aclUserList %>%
119119
slice(1) %>%
120120
ungroup()
121121
122-
# # Get sage employees
123-
# sageUserList <- getTeamMemberDF(273957)
124-
# userList <- rbind(userList, sageUserList)
125-
126122
```
127123

128124
```{r summaryuseraccess}
129125
# Get user profile info for users in data download records
130-
allUsersList <- ldply(unique(queryData$userid),
131-
function(x) {
132-
foo <- synGetUserProfile(x);
133-
data.frame(userId=as.character(x),
134-
userName=foo@userName)})
126+
accessUsers <- synRestGET(sprintf("/userGroupHeaders/batch?ids=%s",
127+
paste(unique(queryData$userId),
128+
collapse=",")))
129+
130+
allUsersList <- ldply(accessUsers$children, as.data.frame) %>%
131+
mutate(userId=ownerId) %>%
132+
select(userId, userName)
135133
136134
allUsers <- left_join(allUsersList, aclUserList)
137135
levels(allUsers$teamId) <- c(levels(allUsers$teamId), "None")
@@ -233,8 +231,8 @@ useraccessCount <- queryData %>%
233231
userId=reorder(userId, n, order=TRUE))
234232
```
235233

234+
```{r plotperdayperuser, fig.width=20, fig.height=6, include=FALSE, eval=FALSE}
236235
#### Accesses per day per user
237-
```{r plotperdayperuser, fig.width=20, fig.height=6, include=TRUE, eval=TRUE}
238236
239237
if (useTeamGrouping) {
240238
plotdata <- queryData %>%

inst/webAccess.Rmd

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ output:
33
html_document:
44
keep_md: yes
55
params:
6-
projectId: !r NA
7-
nMonths: 2
8-
useTeamGrouping: TRUE
9-
aclTeamOrder: !r NA
6+
projectId: !r c('2289125')
7+
nMonths: 5
8+
useTeamGrouping: FALSE
9+
aclTeamOrder: !r c('syn2289125')
1010
---
1111

1212
```{r include=FALSE, eval=FALSE, echo=FALSE}
@@ -120,19 +120,17 @@ aclUserList <- aclUserList %>%
120120
slice(1) %>%
121121
ungroup()
122122
123-
# # Get sage employees
124-
# sageUserList <- getTeamMemberDF(273957)
125-
# userList <- rbind(userList, sageUserList)
126-
127123
```
128124

129125
```{r summaryuseraccess}
130126
# Get user profile info for users in data download records
131-
allUsersList <- ldply(unique(queryData$userid),
132-
function(x) {
133-
foo <- synGetUserProfile(x);
134-
data.frame(userId=as.character(x),
135-
userName=foo@userName)})
127+
accessUsers <- synRestGET(sprintf("/userGroupHeaders/batch?ids=%s",
128+
paste(unique(queryData$userId),
129+
collapse=",")))
130+
131+
allUsersList <- ldply(accessUsers$children, as.data.frame) %>%
132+
mutate(userId=ownerId) %>%
133+
select(userId, userName)
136134
137135
allUsers <- left_join(allUsersList, aclUserList)
138136
levels(allUsers$teamId) <- c(levels(allUsers$teamId), "None")
@@ -234,8 +232,8 @@ useraccessCount <- queryData %>%
234232
userId=reorder(userId, n, order=TRUE))
235233
```
236234

235+
```{r plotperdayperuser, fig.width=20, fig.height=6, include=FALSE, eval=FALSE}
237236
#### Accesses per day per user
238-
```{r plotperdayperuser, fig.width=20, fig.height=6, include=TRUE, eval=TRUE}
239237
240238
if (useTeamGrouping) {
241239
plotdata <- queryData %>%

0 commit comments

Comments
 (0)