[Upstream] fix(model): invalidate channel cache after status update#128
Open
Sagit-chu wants to merge 1 commit into
Open
[Upstream] fix(model): invalidate channel cache after status update#128Sagit-chu wants to merge 1 commit into
Sagit-chu wants to merge 1 commit into
Conversation
UpdateChannelStatusById() updates the database but does not refresh the in-memory channel cache (group2model2channels). When MemoryCacheEnabled is true, the stale cache means disabled channels continue to receive traffic until the next SyncChannelCache cycle (default 600 seconds). Call InitChannelCache() after a successful status update to ensure the cache is immediately consistent with the database. Related: songquanpeng#2309 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synced from upstream PR: songquanpeng#2392
Summary
InitChannelCache()insideUpdateChannelStatusById()when memory cache is enabled.Bug
UpdateChannelStatusById()inmodel/channel.goupdates the channel status in the database but does not invalidate the in-memory channel cache (group2model2channels). WhenMemoryCacheEnabledis true, the stale cache means:SyncChannelCache()cycle (default 600 seconds)This affects
DisableChannel(),MetricDisableChannel(), andEnableChannel()inmonitor/channel.go, which all callUpdateChannelStatusById().Fix
After a successful database update, call
InitChannelCache()to immediately refresh the in-memory cache so routing reflects the new channel status.Related: songquanpeng#2309
Test plan
MEMORY_CACHE_ENABLED=truego vet ./model/to confirm no issues🤖 Generated with Claude Code