[Upstream] chore(model): remove unused newChannelId2channel variable#129
Open
Sagit-chu wants to merge 1 commit into
Open
[Upstream] chore(model): remove unused newChannelId2channel variable#129Sagit-chu wants to merge 1 commit into
Sagit-chu wants to merge 1 commit into
Conversation
The variable newChannelId2channel in InitChannelCache() is declared and populated but never read. Remove the dead code. Related: songquanpeng#2321 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synced from upstream PR: songquanpeng#2391
Summary
newChannelId2channelvariable fromInitChannelCache()inmodel/cache.go.Why
The variable is declared at line 174, populated in the loop at line 178, but never read anywhere. It is dead code that wastes memory by building a map that is immediately discarded.
Related: songquanpeng#2321
Test plan
go vet ./model/passes🤖 Generated with Claude Code