[Upstream] fix(billing): prevent nil pointer dereference in GetUsage#131
Open
Sagit-chu wants to merge 1 commit into
Open
[Upstream] fix(billing): prevent nil pointer dereference in GetUsage#131Sagit-chu wants to merge 1 commit into
Sagit-chu wants to merge 1 commit into
Conversation
When `DisplayTokenStatEnabled` is true and `GetTokenById` returns an error (e.g. tokenId is 0), `token` can be nil. Accessing `token.UsedQuota` without checking causes a panic. Add nil and error checks before accessing token fields. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synced from upstream PR: songquanpeng#2389
Summary
token.UsedQuotainGetUsage().Bug
In
controller/billing.go, whenDisplayTokenStatEnabledis true, the code callsmodel.GetTokenById(tokenId)and immediately accessestoken.UsedQuotawithout checking iftokenis nil or if an error occurred.GetTokenByIdreturnsnilwhenid == 0(which can happen if theTokenIdcontext key is missing), causing a nil pointer dereference panic.Test plan
/api/billing/usageendpoint works correctly with a valid token🤖 Generated with Claude Code