1.9.0 - S3 Storage Backend, Instance Deletion Cost Management (#52)

* update dependencies

* set deletion cost to queue length when on salad

* start working on s3 features

* add support for s3

* add test for b64 jpeg

* tests for s3 functionality

* update readme

* clarify title

* more clarity

* update for claude 4

* Update copyright year

* update imports in example workflows

* ignore some directories in tsc

* missed a claude 4

* fix test

* fix test

* build an image with a model to test in the wild

* more info in readme

* more readme

* more readme

* don't need imds sdk.

* don't need that log

* testing deletion cost logic

* bump default comfy to 0.3.38

Author: shawnrushefsky

.github/workflows/build-docker-images.yml

@@ -21,11 +21,11 @@ jobs:
 
       - name: Build Docker images for 50xx
         working-directory: ./docker
-        run: ./build-api-images 0.3.35 2.7.0 12.8
+        run: ./build-api-images 0.3.38 2.7.0 12.8
 
       - name: Build Docker images for pre-50xx
         working-directory: ./docker
-        run: ./build-api-images 0.3.35 2.7.0 12.6
+        run: ./build-api-images 0.3.38 2.7.0 12.6
 
 
 

.gitignore

@@ -134,4 +134,8 @@ bin/
 *.safetensors
 *.ckpt
 *.pth
-test/docker-image/models
+test/docker-image/models
+
+scratch
+
+test/output/*.png

LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2024 Salad Technologies
+Copyright (c) 2025 Salad Technologies
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

README.md

@@ -1,3 +1,4 @@
+# Instructions
 Your job is to convert a json workflow graph for ai image generation into a typescript function.
 - You should define a type for the input, using Zod for validation.
 - You should use `.describe` to describe each parameter to the best of your ability.
@@ -7,9 +8,9 @@ Your job is to convert a json workflow graph for ai image generation into a type
 - LoadImage inputs will always be accepted as either a url or base64 encoded string
 - Only output the typescript, with no additional commentary.
 
-Here is an example output:
 
-```typescript
+# Example Output
+
 import { z } from "zod";
 import config from "../config";
 
@@ -182,5 +183,4 @@ const workflow: Workflow = {
   description: "Generate an image from a text prompt",
 };
 
-export default workflow;
-```
+export default workflow;

claude-endpoint-creation-prompt.md

@@ -1,6 +1,6 @@
 services:
   comfyui:
-    image: ghcr.io/saladtechnologies/comfyui-api:comfy0.3.35-test-image
+    image: ghcr.io/saladtechnologies/comfyui-api:comfy0.3.38-test-image
     volumes:
       - type: bind
         source: ./bin
@@ -13,12 +13,16 @@ services:
       context: ./test/docker-image
       dockerfile: Dockerfile
       args:
-        - comfy_version=0.3.35
+        - comfy_version=0.3.38
     ports:
       - "3000:3000"
       - "8188:8188"
     environment:
       LOG_LEVEL: "debug"
+      AWS_ENDPOINT_URL: "http://localstack:4566"
+      AWS_ACCESS_KEY_ID: "test"
+      AWS_SECRET_ACCESS_KEY: "test"
+      AWS_REGION: "us-east-1"
     #   ALWAYS_RESTART_COMFYUI: "true"
     #   SYSTEM_WEBHOOK_URL: "http://host.docker.internal:1234/system"
     #   SYSTEM_WEBHOOK_EVENTS: all
@@ -29,4 +33,12 @@ services:
             - driver: nvidia
               capabilities: [ gpu ]
               count: all
-
+  localstack:
+    image: localstack/localstack
+    ports:
+      - "4566:4566"  # LocalStack Gateway
+      - "4510-4559:4510-4559"  # External services
+    environment:
+      - SERVICES=s3
+    volumes:
+      - "/var/run/docker.sock:/var/run/docker.sock"

docker-compose.yml

@@ -1,5 +1,5 @@
 ARG base=runtime
-ARG comfy_version=0.3.35
+ARG comfy_version=0.3.38
 ARG pytorch_version=2.7.0
 ARG cuda_version=12.6
 

docker/api.dockerfile

@@ -2,7 +2,7 @@
 
 usage="Usage: $0 [comfy_version] [torch_version] [cuda_version] [api_version]"
 
-comfy_version=${1:-0.3.35}
+comfy_version=${1:-0.3.38}
 torch_version=${2:-2.7.0}
 cuda_version=${3:-12.6}
 

docker/build-api-images

@@ -1,6 +1,6 @@
 #! /usr/bin/bash
 
-comfy_version=${1:-0.3.35}
+comfy_version=${1:-0.3.38}
 torch_version=${2:-2.7.0}
 cuda_version=${3:-12.6}
 bases=("devel" "runtime")

docker/build-comfy-base-images

@@ -24,7 +24,7 @@ RUN uv pip install --no-cache-dir --system comfy-cli
 
 WORKDIR /opt
 
-ARG comfy_version=0.3.35
+ARG comfy_version=0.3.38
 
 RUN git clone --depth 1 --branch v${comfy_version} https://github.com/comfyanonymous/ComfyUI.git