Add tests, fix existing tests

Author: allison-grady

packages/b2c-cli/test/commands/docs/search.test.ts

@@ -43,7 +43,7 @@ describe('docs search', () => {
     const listStub = sinon.stub().returns([{id: 'a', title: 'A', filePath: 'a.md'}]);
     command.operations = {...command.operations, listDocs: listStub};
 
-    const result = await runSilent(() => command.run());
+    const result = (await runSilent(() => command.run())) as {entries: unknown[]};
 
     expect(result.entries).to.have.length(1);
   });
@@ -69,7 +69,7 @@ describe('docs search', () => {
     const searchStub = sinon.stub().returns([{entry: {id: 'a', title: 'A', filePath: 'a.md'}, score: 0.1}]);
     command.operations = {...command.operations, searchDocs: searchStub};
 
-    const result = await runSilent(() => command.run());
+    const result = (await runSilent(() => command.run())) as {results: unknown[]};
 
     expect(result.results).to.have.length(1);
   });

packages/b2c-cli/test/commands/ecdn/security/get.test.ts

@@ -98,7 +98,9 @@ describe('ecdn security get', () => {
         }),
       });
 
-      const result = await runSilent(() => command.run());
+      const result = (await runSilent(() => command.run())) as {
+        settings: {securityLevel: string; wafEnabled: boolean};
+      };
 
       expect(result.settings.securityLevel).to.equal('high');
       expect(result.settings.wafEnabled).to.be.true;

packages/b2c-cli/test/commands/ecdn/zones/list.test.ts

@@ -129,7 +129,10 @@ describe('ecdn zones list', () => {
         }),
       });
 
-      const result = await runSilent(() => command.run());
+      const result = (await runSilent(() => command.run())) as {
+        total: number;
+        zones: Array<{name: string}>;
+      };
 
       expect(result).to.have.property('total', 1);
       expect(result.zones).to.have.lengthOf(1);

packages/b2c-dx-mcp/src/commands/mcp.ts

@@ -148,7 +148,8 @@ import {StdioServerTransport} from '@modelcontextprotocol/sdk/server/stdio.js';
 import {B2CDxMcpServer} from '../server.js';
 import {Services} from '../services.js';
 import {registerToolsets} from '../registry.js';
-import {TOOLSETS, type StartupFlags, loadAppInsightsKey} from '../utils/index.js';
+import {APPLICATION_INSIGHTS_CONNECTION_STRING} from '../config.js';
+import {TOOLSETS, type StartupFlags} from '../utils/index.js';
 
 /**
  * oclif Command that starts the B2C DX MCP server.
@@ -292,7 +293,7 @@ export default class McpServerCommand extends BaseCommand<typeof McpServerComman
     if (process.env.SFCC_TELEMETRY !== 'false') {
       telemetry = createTelemetry({
         project: 'b2c-dx-mcp',
-        appInsightsKey: loadAppInsightsKey(),
+        appInsightsKey: APPLICATION_INSIGHTS_CONNECTION_STRING,
         version: this.config.version,
         initialAttributes: {
           toolsets: (startupFlags.toolsets ?? []).join(', '),

packages/b2c-dx-mcp/src/utils/index.ts

@@ -4,8 +4,6 @@
  * For full license text, see the license.txt file in the repo root or http://www.apache.org/licenses/LICENSE-2.0
  */
 
-import {APPLICATION_INSIGHTS_CONNECTION_STRING} from '../config.js';
-
 /**
  * Utility modules for the B2C DX MCP server.
  *
@@ -17,11 +15,3 @@ import {APPLICATION_INSIGHTS_CONNECTION_STRING} from '../config.js';
 // output needs .js extensions to work at runtime with Node.js ESM.
 export * from './constants.js';
 export * from './types.js';
-
-/**
- * Load the Application Insights connection string.
- * @returns The connection string or undefined if not configured
- */
-export function loadAppInsightsKey(): string | undefined {
-  return APPLICATION_INSIGHTS_CONNECTION_STRING;
-}

packages/b2c-dx-mcp/test/server.test.ts

@@ -143,6 +143,30 @@ describe('B2CDxMcpServer', () => {
       expect(server).to.be.instanceOf(B2CDxMcpServer);
     });
 
+    it('should call telemetry.start() before passing to server (simulated lifecycle)', async () => {
+      // This test verifies the expected telemetry lifecycle:
+      // 1. Create telemetry instance
+      // 2. Call telemetry.start() to initialize the reporter
+      // 3. Pass started telemetry to server
+      const mockTelemetry = new MockTelemetry();
+
+      // Verify telemetry is not started initially
+      expect(mockTelemetry.started).to.be.false;
+
+      // Simulate what mcp.ts does: start telemetry before creating server
+      await mockTelemetry.start();
+      expect(mockTelemetry.started).to.be.true;
+
+      // Now pass to server (as mcp.ts does)
+      const server = new B2CDxMcpServer(
+        {name: 'test-server', version: '1.0.0'},
+        {telemetry: mockTelemetry as unknown as Telemetry},
+      );
+
+      expect(server).to.be.instanceOf(B2CDxMcpServer);
+      expect(mockTelemetry.started).to.be.true;
+    });
+
     it('should create server without options (no telemetry)', () => {
       const server = new B2CDxMcpServer({name: 'test-server', version: '1.0.0'});