Skip to content

Commit 26d0650

Browse files
committed
feat: pwa pd support lint
1 parent b00f065 commit 26d0650

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

packages/commerce-sdk-react/src/components/ShopperExperience/Component/index.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,14 @@ export const Component = memo(function Component({
2525
const DynamicComponent = registry.getComponent(component.typeId)
2626

2727
if (!DynamicComponent) {
28-
// eslint-disable-next-line @typescript-eslint/only-throw-error
2928
throw registry.preload(component.typeId)
3029
}
3130

3231
const designMetadata: ComponentDesignMetadata = {
3332
name: component.designMetadata?.name,
3433
isFragment: false,
35-
isVisible: Boolean(component.visible),
36-
isLocalized: Boolean(component.localized),
34+
isVisible: component.designMetadata?.isVisible ?? false,
35+
isLocalized: component.designMetadata?.isLocalized ?? false,
3736
id: component.id
3837
}
3938

packages/commerce-sdk-react/src/components/ShopperExperience/Page/index.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jest.mock('../Region/region-wrapper', () => ({
2626
)
2727
}))
2828

29-
const SAMPLE_PAGE: PageWithDesignMetadata = {
29+
const SAMPLE_PAGE = {
3030
id: 'samplepage',
3131
typeId: 'storePage',
3232
aspectTypeId: 'pdpAspect',
@@ -82,7 +82,7 @@ const SAMPLE_PAGE: PageWithDesignMetadata = {
8282
components: []
8383
}
8484
]
85-
}
85+
} as unknown as PageWithDesignMetadata
8686

8787
beforeEach(() => {
8888
// Suppress console.log during tests

packages/commerce-sdk-react/src/components/ShopperExperience/Region/index.tsx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import {
1414
} from '@salesforce/storefront-next-runtime/design/react/core'
1515
import type {
1616
ComponentDecoratorProps,
17+
ComponentDesignMetadata,
1718
RegionDesignMetadata
1819
} from '@salesforce/storefront-next-runtime/design/react'
1920

@@ -151,9 +152,11 @@ export function Region(props: RegionProps): ReactElement | null {
151152
return errorElement ? <>{errorElement}</> : null
152153
}
153154

154-
const metadata = props.component.designMetadata?.regionDefinitions?.find(
155-
(r) => r.id === regionId
156-
)
155+
const metadata = (
156+
props.component.designMetadata as ComponentDesignMetadata & {
157+
regionDefinitions?: RegionDesignMetadata[]
158+
}
159+
)?.regionDefinitions?.find((r: RegionDesignMetadata) => r.id === regionId)
157160
return renderRegionContent(region, regionId, metadata, className, rest)
158161
}
159162

0 commit comments

Comments
 (0)