Skip to content

Commit 36ec0af

Browse files
authored
Merge branch 'develop' into mrt-test-ci-deploy
2 parents 81ea5a9 + 3f4bbff commit 36ec0af

File tree

4 files changed

+13
-12
lines changed

4 files changed

+13
-12
lines changed

packages/pwa-kit-react-sdk/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
## v3.10.0-dev (Feb 18, 2025)
2+
- Fix the performance logging util to use the correct delimiter for the server-timing header. [#2225](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2295)
23

34
## v3.9.0 (Feb 18, 2025)
45
- Fix the performance logging util to not round duration. [#2199](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2199)

packages/pwa-kit-react-sdk/src/ssr/universal/components/with-legacy-get-props/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export const withLegacyGetProps = (Wrapped) => {
3434
// getTemplateName should be very fast, under 0.2ms
3535
c.getTemplateName().then((templateName) => {
3636
res.__performanceTimer.mark(
37-
`${PERFORMANCE_MARKS.getProps}::${templateName}`,
37+
`${PERFORMANCE_MARKS.getProps}.${templateName}`,
3838
'start'
3939
)
4040
})
@@ -49,7 +49,7 @@ export const withLegacyGetProps = (Wrapped) => {
4949
.then((result) => {
5050
c.getTemplateName().then((templateName) => {
5151
res.__performanceTimer.mark(
52-
`${PERFORMANCE_MARKS.getProps}::${templateName}`,
52+
`${PERFORMANCE_MARKS.getProps}.${templateName}`,
5353
'end'
5454
)
5555
})

packages/pwa-kit-react-sdk/src/ssr/universal/components/with-react-query/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,14 +79,14 @@ export const withReactQuery = (Wrapped, options = {}) => {
7979
// always include the index to avoid duplicate entries
8080
const displayName = q.meta?.displayName ? `${q.meta?.displayName}:${i}` : `${i}`
8181
res.__performanceTimer.mark(
82-
`${PERFORMANCE_MARKS.reactQueryUseQuery}::${displayName}`,
82+
`${PERFORMANCE_MARKS.reactQueryUseQuery}.${displayName}`,
8383
'start'
8484
)
8585
return q
8686
.fetch()
8787
.then((result) => {
8888
res.__performanceTimer.mark(
89-
`${PERFORMANCE_MARKS.reactQueryUseQuery}::${displayName}`,
89+
`${PERFORMANCE_MARKS.reactQueryUseQuery}.${displayName}`,
9090
'end',
9191
{
9292
detail: q.queryHash

packages/pwa-kit-react-sdk/src/utils/performance.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@
66
*/
77
import logger from './logger-instance'
88
export const PERFORMANCE_MARKS = {
9-
total: 'ssr:total',
10-
renderToString: 'ssr:render-to-string',
11-
routeMatching: 'ssr:route-matching',
12-
loadComponent: 'ssr:load-component',
13-
fetchStrategies: 'ssr:fetch-strategies',
14-
reactQueryPrerender: 'ssr:fetch-strategies:react-query:pre-render',
15-
reactQueryUseQuery: 'ssr:fetch-strategies:react-query:use-query',
16-
getProps: 'ssr:fetch-strategies:get-prop'
9+
total: 'ssr.total',
10+
renderToString: 'ssr.render-to-string',
11+
routeMatching: 'ssr.route-matching',
12+
loadComponent: 'ssr.load-component',
13+
fetchStrategies: 'ssr.fetch-strategies',
14+
reactQueryPrerender: 'ssr.fetch-strategies.react-query.pre-render',
15+
reactQueryUseQuery: 'ssr.fetch-strategies.react-query.use-query',
16+
getProps: 'ssr.fetch-strategies.get-prop'
1717
}
1818

1919
/**

0 commit comments

Comments
 (0)