Merge pull request #2219 from SalesforceCommerceCloud/bendvc/fix-ci-upload-artifact

Update Github `upload-artifact` action version @@W-17661561@@

Author: bendvc

.github/workflows/test.yml

@@ -232,9 +232,10 @@ jobs:
         uses: "./.github/actions/count_deps"
 
       - name: Store Verdaccio logfile artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          path: packages/pwa-kit-create-app/local-npm-repo/verdaccio.log
+          name: verdaccio-log-${{ matrix.template }}
+          path: packages/pwa-kit-create-app/local-npm-repo/verdaccio-${{ matrix.template }}.log
 
       # TODO: Ticket W-12425059. Revisit Snyk CLI integration to monitor manifest files on generated projects.
       # TODO: Update the SNYK_TOKEN stored in GitHub with a token generated from the proper Snyk org.
@@ -329,9 +330,10 @@ jobs:
         uses: "./.github/actions/count_deps"
 
       - name: Store Verdaccio logfile artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          path: packages/pwa-kit-create-app/local-npm-repo/verdaccio.log
+          name: verdaccio-log-${{ matrix.template }}
+          path: packages/pwa-kit-create-app/local-npm-repo/verdaccio-windows-${{ matrix.template }}.log
   lighthouse:
     needs: changelog-check
     strategy: