Recommended Products: fix toggling of the favorite icon (@W-16093853@) (#1861)

vmarta · web-flow · commit 6d9ca82160cb · 2024-06-25T10:55:20.000-07:00
* Recommended Products: fix toggling of the favorite icon

* Update CHANGELOG.md
diff --git a/packages/template-retail-react-app/CHANGELOG.md b/packages/template-retail-react-app/CHANGELOG.md
@@ -24,6 +24,7 @@
 
 -   Fix seo component not settings keywords meta tag [#1762](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1762)
 -   [a11y] Replace p tag with heading tags in cart page [#1818](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1818)
+-   Fix RecommendedProducts' toggling of the favourite icon [#1861](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1861)
 
 
 ## v2.4.1 (Apr 17, 2024)
diff --git a/packages/template-retail-react-app/app/components/recommended-products/index.jsx b/packages/template-retail-react-app/app/components/recommended-products/index.jsx
@@ -197,8 +197,8 @@ const RecommendedProducts = ({zone, recommender, products, title, shouldFetch, .
                 isFavourite: wishlist?.customerProductListItems?.some(
                     (item) => item.productId === product?.productId
                 ),
-                onFavouriteToggle: (isFavourite) => {
-                    const action = isFavourite ? removeItemFromWishlist : addItemToWishlist
+                onFavouriteToggle: (toBeFavourite) => {
+                    const action = toBeFavourite ? addItemToWishlist : removeItemFromWishlist
                     return action(product)
                 }
             })}
diff --git a/packages/template-retail-react-app/app/pages/product-list/index.jsx b/packages/template-retail-react-app/app/pages/product-list/index.jsx
@@ -582,8 +582,8 @@ const ProductList = (props) => {
                                                           )
                                                       }
                                                   }}
-                                                  onFavouriteToggle={(isFavourite) => {
-                                                      const action = isFavourite
+                                                  onFavouriteToggle={(toBeFavourite) => {
+                                                      const action = toBeFavourite
                                                           ? addItemToWishlist
                                                           : removeItemFromWishlist
                                                       return action(productSearchItem)

Original file line number	Diff line number	Diff line change
`@@ -582,8 +582,8 @@ const ProductList = (props) => {`
`582`	`582`	`)`
`583`	`583`	`}`
`584`	`584`	`}}`
`585`		`- onFavouriteToggle={(isFavourite) => {`
`586`		`- const action = isFavourite`
	`585`	`+ onFavouriteToggle={(toBeFavourite) => {`
	`586`	`+ const action = toBeFavourite`
`587`	`587`	`? addItemToWishlist`
`588`	`588`	`: removeItemFromWishlist`
`589`	`589`	`return action(productSearchItem)`