Skip to content

Commit 9699350

Browse files
committed
Add fix from Vincent M initial draft
1 parent 9c013a7 commit 9699350

File tree

1 file changed

+26
-21
lines changed

1 file changed

+26
-21
lines changed

packages/pwa-kit-create-app/scripts/create-mobify-app.js

Lines changed: 26 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1009,35 +1009,40 @@ const runGenerator = async (
10091009
npmInstall(outputDir, {verbose, projectName: context.answers.project.name})
10101010
}
10111011

1012-
const extensionsWithDefaultConfig = selectedAppExtensions.map((extension) => {
1013-
// Since we've just installed the dependencies, we can read the default config of each extension
1014-
const pathToDefaultConfig = p.join(
1015-
outputDir,
1016-
'node_modules',
1017-
extension,
1018-
'config',
1019-
'default.json'
1020-
)
1021-
if (!fs.existsSync(pathToDefaultConfig)) {
1022-
console.warn(
1023-
`The extension ${extension} does not have a default config. Will generate a minimal default config for it.`
1012+
if (selectedAppExtensions.length > 0) {
1013+
const extensionsWithDefaultConfig = selectedAppExtensions.map((extension) => {
1014+
// Since we've just installed the dependencies, we can read the default config of each extension
1015+
const pathToDefaultConfig = p.join(
1016+
outputDir,
1017+
'node_modules',
1018+
extension,
1019+
'config',
1020+
'default.json'
10241021
)
1025-
// Return a minimal default config. It should match what's defined in: https://github.com/SalesforceCommerceCloud/pwa-kit/blob/310e946bed12fd4cbb42a209ee6982e9b1bb9b99/packages/pwa-kit-extension-sdk/src/shared/utils/helpers.ts#L13-L15
1026-
return [extension, {enabled: true}]
1027-
}
1022+
if (!fs.existsSync(pathToDefaultConfig)) {
1023+
console.warn(
1024+
`The extension ${extension} does not have a default config. Will generate a minimal default config for it.`
1025+
)
1026+
// Return a minimal default config. It should match what's defined in: https://github.com/SalesforceCommerceCloud/pwa-kit/blob/310e946bed12fd4cbb42a209ee6982e9b1bb9b99/packages/pwa-kit-extension-sdk/src/shared/utils/helpers.ts#L13-L15
1027+
return [extension, {enabled: true}]
1028+
}
10281029

1029-
const defaultConfig = readJson(pathToDefaultConfig)
1030-
return [extension, defaultConfig]
1031-
})
1032-
updatePackageJson(p.resolve(outputDir, 'package.json'), {
1033-
...(selectedAppExtensions.length > 0 && {
1030+
const defaultConfig = readJson(pathToDefaultConfig)
1031+
return [extension, defaultConfig]
1032+
})
1033+
1034+
updatePackageJson(p.resolve(outputDir, 'package.json'), {
10341035
mobify: {
10351036
app: {
10361037
extensions: extensionsWithDefaultConfig
10371038
}
10381039
}
10391040
})
1040-
})
1041+
1042+
console.log(
1043+
'After your project is generated, please review `mobify.app.extensions` in package.json to check the configuration of the extensions and fill out any placeholder values.'
1044+
)
1045+
}
10411046
}
10421047

10431048
const foundNode = process.versions.node

0 commit comments

Comments
 (0)