PR Feedback

Author: adamraya

packages/pwa-kit-dev/src/configs/babel/babel-config.js

@@ -65,9 +65,9 @@ export default {
 
             // Return false if it's an allowed extension package @salesforce/pwa-kit-extension-sdk and extension-*
             if (
-                /node_modules[\\/][^/]+[\\/](pwa-kit-extension-sdk|@[^/]+\/extension-|extension-)/.test(
-                    normalizedPath
-                )
+                new RegExp(
+                    `node_modules\\${path.sep}[^\\${path.sep}]+\\${path.sep}(pwa-kit-extension-sdk|@[^\\${path.sep}]+\\${path.sep}extension-|extension-)`
+                ).test(normalizedPath)
             ) {
                 return false
             }

packages/pwa-kit-dev/src/configs/webpack/config.js

@@ -9,7 +9,7 @@
 
 // For more information on these settings, see https://webpack.js.org/configuration
 import {BundleAnalyzerPlugin} from 'webpack-bundle-analyzer'
-import {resolve} from 'path'
+import path, {resolve} from 'path'
 import fse from 'fs-extra'
 import webpack from 'webpack'
 
@@ -341,7 +341,10 @@ const ruleForBabelLoader = (babelPlugins) => {
         test: /(\.js(x?)|\.ts(x?))$/,
         // NOTE: Because our extensions are just folders containing source code, we need to ensure that the babel-loader processes them.
         // This regex exclude everything in node_modules, but node_modules/extensions-*/ folders
-        exclude: /node_modules[\\/](?!(@?[^\\/]+[\\/])?extension-)[^\\/]+[\\/].*$/i,
+        exclude: new RegExp(
+            `node_modules\\${path.sep}(?!(@?[^\\${path.sep}]+\\${path.sep})?extension-).*`,
+            'i'
+        ),
         use: [
             {
                 loader: findDepInStack('babel-loader'),

packages/pwa-kit-extension-sdk/src/configs/babel/utils.ts

@@ -49,21 +49,22 @@ export const buildBabelExtensibilityArgs = (config: any) => {
         const extensions = getConfiguredExtensions(config)
         const serverPath = fse.realpathSync(p.resolve(SERVER_PATH))
         const placeHolderPath = fse.realpathSync(p.resolve(PLACEHOLDER_PATH))
+        const appPath = p.join('app', '**')
 
         const extensionSrcPaths =
             extensions.length > 0
-                ? extensions.map(
-                      ([packageName]) =>
-                          fse.realpathSync(
-                              p.resolve(p.join(NODE_MODULES_PATH, packageName, 'src'))
-                          ) + '/**'
-                  )
+                ? extensions.map(([packageName]) => {
+                      const realPath = fse.realpathSync(
+                          p.resolve(p.join(NODE_MODULES_PATH, packageName, 'src'))
+                      )
+                      return p.join(realPath, '**')
+                  })
                 : []
 
         const extensionsPathsStr =
             extensionSrcPaths.length > 0 ? `,${extensionSrcPaths.join(',')}` : ''
 
-        const babelArgs = `--only "app/**,${serverPath},${placeHolderPath}${extensionsPathsStr}"`
+        const babelArgs = `--only ${appPath},${serverPath},${placeHolderPath}${extensionsPathsStr}`
 
         return babelArgs
     } catch (error) {