W-21356212: Lint fixes

Author: rvishwanathbhat

packages/template-retail-react-app/app/pages/checkout-one-click/partials/one-click-payment.jsx

@@ -16,7 +16,10 @@ import {
     Divider
 } from '@salesforce/retail-react-app/app/components/shared/ui'
 import {useToast} from '@salesforce/retail-react-app/app/hooks/use-toast'
-import {useShopperBasketsV2Mutation as useShopperBasketsMutation, useCustomerType} from '@salesforce/commerce-sdk-react'
+import {
+    useShopperBasketsV2Mutation as useShopperBasketsMutation,
+    useCustomerType
+} from '@salesforce/commerce-sdk-react'
 import {useCurrentBasket} from '@salesforce/retail-react-app/app/hooks/use-current-basket'
 import {useCurrentCustomer} from '@salesforce/retail-react-app/app/hooks/use-current-customer'
 import {useCheckoutAutoSelect} from '@salesforce/retail-react-app/app/hooks/use-checkout-auto-select'

packages/template-retail-react-app/app/pages/checkout-one-click/partials/one-click-payment.test.js

@@ -12,7 +12,10 @@ import {useCurrentBasket} from '@salesforce/retail-react-app/app/hooks/use-curre
 import {useCurrentCustomer} from '@salesforce/retail-react-app/app/hooks/use-current-customer'
 import {useToast} from '@salesforce/retail-react-app/app/hooks/use-toast'
 import {useCurrency} from '@salesforce/retail-react-app/app/hooks/use-currency'
-import {useShopperBasketsV2Mutation as useShopperBasketsMutation, useCustomerType} from '@salesforce/commerce-sdk-react'
+import {
+    useShopperBasketsV2Mutation as useShopperBasketsMutation,
+    useCustomerType
+} from '@salesforce/commerce-sdk-react'
 import {useCheckout} from '@salesforce/retail-react-app/app/pages/checkout-one-click/util/checkout-context'
 import Payment from '@salesforce/retail-react-app/app/pages/checkout-one-click/partials/one-click-payment'
 import {CurrencyProvider} from '@salesforce/retail-react-app/app/contexts'

packages/template-retail-react-app/app/pages/checkout-one-click/partials/one-click-pickup-address.jsx

@@ -18,7 +18,10 @@ import StoreDisplay from '@salesforce/retail-react-app/app/components/store-disp
 // Hooks
 import {useCheckout} from '@salesforce/retail-react-app/app/pages/checkout-one-click/util/checkout-context'
 import {useCurrentBasket} from '@salesforce/retail-react-app/app/hooks/use-current-basket'
-import {useShopperBasketsV2Mutation as useShopperBasketsMutation, useStores} from '@salesforce/commerce-sdk-react'
+import {
+    useShopperBasketsV2Mutation as useShopperBasketsMutation,
+    useStores
+} from '@salesforce/commerce-sdk-react'
 import {isPickupShipment} from '@salesforce/retail-react-app/app/utils/shipment-utils'
 
 const PickupAddress = () => {

packages/template-retail-react-app/app/pages/checkout/partials/sf-payments-sheet.jsx

@@ -297,8 +297,7 @@ const SFPaymentsSheet = forwardRef((props, ref) => {
 
             const orderStripeGatewayProperties =
                 orderPaymentInstrument?.paymentReference?.gatewayProperties?.stripe || {}
-            const setupFutureUsage =
-                orderStripeGatewayProperties?.setupFutureUsage 
+            const setupFutureUsage = orderStripeGatewayProperties?.setupFutureUsage
             if (setupFutureUsage) {
                 paymentIntent.setup_future_usage = setupFutureUsage
             }
@@ -535,9 +534,10 @@ const SFPaymentsSheet = forwardRef((props, ref) => {
     )
 
     useEffect(() => {
-        // Mount SFP only when all required data and DOM are ready.
+        // Mount SFP only when all required data and DOM are ready; otherwise skip or wait for a later run.
+
         if (isCustomerDataLoading) return // Wait for savedPaymentMethods data to load for registered users
-        if (checkoutComponent.current) return // Skip if already mounted (cleanup runs when deps change)
+        if (checkoutComponent.current) return // Skip if Componenet Already mounted
         if (!sfp) return // Skip if SFP SDK not loaded yet
         if (!metadata) return // Skip if SFP metadata not available yet
         if (!containerElementRef.current) return // Skip if Payment container ref not attached to DOM yet

packages/template-retail-react-app/app/utils/sf-payments-utils.test.js

@@ -1929,28 +1929,44 @@ describe('sf-payments-utils', () => {
         test('returns card for googlepay with Stripe gateway', () => {
             const paymentMethods = [{paymentMethodType: 'googlepay', accountId: 'acct_123'}]
             const paymentMethodSetAccounts = [{vendor: 'Stripe', accountId: 'acct_123'}]
-            const result = getExpressPaymentMethodType('googlepay', paymentMethods, paymentMethodSetAccounts)
+            const result = getExpressPaymentMethodType(
+                'googlepay',
+                paymentMethods,
+                paymentMethodSetAccounts
+            )
             expect(result).toBe('card')
         })
 
         test('returns googlepay for googlepay with Adyen gateway', () => {
             const paymentMethods = [{paymentMethodType: 'googlepay', accountId: 'adyen_acct'}]
             const paymentMethodSetAccounts = [{vendor: 'Adyen', accountId: 'adyen_acct'}]
-            const result = getExpressPaymentMethodType('googlepay', paymentMethods, paymentMethodSetAccounts)
+            const result = getExpressPaymentMethodType(
+                'googlepay',
+                paymentMethods,
+                paymentMethodSetAccounts
+            )
             expect(result).toBe('googlepay')
         })
 
         test('returns card for applepay with Stripe gateway', () => {
             const paymentMethods = [{paymentMethodType: 'applepay', accountId: 'acct_123'}]
             const paymentMethodSetAccounts = [{vendor: 'Stripe', accountId: 'acct_123'}]
-            const result = getExpressPaymentMethodType('applepay', paymentMethods, paymentMethodSetAccounts)
+            const result = getExpressPaymentMethodType(
+                'applepay',
+                paymentMethods,
+                paymentMethodSetAccounts
+            )
             expect(result).toBe('card')
         })
 
         test('returns type unchanged for non-mapped types', () => {
             const paymentMethods = [{paymentMethodType: 'paypal', accountId: 'acct_123'}]
             const paymentMethodSetAccounts = [{vendor: 'Stripe', accountId: 'acct_123'}]
-            const result = getExpressPaymentMethodType('paypal', paymentMethods, paymentMethodSetAccounts)
+            const result = getExpressPaymentMethodType(
+                'paypal',
+                paymentMethods,
+                paymentMethodSetAccounts
+            )
             expect(result).toBe('paypal')
         })
     })