Skip to content

Commit 9cb6095

Browse files
Revert "@W-19323372 Update OMS branch with develop (#3134)" (#3140)
This reverts commit 335f392.
1 parent 335f392 commit 9cb6095

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+608
-1929
lines changed

.github/actions/e2e_generate_app/action.yml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,24 +10,14 @@ inputs:
1010
required: false
1111
type: string
1212

13-
outputs:
14-
project_path:
15-
description: Path to the generated project directory
16-
value: ${{ steps.generate_project.outputs.project_path }}
17-
1813
runs:
1914
using: composite
2015
steps:
2116
- name: Generate new project based on project-key
22-
id: generate_project
2317
run: |
2418
COMMAND="node e2e/scripts/generate-project.js --project-key ${{ inputs.PROJECT_KEY }}"
2519
if [[ -n "${{ inputs.TEMPLATE_VERSION }}" ]]; then
2620
COMMAND="$COMMAND --templateVersion ${{ inputs.TEMPLATE_VERSION }}"
2721
fi
2822
$COMMAND
29-
30-
# Return path to the generated project
31-
GENERATED_PROJECTS_DIR=$(node -e "console.log(require('./e2e/config.js').GENERATED_PROJECTS_DIR)")
32-
echo "project_path=$GENERATED_PROJECTS_DIR/${{ inputs.PROJECT_KEY }}" >> $GITHUB_OUTPUT
3323
shell: bash

.github/actions/generate_app/action.yml

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,6 @@ inputs:
2222
project_dir:
2323
description: Project Directory
2424

25-
outputs:
26-
project_path:
27-
description: Path to the generated project directory
28-
value: ${{ steps.generate_project.outputs.project_path }}
29-
3025
runs:
3126
using: composite
3227
steps:
@@ -36,20 +31,20 @@ runs:
3631
run: |
3732
use_extensibility_input="${{ inputs.use_extensibility }}"
3833
if [ "use_extensibility_input" = "true" ]; then
39-
use_extensibility_value=1
40-
else
4134
use_extensibility_value=2
35+
else
36+
use_extensibility_value=1
4237
fi
43-
echo "USE_EXTENSIBILITY_VALUE=$use_extensibility_value" >> $GITHUB_ENV
44-
38+
echo "USE_EXTENSIBILITY_VALUE=$use_extensibility_value" >> $GITHUB_ENV
39+
4540
is_private_client_input="${{ inputs.is_private_client }}"
4641
if [ "$is_private_client_input" = "true" ]; then
4742
is_private_client_value=1
4843
else
4944
is_private_client_value=2
5045
fi
5146
echo "IS_PRIVATE_CLIENT_VALUE=$is_private_client_value" >> $GITHUB_ENV
52-
47+
5348
setup_hybrid_input="${{ inputs.setup_hybrid }}"
5449
if [ "$setup_hybrid_input" = "true" ]; then
5550
setup_hybrid_value=2
@@ -58,8 +53,6 @@ runs:
5853
fi
5954
echo "SETUP_HYBRID_VALUE=$setup_hybrid_value" >> $GITHUB_ENV
6055
61-
# TODO: update this to use the standard input feature that Ben created recently
62-
# TODO: this action does not finish successfully because of a dirty-workspace error, due to creating this generator-responses.json
6356
- name: Build project generator inputs
6457
id: build_generator_inputs
6558
shell: bash
@@ -114,16 +107,11 @@ runs:
114107
run: |
115108
cat generator-responses.json
116109
node e2e/scripts/generate-project.js --project-config "$(jq -c . generator-responses.json)"
117-
118-
# Return path to the generated project
119-
GENERATED_PROJECTS_DIR=$(node -e "console.log(require('./e2e/config.js').GENERATED_PROJECTS_DIR)")
120-
echo "project_path=$GENERATED_PROJECTS_DIR/${{ inputs.project_dir }}" >> $GITHUB_OUTPUT
121110
shell: bash
122111

123-
# TODO: I think we can safely delete this step. We already install the dependencies in the previous step.
124112
- name: Build generated project
125113
id: build_generated_project
126-
working-directory: ${{ steps.generate_project.outputs.project_path }}
114+
working-directory: ../generated-projects/${{ inputs.project_dir }}
127115
run: |-
128116
npm ci
129117
npm run build

.github/actions/push_to_mrt/action.yml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,26 +6,20 @@ inputs:
66
TARGET:
77
description: MRT target environment
88
FLAGS:
9-
description: The rest of the flags for the push command
9+
description: Push flags
1010
PROJECT:
1111
description: MRT target project
1212
default: "scaffold-pwa"
1313
MESSAGE:
1414
description: Bundle message / name
1515
default: "build ${{ github.run_id }} on ${{ github.ref }} (${{ github.sha }})"
16-
CLOUD_ORIGIN:
17-
description: 'MRT Cloud origin'
18-
default: 'https://cloud.mobify.com'
19-
CREDENTIALS_FILE_PATH:
20-
description: 'Path to the credentials file'
21-
default: '~/.mobify'
2216
runs:
2317
using: composite
2418
steps:
2519
- name: Push Bundle to MRT
2620
run: |-
2721
cd ${{ inputs.CWD }}
2822
if [[ ${{ inputs.TARGET }} ]]; then
29-
npm run push -- --projectSlug ${{ inputs.PROJECT }} --message "${{ inputs.MESSAGE }}" --target ${{ inputs.TARGET }} --cloud-origin ${{ inputs.CLOUD_ORIGIN }} --credentialsFile ${{ inputs.CREDENTIALS_FILE_PATH }} ${{ inputs.FLAGS }}
23+
npm run push -- -s ${{ inputs.PROJECT }} --message "${{ inputs.MESSAGE }}" --target ${{ inputs.TARGET }} ${{ inputs.FLAGS }}
3024
fi
3125
shell: bash

.github/workflows/agent_checkout_rebase_action.yml

Lines changed: 0 additions & 97 deletions
This file was deleted.

.github/workflows/bundle-size.yml

Lines changed: 0 additions & 35 deletions
This file was deleted.

.github/workflows/deploy_latest_release.yml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,15 @@ jobs:
1313
runs-on: ubuntu-latest
1414
outputs:
1515
IS_LATEST_RELEASE: ${{ steps.checkRelease.outputs.IS_LATEST_RELEASE }}
16-
steps:
16+
steps:
1717
- name: Checkout
1818
uses: actions/checkout@v4
1919

2020
- name: Check if latest release
2121
uses: ./.github/actions/check_if_latest_release
2222
with:
2323
token: ${{ secrets.GITHUB_TOKEN }}
24-
24+
2525
- name: Update Github Outputs
2626
id: checkRelease
2727
run: |-
@@ -45,15 +45,13 @@ jobs:
4545
project: pwa-kit
4646
mobify_user: MOBIFY_STG_CLIENT_USER
4747
mobify_api_key: MOBIFY_STG_CLIENT_API_KEY
48-
cloud_origin: https://cloud-testing.mobify-staging.com
49-
flags: --wait
48+
flags: --cloud-origin https://cloud-testing.mobify-staging.com -c ~/.mobify --wait
5049
- name: demo-site
5150
project_key: retail-react-app-demo-site
5251
target: production
5352
project: scaffold-pwa
5453
mobify_user: MOBIFY_CLIENT_USER
5554
mobify_api_key: MOBIFY_CLIENT_API_KEY
56-
cloud_origin: https://cloud.mobify.com
5755
flags: --wait
5856
steps:
5957
- name: Checkout
@@ -72,7 +70,6 @@ jobs:
7270
node ./scripts/gtime.js monorepo_install npm ci
7371
7472
- name: Generate Retail App Demo
75-
id: generate_app
7673
uses: ./.github/actions/e2e_generate_app
7774
with:
7875
PROJECT_KEY: ${{ matrix.environment.project_key }}
@@ -97,9 +94,8 @@ jobs:
9794
- name: Push Bundle to MRT (${{matrix.environment.name}})
9895
uses: "./.github/actions/push_to_mrt"
9996
with:
100-
CWD: ${{ steps.generate_app.outputs.project_path }}
97+
CWD: "../generated-projects/${{ matrix.environment.project_key }}"
10198
TARGET: ${{ matrix.environment.target }}
10299
PROJECT: ${{ matrix.environment.project }}
103100
MESSAGE: ${{ env.BUNDLE_NAME }})
104-
CLOUD_ORIGIN: ${{ matrix.environment.cloud_origin }}
105101
FLAGS: ${{ matrix.environment.flags }}

.github/workflows/e2e-pr.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ jobs:
6464
echo "retail_app_template_version=$version" >> "$GITHUB_ENV"
6565
6666
- name: Generate Retail App Private Client
67-
id: generate_app
6867
if: ${{ env.SKIP_WORKFLOW != 'true' }}
6968
uses: ./.github/actions/e2e_generate_app
7069
with:
@@ -90,7 +89,7 @@ jobs:
9089
if: ${{ env.SKIP_WORKFLOW != 'true' }}
9190
uses: './.github/actions/push_to_mrt'
9291
with:
93-
CWD: ${{ steps.generate_app.outputs.project_path }}
92+
CWD: '../generated-projects/retail-app-no-ext'
9493
# TODO: Use the MRT target ID from the target lock step above.
9594
TARGET: e2e-tests-pwa-kit
9695
FLAGS: --wait

.github/workflows/e2e.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ jobs:
114114
echo "retail_app_template_version=$version" >> "$GITHUB_ENV"
115115
116116
- name: Generate Retail App Without Extensibility
117-
id: generate_app_no_ext
118117
uses: ./.github/actions/e2e_generate_app
119118
with:
120119
PROJECT_KEY: "retail-app-no-ext"
@@ -135,7 +134,7 @@ jobs:
135134
- name: Push Bundle to MRT (E2E Test PWA Kit)
136135
uses: "./.github/actions/push_to_mrt"
137136
with:
138-
CWD: ${{ steps.generate_app_no_ext.outputs.project_path }}
137+
CWD: "../generated-projects/retail-app-no-ext"
139138
TARGET: e2e-tests-pwa-kit
140139
FLAGS: --wait
141140

@@ -232,7 +231,6 @@ jobs:
232231
echo "retail_app_template_version=$version" >> "$GITHUB_ENV"
233232
234233
- name: Generate Retail App With Extensibility
235-
id: generate_app_ext
236234
uses: ./.github/actions/e2e_generate_app
237235
with:
238236
PROJECT_KEY: "retail-app-ext"
@@ -253,7 +251,7 @@ jobs:
253251
- name: Push Bundle to MRT (E2E Test PWA Kit)
254252
uses: "./.github/actions/push_to_mrt"
255253
with:
256-
CWD: ${{ steps.generate_app_ext.outputs.project_path }}
254+
CWD: "../generated-projects/retail-app-ext"
257255
TARGET: e2e-tests-pwa-kit
258256
FLAGS: --wait
259257

@@ -348,7 +346,6 @@ jobs:
348346
echo "retail_app_template_version=$version" >> "$GITHUB_ENV"
349347
350348
- name: Generate Retail App Private Client
351-
id: generate_app_private_client
352349
uses: ./.github/actions/e2e_generate_app
353350
with:
354351
PROJECT_KEY: "retail-app-private-client"
@@ -369,7 +366,7 @@ jobs:
369366
- name: Push Bundle to MRT
370367
uses: "./.github/actions/push_to_mrt"
371368
with:
372-
CWD: ${{ steps.generate_app_private_client.outputs.project_path }}
369+
CWD: "../generated-projects/retail-app-private-client"
373370
TARGET: e2e-pwa-kit-private
374371
FLAGS: --wait
375372

0 commit comments

Comments
 (0)