Skip to content

Commit 9ee3f5d

Browse files
authored
[Node 24][V3] Migrate Deprecated Node URL APIs to WHATWG Standard (@W-20777230@) (#3652)
* Migrate to WHATWG URL constructor * lint * clean up * Update CHANGELOG.md * Update changelogs * Update changelog and lock files * Update package-lock.json * Clear verdaccio npm cache * Update changelogs
1 parent 6d80118 commit 9ee3f5d

File tree

44 files changed

+448
-357
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+448
-357
lines changed

.github/workflows/test.yml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ jobs:
5252
strategy:
5353
fail-fast: false
5454
matrix:
55-
node: [18, 20, 22]
56-
npm: [8, 9, 10, 11]
55+
node: [18, 20, 22, 24]
56+
npm: [9, 10, 11]
5757
exclude: # node 18 with npm 11 are not compatible
5858
- node: 18
5959
npm: 11
@@ -62,7 +62,7 @@ jobs:
6262
# The "default" npm is the one that ships with a given version of node.
6363
# For more: https://nodejs.org/en/download/releases/
6464
# (We also use this env var for making sure a step runs once for the current node version)
65-
IS_DEFAULT_NPM: ${{ (matrix.node == 18 && matrix.npm == 10) || (matrix.node == 20 && matrix.npm == 10) || (matrix.node == 22 && matrix.npm == 10) }}
65+
IS_DEFAULT_NPM: ${{ (matrix.node == 18 && matrix.npm == 10) || (matrix.node == 20 && matrix.npm == 10) || (matrix.node == 22 && matrix.npm == 10) || (matrix.node == 24 && matrix.npm == 11) }}
6666
# The current recommended version for Managed Runtime:
6767
# https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/upgrade-node-version.html
6868
IS_MRT_NODE: ${{ matrix.node == 22 && matrix.npm == 10 }}
@@ -157,8 +157,8 @@ jobs:
157157
strategy:
158158
fail-fast: false
159159
matrix:
160-
node: [18, 20, 22]
161-
npm: [8, 9, 10, 11]
160+
node: [18, 20, 22, 24]
161+
npm: [9, 10, 11]
162162
exclude: # node 18 with npm 11 is not compatible
163163
- node: 18
164164
npm: 11
@@ -167,8 +167,7 @@ jobs:
167167
# The "default" npm is the one that ships with a given version of node.
168168
# For more: https://nodejs.org/en/download/releases/
169169
# (We also use this env var for making sure a step runs once for the current node version)
170-
# Note: For node 18, the default was npm 9 until v18.19.0, when it became npm 10
171-
IS_DEFAULT_NPM: ${{ (matrix.node == 18 && matrix.npm == 10) || (matrix.node == 20 && matrix.npm == 10) || (matrix.node == 22 && matrix.npm == 10) }}
170+
IS_DEFAULT_NPM: ${{ (matrix.node == 18 && matrix.npm == 10) || (matrix.node == 20 && matrix.npm == 10) || (matrix.node == 22 && matrix.npm == 10) || (matrix.node == 24 && matrix.npm == 11) }}
172171
# The current recommended version for Managed Runtime:
173172
# https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/upgrade-node-version.html
174173
IS_MRT_NODE: ${{ matrix.node == 22 && matrix.npm == 10 }}

e2e/package-lock.json

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@
4949
"syncpack": "^10.1.0"
5050
},
5151
"engines": {
52-
"node": "^16.11.0 || ^18.0.0 || ^20.0.0 || ^22.0.0",
53-
"npm": "^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0"
52+
"node": "^18.0.0 || ^20.0.0 || ^22.0.0 || ^24.0.0",
53+
"npm": "^9.0.0 || ^10.0.0 || ^11.0.0"
5454
},
5555
"dependencies": {
5656
"@aws-sdk/client-cloudwatch": "^3.962.0",

packages/commerce-sdk-react/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
## v5.0.0-dev (Jan 28, 2026)
2+
- Add Node 24 support. Drop Node 16 support. [#3652](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3652)
23
- Upgrade to commerce-sdk-isomorphic v5.0.0 and introduce Payment Instrument SCAPI integration [#3552](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3552)
34

45
## v4.4.0-dev (Dec 17, 2025)

packages/commerce-sdk-react/package-lock.json

Lines changed: 5 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/commerce-sdk-react/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@
8484
"react-router-dom": "^5.3.4"
8585
},
8686
"engines": {
87-
"node": "^16.11.0 || ^18.0.0 || ^20.0.0 || ^22.0.0",
88-
"npm": "^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0"
87+
"node": "^18.0.0 || ^20.0.0 || ^22.0.0 || ^24.0.0",
88+
"npm": "^9.0.0 || ^10.0.0 || ^11.0.0"
8989
},
9090
"publishConfig": {
9191
"directory": "dist"

0 commit comments

Comments
 (0)