Skip to content

Commit b926294

Browse files
committed
Merge branch 'fixing-e2e-dnt-2' of github.com:SalesforceCommerceCloud/pwa-kit into fixing-e2e-dnt-2
2 parents 08cd2a0 + 32000fd commit b926294

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

.github/workflows/e2e.yml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,9 @@ jobs:
1111
fail-fast: false
1212
matrix:
1313
# Run all matrix env at once because we will not deploy demo app to MRT.
14-
node: [16, 18, 20, 22]
14+
node: [18, 20, 22]
1515
npm: [8, 9, 10, 11]
16-
exclude: # node 16 with npm 10/11 and node 18 with npm 11 are not compatible
17-
- node: 16
18-
npm: 10
19-
- node: 16
20-
npm: 11
16+
exclude: # node 18 with npm 11 is not compatible
2117
- node: 18
2218
npm: 11
2319
runs-on: ubuntu-latest
@@ -26,7 +22,7 @@ jobs:
2622
# For more: https://nodejs.org/en/download/releases/
2723
# (We also use this env var for making sure a step runs once for the current node version)
2824
# Note: For node 18, the default was npm 9 until v18.19.0, when it became npm 10
29-
IS_DEFAULT_NPM: ${{ (matrix.node == 16 && matrix.npm == 8) || (matrix.node == 18 && matrix.npm == 10) || (matrix.node == 20 && matrix.npm == 10) || (matrix.node == 22 && matrix.npm == 10) }}
25+
IS_DEFAULT_NPM: ${{ (matrix.node == 18 && matrix.npm == 10) || (matrix.node == 20 && matrix.npm == 10) || (matrix.node == 22 && matrix.npm == 10) }}
3026
steps:
3127
- name: Checkout
3228
uses: actions/checkout@v4

0 commit comments

Comments
 (0)