Skip to content

Commit c064f29

Browse files
sf-cboscencosf-cboscenco
authored
Merge pull request #3398 from SalesforceCommerceCloud/t/cc-sharks/W-19721000
Fix footer heading semantic consistency and alignment
2 parents 4d314a5 + c287be4 commit c064f29

File tree

37 files changed

+596
-149
lines changed

37 files changed

+596
-149
lines changed

‎e2e/tests/a11y/desktop/slas-private-client/__snapshots__/guest/checkout-a11y-violations-step-0.json‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,6 @@
1515
}
1616
]
1717
},
18-
{
19-
"id": "page-has-heading-one",
20-
"impact": "moderate",
21-
"description": "Ensure that the page, or at least one of its frames contains a level-one heading",
22-
"help": "Page should contain a level-one heading",
23-
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/page-has-heading-one?application=playwright",
24-
"nodes": [
25-
{
26-
"html": "<html lang=\"en-US\" class=\"...\" >",
27-
"failureSummary": "Fix all of the following:\n Page must have a level-one heading",
28-
"target": [
29-
"html"
30-
]
31-
}
32-
]
33-
},
3418
{
3519
"id": "region",
3620
"impact": "moderate",

‎e2e/tests/a11y/desktop/slas-private-client/__snapshots__/guest/checkout-a11y-violations-step-1.json‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,6 @@
1515
}
1616
]
1717
},
18-
{
19-
"id": "page-has-heading-one",
20-
"impact": "moderate",
21-
"description": "Ensure that the page, or at least one of its frames contains a level-one heading",
22-
"help": "Page should contain a level-one heading",
23-
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/page-has-heading-one?application=playwright",
24-
"nodes": [
25-
{
26-
"html": "<html lang=\"en-US\" class=\"...\" >",
27-
"failureSummary": "Fix all of the following:\n Page must have a level-one heading",
28-
"target": [
29-
"html"
30-
]
31-
}
32-
]
33-
},
3418
{
3519
"id": "region",
3620
"impact": "moderate",

‎e2e/tests/a11y/desktop/slas-private-client/__snapshots__/guest/checkout-a11y-violations-step-3.json‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,6 @@
1515
}
1616
]
1717
},
18-
{
19-
"id": "page-has-heading-one",
20-
"impact": "moderate",
21-
"description": "Ensure that the page, or at least one of its frames contains a level-one heading",
22-
"help": "Page should contain a level-one heading",
23-
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/page-has-heading-one?application=playwright",
24-
"nodes": [
25-
{
26-
"html": "<html lang=\"en-US\" class=\"...\" >",
27-
"failureSummary": "Fix all of the following:\n Page must have a level-one heading",
28-
"target": [
29-
"html"
30-
]
31-
}
32-
]
33-
},
3418
{
3519
"id": "region",
3620
"impact": "moderate",

‎e2e/tests/a11y/desktop/slas-private-client/__snapshots__/guest/checkout-a11y-violations-step-4-order-confirmation.json‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,6 @@
1515
}
1616
]
1717
},
18-
{
19-
"id": "page-has-heading-one",
20-
"impact": "moderate",
21-
"description": "Ensure that the page, or at least one of its frames contains a level-one heading",
22-
"help": "Page should contain a level-one heading",
23-
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/page-has-heading-one?application=playwright",
24-
"nodes": [
25-
{
26-
"html": "<html lang=\"en-US\" class=\"...\" >",
27-
"failureSummary": "Fix all of the following:\n Page must have a level-one heading",
28-
"target": [
29-
"html"
30-
]
31-
}
32-
]
33-
},
3418
{
3519
"id": "region",
3620
"impact": "moderate",

‎e2e/tests/a11y/desktop/slas-private-client/__snapshots__/registered/checkout-a11y-violations-step-0.json‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,6 @@
1515
}
1616
]
1717
},
18-
{
19-
"id": "page-has-heading-one",
20-
"impact": "moderate",
21-
"description": "Ensure that the page, or at least one of its frames contains a level-one heading",
22-
"help": "Page should contain a level-one heading",
23-
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/page-has-heading-one?application=playwright",
24-
"nodes": [
25-
{
26-
"html": "<html lang=\"en-US\" class=\"...\" >",
27-
"failureSummary": "Fix all of the following:\n Page must have a level-one heading",
28-
"target": [
29-
"html"
30-
]
31-
}
32-
]
33-
},
3418
{
3519
"id": "region",
3620
"impact": "moderate",

‎e2e/tests/a11y/desktop/slas-private-client/__snapshots__/registered/checkout-a11y-violations-step-1.json‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,6 @@
1515
}
1616
]
1717
},
18-
{
19-
"id": "page-has-heading-one",
20-
"impact": "moderate",
21-
"description": "Ensure that the page, or at least one of its frames contains a level-one heading",
22-
"help": "Page should contain a level-one heading",
23-
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/page-has-heading-one?application=playwright",
24-
"nodes": [
25-
{
26-
"html": "<html lang=\"en-US\" class=\"...\" >",
27-
"failureSummary": "Fix all of the following:\n Page must have a level-one heading",
28-
"target": [
29-
"html"
30-
]
31-
}
32-
]
33-
},
3418
{
3519
"id": "region",
3620
"impact": "moderate",

‎e2e/tests/a11y/desktop/slas-private-client/__snapshots__/registered/checkout-a11y-violations-step-2.json‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,6 @@
1515
}
1616
]
1717
},
18-
{
19-
"id": "page-has-heading-one",
20-
"impact": "moderate",
21-
"description": "Ensure that the page, or at least one of its frames contains a level-one heading",
22-
"help": "Page should contain a level-one heading",
23-
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/page-has-heading-one?application=playwright",
24-
"nodes": [
25-
{
26-
"html": "<html lang=\"en-US\" class=\"...\" >",
27-
"failureSummary": "Fix all of the following:\n Page must have a level-one heading",
28-
"target": [
29-
"html"
30-
]
31-
}
32-
]
33-
},
3418
{
3519
"id": "region",
3620
"impact": "moderate",

‎e2e/tests/a11y/desktop/slas-private-client/__snapshots__/registered/checkout-a11y-violations-step-3.json‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,6 @@
1515
}
1616
]
1717
},
18-
{
19-
"id": "page-has-heading-one",
20-
"impact": "moderate",
21-
"description": "Ensure that the page, or at least one of its frames contains a level-one heading",
22-
"help": "Page should contain a level-one heading",
23-
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/page-has-heading-one?application=playwright",
24-
"nodes": [
25-
{
26-
"html": "<html lang=\"en-US\" class=\"...\" >",
27-
"failureSummary": "Fix all of the following:\n Page must have a level-one heading",
28-
"target": [
29-
"html"
30-
]
31-
}
32-
]
33-
},
3418
{
3519
"id": "region",
3620
"impact": "moderate",

‎e2e/tests/mobile/dnt.spec.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ test('Shopper can use the consent tracking form', async ({page}) => {
7373
await checkDntCookie(page, '1')
7474

7575
// Logging out clears the preference
76-
await page.getByRole('heading', {name: /My Account/i}).click()
76+
await page.getByRole('button', {name: /My Account chevron-down/i}).click()
7777
const buttons = await page.getByText(/Log Out/i).elementHandles()
7878
for (const button of buttons) {
7979
if (await button.isVisible()) {

‎packages/template-retail-react-app/CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
## v8.2.0-dev (Sep 26, 2025)
2+
- [Bugfix] Fix footer heading semantic consistency and alignment. Fix accessibility compliance by adding proper h1 headings to checkout pages to resolve the page-has-heading-one accessibility rule violation. [#3398](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3398)
23
- [Bugfix] Use `serverSafeEncode` util for address mutations. [#3380](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3380)
34
## v8.1.0 (Sep 25, 2025)
45
- Updated search UX - prices, images, suggestions new layout [#3271](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3271)

0 commit comments

Comments
 (0)