Merge pull request #3582 from SalesforceCommerceCloud/feature/update-publish-to-npm-auth

shethj · web-flow · commit e193a2c6f515 · 2026-01-16T16:34:16.000-08:00
Add NPM Token expiry alert to nightly workflow
diff --git a/.github/actions/bundle_size_test/action.yml b/.github/actions/bundle_size_test/action.yml
@@ -1,4 +1,5 @@
 name: bundlesize
+description: Check bundle size against maximum file size limits
 runs:
   using: composite
   steps:
diff --git a/.github/actions/check_clean/action.yml b/.github/actions/check_clean/action.yml
@@ -1,4 +1,5 @@
 name: check_clean
+description: Check if repository has uncommitted changes
 runs:
   using: composite
   steps:
diff --git a/.github/actions/check_if_latest_release/action.yml b/.github/actions/check_if_latest_release/action.yml
@@ -1,4 +1,5 @@
 name: check_if_latest_release
+description: Check if the current release is the latest release
 inputs:
   token:
     description: "Github API token"
diff --git a/.github/actions/count_deps/action.yml b/.github/actions/count_deps/action.yml
@@ -1,4 +1,5 @@
 name: count_deps
+description: Count and validate project dependencies
 inputs:
   project_dir:
     description: 'Path to the project directory'
diff --git a/.github/actions/create_mrt/action.yml b/.github/actions/create_mrt/action.yml
@@ -1,4 +1,5 @@
 name: create_mrt
+description: Create MRT credentials file
 inputs:
   mobify_user:
     description: "Mobify user email"
diff --git a/.github/actions/datadog/action.yml b/.github/actions/datadog/action.yml
@@ -1,4 +1,5 @@
 name: datadog
+description: Send metrics to Datadog
 inputs:
   datadog_api_key:
     description: "Datadog API key"
diff --git a/.github/actions/e2e_generate_app/action.yml b/.github/actions/e2e_generate_app/action.yml
@@ -1,4 +1,5 @@
 name: e2e_generate_app
+description: Generate a new project for E2E testing
 inputs:
   PROJECT_KEY:
     description: Project key to specify project to generate ("retail-app-demo", "retail-app-ext" or "retail-app-no-ext")
diff --git a/.github/actions/e2e_validate_generated_app/action.yml b/.github/actions/e2e_validate_generated_app/action.yml
@@ -1,4 +1,5 @@
 name: e2e_validate_generated_app
+description: Validate generated project for E2E testing
 inputs:
   PROJECT_KEY:
     description: Project key to specify project to validate ("retail-app-demo", "retail-app-ext" or "retail-app-no-ext")
diff --git a/.github/actions/lighthouse_ci/action.yml b/.github/actions/lighthouse_ci/action.yml
@@ -1,4 +1,5 @@
 name: lighthouse_ci
+description: Run Lighthouse CI performance tests
 runs:
   using: composite
   steps:
diff --git a/.github/actions/linting/action.yml b/.github/actions/linting/action.yml
@@ -1,4 +1,5 @@
 name: linting
+description: Run linting checks on the codebase
 inputs:
   cwd:
     required: false
diff --git a/.github/actions/publish_to_npm/action.yml b/.github/actions/publish_to_npm/action.yml
@@ -1,4 +1,5 @@
 name: publish_to_npm
+description: Publish packages to NPM registry
 inputs:
   NODE_AUTH_TOKEN:
     description: "Node auth token"
diff --git a/.github/actions/push_to_mrt/action.yml b/.github/actions/push_to_mrt/action.yml
@@ -1,4 +1,5 @@
 name: push_to_mrt
+description: Push bundle to MRT (Managed Runtime)
 inputs:
     CWD:
         description: Project directory
diff --git a/.github/actions/smoke_tests/action.yml b/.github/actions/smoke_tests/action.yml
@@ -1,4 +1,5 @@
 name: smoke_tests
+description: Run smoke tests on npm scripts
 inputs:
   dir:
     required: false
diff --git a/.github/actions/snyk/action.yml b/.github/actions/snyk/action.yml
@@ -1,4 +1,5 @@
 name: snyk
+description: Run Snyk security audit on the project
 inputs:
   snyk_token:
     description: "Snyk token"
diff --git a/.github/workflows/nightly_release.yml b/.github/workflows/nightly_release.yml
@@ -26,7 +26,6 @@ jobs:
           echo "monorepo_version_base=$version" >> "$GITHUB_ENV"
           version_major=`echo "$version" | cut -d "." -f 1`
           echo "monorepo_version_major=$version_major" >> "$GITHUB_ENV"
-          echo "nightly_version=${{ env.monorepo_version_base }}-nightly-${{ env.release_timestamp }}" ?? "$GITHUB_ENV"
 
       - name: Get nightly version
         run:  echo "nightly_version=${{ env.monorepo_version_base }}-nightly-${{ env.release_timestamp }}" >> "$GITHUB_ENV"
@@ -116,7 +115,7 @@ jobs:
         with:
           payload: |
             {
-              "message": "Successfully released PWA Kit v${{ env.nightly_version }}"
+              "message": "✅ Successfully released PWA Kit v${{ env.nightly_version }}"
             }
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
@@ -128,7 +127,37 @@ jobs:
         with:
           payload: |
             {
-              "message": "Failed to release PWA Kit v${{ env.monorepo_version_base }}-nightly-${{ env.release_timestamp }} (${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})"
+              "message": "❌ Failed to release PWA Kit v${{ env.monorepo_version_base }}-nightly-${{ env.release_timestamp }} (${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})"
+            }
+        env:
+          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
+
+      - name: Check NPM Token Expiry
+        if: always()
+        run: |
+          LAST_ROTATION="${{ secrets.NPM_TOKEN_LAST_ROTATION_DATE }}"
+          
+          if [ -z "$LAST_ROTATION" ]; then
+            echo "NPM_TOKEN_LAST_ROTATION_DATE secret not set, skipping expiry check"
+            exit 0
+          fi
+          
+          CURRENT_DATE=$(date +%s)
+          EXPIRY_DATE=$(( $LAST_ROTATION + 7776000 ))  # 90 days in seconds (90 * 24 * 60 * 60)
+          DAYS_LEFT=$(( ($EXPIRY_DATE - $CURRENT_DATE) / 86400 ))
+          
+          echo "NPM Token last rotated: $(date -d @$LAST_ROTATION +'%Y-%m-%d')"
+          echo "Days until expiry: $DAYS_LEFT"
+          echo "days_left=$DAYS_LEFT" >> "$GITHUB_ENV"
+          echo "should_notify=$( [ $DAYS_LEFT -le 10 ] && echo 'true' || echo 'false' )" >> "$GITHUB_ENV"
+
+      - name: Send Token Expiry Warning to Slack
+        if: always() && env.should_notify == 'true'
+        uses: slackapi/slack-github-action@v1.23.0
+        with:
+          payload: |
+            {
+              "message": "⚠️ NPM Token expiring soon! Only ${{ env.days_left }} days remaining. Please rotate the token using the instructions in this doc: ${{ secrets.PWA_KIT_RELEASE_DOC_LINK }}"
             }
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`name: bundlesize`
	`2`	`+description: Check bundle size against maximum file size limits`
`2`	`3`	`runs:`
`3`	`4`	`using: composite`
`4`	`5`	`steps:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`name: check_clean`
	`2`	`+description: Check if repository has uncommitted changes`
`2`	`3`	`runs:`
`3`	`4`	`using: composite`
`4`	`5`	`steps:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`name: check_if_latest_release`
	`2`	`+description: Check if the current release is the latest release`
`2`	`3`	`inputs:`
`3`	`4`	`token:`
`4`	`5`	`description: "Github API token"`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`name: count_deps`
	`2`	`+description: Count and validate project dependencies`
`2`	`3`	`inputs:`
`3`	`4`	`project_dir:`
`4`	`5`	`description: 'Path to the project directory'`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`name: create_mrt`
	`2`	`+description: Create MRT credentials file`
`2`	`3`	`inputs:`
`3`	`4`	`mobify_user:`
`4`	`5`	`description: "Mobify user email"`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`name: datadog`
	`2`	`+description: Send metrics to Datadog`
`2`	`3`	`inputs:`
`3`	`4`	`datadog_api_key:`
`4`	`5`	`description: "Datadog API key"`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`name: e2e_generate_app`
	`2`	`+description: Generate a new project for E2E testing`
`2`	`3`	`inputs:`
`3`	`4`	`PROJECT_KEY:`
`4`	`5`	`description: Project key to specify project to generate ("retail-app-demo", "retail-app-ext" or "retail-app-no-ext")`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`name: e2e_validate_generated_app`
	`2`	`+description: Validate generated project for E2E testing`
`2`	`3`	`inputs:`
`3`	`4`	`PROJECT_KEY:`
`4`	`5`	`description: Project key to specify project to validate ("retail-app-demo", "retail-app-ext" or "retail-app-no-ext")`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`name: lighthouse_ci`
	`2`	`+description: Run Lighthouse CI performance tests`
`2`	`3`	`runs:`
`3`	`4`	`using: composite`
`4`	`5`	`steps:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`name: linting`
	`2`	`+description: Run linting checks on the codebase`
`2`	`3`	`inputs:`
`3`	`4`	`cwd:`
`4`	`5`	`required: false`