Skip to content

Commit e58c287

Browse files
committed
Update todos
1 parent b80a192 commit e58c287

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

.github/workflows/performance-metrics.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,22 +22,21 @@ jobs:
2222

2323
- name: Install Monorepo Dependencies
2424
run: |-
25-
# Install node dependencies
26-
node ./scripts/gtime.js monorepo_install npm ci
25+
npm ci
2726
2827
- name: Get Template Version
2928
run: |-
3029
version=`jq -r ".version" packages/template-retail-react-app/package.json`
3130
echo "retail_app_template_version=$version" >> "$GITHUB_ENV"
3231
33-
# TODO: This is set to generate an app with extensibility using a SLAS private client which I don't know is what they'll be running tests on.
34-
# TODO: Change this to generate an app with the performance metrics template.
32+
# TODO: use the other generate_app action that has more flexibility
3533
- name: Generate Retail App Private Client
3634
uses: ./.github/actions/e2e_generate_app
3735
with:
3836
PROJECT_KEY: 'retail-app-private-client'
3937
TEMPLATE_VERSION: ${{ env.retail_app_template_version }}
4038

39+
# TODO: is this step still needed? I think it expects a project key
4140
- name: Validate Generated Retail App Private Client
4241
uses: ./.github/actions/e2e_validate_generated_app
4342
with:
@@ -58,8 +57,8 @@ jobs:
5857
FLAGS: --wait
5958

6059
# TODO: Remove this if not needed or change this to whatever storefront is used for performance metrics.
61-
- name: Set Retail App Private Client Home
62-
run: export RETAIL_APP_HOME=https://scaffold-pwa-e2e-pwa-kit-private.mobify-storefront.com/
60+
# - name: Set Retail App Private Client Home
61+
# run: export RETAIL_APP_HOME=https://scaffold-pwa-e2e-pwa-kit-private.mobify-storefront.com/
6362

6463
# TODO: This step is not needed. We don't need to worry about calling it from the workflow. What we need to worry about is the build and deploy to MRT.
6564
# - name: Run Performance Metrics

0 commit comments

Comments
 (0)