Skip to content

Commit e6ac124

Browse files
authored
[v3] Fix StorefrontPreview component add siteId query parameter to shopper context calls (@W-16225140@) (#1891)
* Add siteId from useConfig * Bump versions
1 parent eb6bc59 commit e6ac124

File tree

10 files changed

+27
-11
lines changed

10 files changed

+27
-11
lines changed

packages/commerce-sdk-react/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
## v2.0.2 (Jul 12, 2024)
2+
- Updated StorefrontPreview component to make siteId available [#1874](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1874)
3+
14
## v2.0.1 (Jul 08, 2024)
25
- Fix private slas proxy config for commerce api in provider [#1883](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1883)
36
- Fix `useCustomQuery` error handling [#1883](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1883)

packages/commerce-sdk-react/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/commerce-sdk-react/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@salesforce/commerce-sdk-react",
3-
"version": "2.0.1",
3+
"version": "2.0.2",
44
"description": "A library that provides react hooks for fetching data from Commerce Cloud",
55
"homepage": "https://github.com/SalesforceCommerceCloud/pwa-kit/tree/develop/packages/ecom-react-hooks#readme",
66
"bugs": {

packages/commerce-sdk-react/src/components/StorefrontPreview/storefront-preview.test.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import StorefrontPreview from './storefront-preview'
1010
import {detectStorefrontPreview} from './utils'
1111
import {Helmet} from 'react-helmet'
1212
import {mockQueryEndpoint, renderWithProviders} from '../../test-utils'
13-
import {useCommerceApi} from '../../hooks'
13+
import {useCommerceApi, useConfig} from '../../hooks'
1414

1515
declare global {
1616
interface Window {
@@ -26,10 +26,13 @@ jest.mock('./utils', () => {
2626
}
2727
})
2828
jest.mock('../../auth/index.ts')
29+
jest.mock('../../hooks/useConfig', () => jest.fn())
2930

3031
describe('Storefront Preview Component', function () {
3132
beforeEach(() => {
3233
delete window.STOREFRONT_PREVIEW
34+
;(useConfig as jest.Mock).mockReturnValue({siteId: 'site-id'})
35+
3336
})
3437
afterEach(() => {
3538
jest.restoreAllMocks()
@@ -101,6 +104,7 @@ describe('Storefront Preview Component', function () {
101104
)
102105
expect(window.STOREFRONT_PREVIEW?.getToken).toBeDefined()
103106
expect(window.STOREFRONT_PREVIEW?.onContextChange).toBeDefined()
107+
expect(window.STOREFRONT_PREVIEW?.siteId).toBeDefined()
104108
expect(window.STOREFRONT_PREVIEW?.experimentalUnsafeNavigate).toBeDefined()
105109
})
106110

packages/commerce-sdk-react/src/components/StorefrontPreview/storefront-preview.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {Helmet} from 'react-helmet'
1111
import {CustomPropTypes, detectStorefrontPreview, getClientScript, proxyRequests} from './utils'
1212
import {useHistory} from 'react-router-dom'
1313
import type {LocationDescriptor} from 'history'
14-
import {useCommerceApi} from '../../hooks'
14+
import {useCommerceApi, useConfig} from '../../hooks'
1515

1616
type GetToken = () => string | undefined | Promise<string | undefined>
1717
type ContextChangeHandler = () => void | Promise<void>
@@ -35,13 +35,15 @@ export const StorefrontPreview = ({
3535
const history = useHistory()
3636
const isHostTrusted = detectStorefrontPreview()
3737
const apiClients = useCommerceApi()
38+
const {siteId} = useConfig()
3839

3940
useEffect(() => {
4041
if (enabled && isHostTrusted) {
4142
window.STOREFRONT_PREVIEW = {
4243
...window.STOREFRONT_PREVIEW,
4344
getToken,
4445
onContextChange,
46+
siteId,
4547
experimentalUnsafeNavigate: (
4648
path: LocationDescriptor<unknown>,
4749
action: 'push' | 'replace' = 'push',
@@ -51,7 +53,7 @@ export const StorefrontPreview = ({
5153
}
5254
}
5355
}
54-
}, [enabled, getToken, onContextChange])
56+
}, [enabled, getToken, onContextChange, siteId])
5557

5658
useEffect(() => {
5759
if (enabled && isHostTrusted) {

packages/commerce-sdk-react/src/hooks/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,6 @@ export {default as useEncUserId} from './useEncUserId'
2323
export {default as useUsid} from './useUsid'
2424
export {default as useCustomerId} from './useCustomerId'
2525
export {default as useCustomerType} from './useCustomerType'
26+
export {default as useConfig} from './useConfig'
2627
export {useCustomQuery} from './useQuery'
2728
export {useCustomMutation} from './useMutation'

packages/template-retail-react-app/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
## v3.0.2 (Jul 11, 2024)
2+
3+
### Bug Fixes
4+
5+
- Fix StorefrontPreview component add siteId query parameter to shopper context calls [#1891](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1891)
6+
17
## v3.0.1 (Jul 9, 2024)
28

39
### Bug Fixes

packages/template-retail-react-app/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/template-retail-react-app/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@salesforce/retail-react-app",
3-
"version": "3.0.1",
3+
"version": "3.0.2",
44
"license": "See license in LICENSE",
55
"author": "cc-pwa-kit@salesforce.com",
66
"ccExtensibility": {
@@ -45,7 +45,7 @@
4545
"@lhci/cli": "^0.11.0",
4646
"@loadable/component": "^5.15.3",
4747
"@peculiar/webcrypto": "^1.4.2",
48-
"@salesforce/commerce-sdk-react": "2.0.1",
48+
"@salesforce/commerce-sdk-react": "2.0.2",
4949
"@salesforce/pwa-kit-dev": "3.6.0",
5050
"@salesforce/pwa-kit-react-sdk": "3.6.0",
5151
"@salesforce/pwa-kit-runtime": "3.6.0",

packages/test-commerce-sdk-react/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
},
1919
"devDependencies": {
2020
"@loadable/component": "^5.15.3",
21-
"@salesforce/commerce-sdk-react": "2.0.1",
21+
"@salesforce/commerce-sdk-react": "2.0.2",
2222
"@salesforce/pwa-kit-dev": "3.6.0",
2323
"@salesforce/pwa-kit-react-sdk": "3.6.0",
2424
"@salesforce/pwa-kit-runtime": "3.6.0",

0 commit comments

Comments
 (0)