Skip to content

Commit fbd1d53

Browse files
authored
[Node 24][V2] Migrate Deprecated Node URL APIs to WHATWG Standard (@W-20757233@) (#3647)
* Migrate to WHATWG URL constructor * lint * PR Feedback * Add Node 22
1 parent 8d8bcf5 commit fbd1d53

File tree

26 files changed

+588
-634
lines changed

26 files changed

+588
-634
lines changed

.github/workflows/test.yml

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,17 @@ jobs:
3131
pwa-kit:
3232
strategy:
3333
matrix:
34-
node: [18, 20]
35-
npm: [9, 10]
34+
node: [18, 20, 22, 24]
35+
npm: [9, 10, 11]
36+
exclude: # node 18 with npm 11 are not compatible
37+
- node: 18
38+
npm: 11
3639
runs-on: ubuntu-latest
3740
env:
3841
# The "default" npm is the one that ships with a given version of node.
3942
# For more: https://nodejs.org/en/download/releases/
40-
IS_DEFAULT_NPM: ${{ matrix.node == 18 && matrix.npm == 9 || matrix.node == 20 && matrix.npm == 10 }}
41-
IS_LATEST_NPM: ${{ matrix.node == 20 && matrix.npm == 10 }}
43+
IS_DEFAULT_NPM: ${{ (matrix.node == 18 && matrix.npm == 10) || (matrix.node == 20 && matrix.npm == 10) || (matrix.node == 22 && matrix.npm == 10) || (matrix.node == 24 && matrix.npm == 11) }}
44+
IS_LATEST_NPM: ${{ matrix.node == 24 && matrix.npm == 11 }}
4245
steps:
4346
- name: Checkout
4447
uses: actions/checkout@v3
@@ -113,12 +116,15 @@ jobs:
113116
pwa-kit-windows:
114117
strategy:
115118
matrix:
116-
node: [18, 20]
117-
npm: [9, 10]
119+
node: [18, 20, 22, 24]
120+
npm: [9, 10, 11]
121+
exclude: # node 18 with npm 11 are not compatible
122+
- node: 18
123+
npm: 11
118124
env:
119125
# The "default" npm is the one that ships with a given version of node.
120126
# For more: https://nodejs.org/en/download/releases/
121-
IS_DEFAULT_NPM: ${{ matrix.node == 18 && matrix.npm == 9 || matrix.node == 20 && matrix.npm == 10 }}
127+
IS_DEFAULT_NPM: ${{ (matrix.node == 18 && matrix.npm == 10) || (matrix.node == 20 && matrix.npm == 10) || (matrix.node == 22 && matrix.npm == 10) || (matrix.node == 24 && matrix.npm == 11) }}
122128
runs-on: windows-latest
123129
steps:
124130
- name: Checkout

package-lock.json

Lines changed: 15 additions & 49 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
"name": "pwa-kit",
33
"version": "2.10.0",
44
"engines": {
5-
"node": "^18.0.0 || ^20.0.0",
6-
"npm": "^9.0.0 || ^10.0.0"
5+
"node": "^18.0.0 || ^20.0.0 || ^22.0.0 || ^24.0.0",
6+
"npm": "^9.0.0 || ^10.0.0 || ^11.0.0"
77
},
88
"devDependencies": {
99
"commander": "^2.20.3",

0 commit comments

Comments
 (0)