Skip to content

Commit ffa67e4

Browse files
authored
CI performance workflow: fix the deploy step (@W-19170135@) (#3091)
* CI perf workflow: fix the deploy step Override the location of the .mobify credential file * More robust fix * Refactor the flags * Add whitespace
1 parent a54d17d commit ffa67e4

File tree

3 files changed

+16
-6
lines changed

3 files changed

+16
-6
lines changed

.github/actions/push_to_mrt/action.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,26 @@ inputs:
66
TARGET:
77
description: MRT target environment
88
FLAGS:
9-
description: Push flags
9+
description: The rest of the flags for the push command
1010
PROJECT:
1111
description: MRT target project
1212
default: "scaffold-pwa"
1313
MESSAGE:
1414
description: Bundle message / name
1515
default: "build ${{ github.run_id }} on ${{ github.ref }} (${{ github.sha }})"
16+
CLOUD_ORIGIN:
17+
description: 'MRT Cloud origin'
18+
default: 'https://cloud.mobify.com'
19+
CREDENTIALS_FILE_PATH:
20+
description: 'Path to the credentials file'
21+
default: '~/.mobify'
1622
runs:
1723
using: composite
1824
steps:
1925
- name: Push Bundle to MRT
2026
run: |-
2127
cd ${{ inputs.CWD }}
2228
if [[ ${{ inputs.TARGET }} ]]; then
23-
npm run push -- -s ${{ inputs.PROJECT }} --message "${{ inputs.MESSAGE }}" --target ${{ inputs.TARGET }} ${{ inputs.FLAGS }}
29+
npm run push -- --projectSlug ${{ inputs.PROJECT }} --message "${{ inputs.MESSAGE }}" --target ${{ inputs.TARGET }} --cloud-origin ${{ inputs.CLOUD_ORIGIN }} --credentialsFile ${{ inputs.CREDENTIALS_FILE_PATH }} ${{ inputs.FLAGS }}
2430
fi
2531
shell: bash

.github/workflows/deploy_latest_release.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,15 @@ jobs:
1313
runs-on: ubuntu-latest
1414
outputs:
1515
IS_LATEST_RELEASE: ${{ steps.checkRelease.outputs.IS_LATEST_RELEASE }}
16-
steps:
16+
steps:
1717
- name: Checkout
1818
uses: actions/checkout@v4
1919

2020
- name: Check if latest release
2121
uses: ./.github/actions/check_if_latest_release
2222
with:
2323
token: ${{ secrets.GITHUB_TOKEN }}
24-
24+
2525
- name: Update Github Outputs
2626
id: checkRelease
2727
run: |-
@@ -45,13 +45,15 @@ jobs:
4545
project: pwa-kit
4646
mobify_user: MOBIFY_STG_CLIENT_USER
4747
mobify_api_key: MOBIFY_STG_CLIENT_API_KEY
48-
flags: --cloud-origin https://cloud-testing.mobify-staging.com -c ~/.mobify --wait
48+
cloud_origin: https://cloud-testing.mobify-staging.com
49+
flags: --wait
4950
- name: demo-site
5051
project_key: retail-react-app-demo-site
5152
target: production
5253
project: scaffold-pwa
5354
mobify_user: MOBIFY_CLIENT_USER
5455
mobify_api_key: MOBIFY_CLIENT_API_KEY
56+
cloud_origin: https://cloud.mobify.com
5557
flags: --wait
5658
steps:
5759
- name: Checkout
@@ -99,4 +101,5 @@ jobs:
99101
TARGET: ${{ matrix.environment.target }}
100102
PROJECT: ${{ matrix.environment.project }}
101103
MESSAGE: ${{ env.BUNDLE_NAME }})
104+
CLOUD_ORIGIN: ${{ matrix.environment.cloud_origin }}
102105
FLAGS: ${{ matrix.environment.flags }}

.github/workflows/performance-metrics.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,5 @@ jobs:
4343
CWD: '${{ steps.generate_app.outputs.project_path }}'
4444
PROJECT: q4-pwa-perf-develop
4545
TARGET: production
46-
FLAGS: --wait --cloud-origin https://cloud-testing.mobify-staging.com
46+
CLOUD_ORIGIN: ${{ vars.MRT_STG_CLOUD_ORIGIN }}
47+
FLAGS: --wait

0 commit comments

Comments
 (0)