From dd9421fc35bd2dcbdc4011f8ab9154379ec2d3ad Mon Sep 17 00:00:00 2001 From: vcua-mobify Date: Fri, 12 Dec 2025 14:30:03 -0800 Subject: [PATCH 01/14] Fix AWS s3 test --- e2e/jest.setup.js | 1 + e2e/scripts/aws-s3-client.test.js | 66 ++++++++++++++++--------------- 2 files changed, 35 insertions(+), 32 deletions(-) diff --git a/e2e/jest.setup.js b/e2e/jest.setup.js index 5a5cc757ac..c9ef0a82fb 100644 --- a/e2e/jest.setup.js +++ b/e2e/jest.setup.js @@ -21,3 +21,4 @@ jest.mock('node:stream', () => require('stream')) jest.mock('node:util', () => require('util')) jest.mock('node:path', () => require('path')) jest.mock('node:fs', () => require('fs')) +jest.mock('node:fs/promises', () => require('fs').promises) diff --git a/e2e/scripts/aws-s3-client.test.js b/e2e/scripts/aws-s3-client.test.js index efd69999d5..f4de132a67 100644 --- a/e2e/scripts/aws-s3-client.test.js +++ b/e2e/scripts/aws-s3-client.test.js @@ -4,14 +4,30 @@ * SPDX-License-Identifier: BSD-3-Clause * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/BSD-3-Clause */ -const {S3Client, PutObjectCommand, GetObjectCommand} = require('@aws-sdk/client-s3') -const {STSClient, AssumeRoleCommand} = require('@aws-sdk/client-sts') const SecureS3Client = require('./aws-s3-client') const {PWA_KIT_BOT_USER_SESSION, AWS_ACCESS_READ_WRITE, AWS_DEFAULT_REGION} = require('./constants') -// Mock AWS SDK modules -jest.mock('@aws-sdk/client-s3') -jest.mock('@aws-sdk/client-sts') +// Mock AWS SDK modules with explicit factory functions +const mockS3ClientSend = jest.fn() +const mockSTSClientSend = jest.fn() + +jest.mock('@aws-sdk/client-s3', () => ({ + S3Client: jest.fn(() => ({ + send: mockS3ClientSend + })), + PutObjectCommand: jest.fn(), + GetObjectCommand: jest.fn() +})) + +jest.mock('@aws-sdk/client-sts', () => ({ + STSClient: jest.fn(() => ({ + send: mockSTSClientSend + })), + AssumeRoleCommand: jest.fn() +})) + +const {S3Client, PutObjectCommand, GetObjectCommand} = require('@aws-sdk/client-s3') +const {STSClient, AssumeRoleCommand} = require('@aws-sdk/client-sts') // Mock console methods to avoid cluttering test output const originalConsoleLog = console.log @@ -19,8 +35,6 @@ const originalConsoleError = console.error describe('SecureS3Client', () => { let client - let mockS3Client - let mockSTSClient beforeEach(() => { // Reset mocks @@ -29,18 +43,6 @@ describe('SecureS3Client', () => { // Mock console methods console.log = jest.fn() console.error = jest.fn() - - // Setup mock S3 client - mockS3Client = { - send: jest.fn() - } - S3Client.mockImplementation(() => mockS3Client) - - // Setup mock STS client - mockSTSClient = { - send: jest.fn() - } - STSClient.mockImplementation(() => mockSTSClient) }) afterEach(() => { @@ -127,7 +129,7 @@ describe('SecureS3Client', () => { SessionToken: 'test-session-token' } - mockSTSClient.send.mockResolvedValue({ + mockSTSClientSend.mockResolvedValue({ Credentials: mockCredentials }) @@ -139,7 +141,7 @@ describe('SecureS3Client', () => { RoleSessionName: PWA_KIT_BOT_USER_SESSION, DurationSeconds: 3600 }) - expect(mockSTSClient.send).toHaveBeenCalled() + expect(mockSTSClientSend).toHaveBeenCalled() expect(client.credentials).toEqual({ accessKeyId: mockCredentials.AccessKeyId, secretAccessKey: mockCredentials.SecretAccessKey, @@ -154,7 +156,7 @@ describe('SecureS3Client', () => { process.env.CI = 'true' client.externalId = 'test-external-id' - mockSTSClient.send.mockResolvedValue({ + mockSTSClientSend.mockResolvedValue({ Credentials: { AccessKeyId: 'test-access-key', SecretAccessKey: 'test-secret-key', @@ -175,7 +177,7 @@ describe('SecureS3Client', () => { test('should throw error when role assumption fails', async () => { const error = new Error('Role assumption failed') - mockSTSClient.send.mockRejectedValue(error) + mockSTSClientSend.mockRejectedValue(error) await expect(client._assumeRole()).rejects.toThrow('Role assumption failed') expect(console.error).toHaveBeenCalledWith('❌ Failed to assume role:', error) @@ -190,7 +192,7 @@ describe('SecureS3Client', () => { test('should successfully upload file with ETag', async () => { const mockResult = {ETag: '"test-etag"'} - mockS3Client.send.mockResolvedValue(mockResult) + mockS3ClientSend.mockResolvedValue(mockResult) const result = await client.upload('test-bucket', 'test-key', 'test-body', 'test-etag') @@ -208,7 +210,7 @@ describe('SecureS3Client', () => { test('should throw error when upload fails', async () => { const error = new Error('Upload failed') - mockS3Client.send.mockRejectedValue(error) + mockS3ClientSend.mockRejectedValue(error) await expect(client.upload('test-bucket', 'test-key', 'test-body')).rejects.toThrow( 'Upload failed' @@ -219,7 +221,7 @@ describe('SecureS3Client', () => { test('should handle PreconditionFailedException specifically', async () => { const error = new Error('Precondition failed') error.name = 'PreconditionFailedException' - mockS3Client.send.mockRejectedValue(error) + mockS3ClientSend.mockRejectedValue(error) await expect(client.upload('test-bucket', 'test-key', 'test-body')).rejects.toThrow( 'Precondition failed' @@ -245,7 +247,7 @@ describe('SecureS3Client', () => { ContentType: 'application/json', ContentLength: 100 } - mockS3Client.send.mockResolvedValue(mockResult) + mockS3ClientSend.mockResolvedValue(mockResult) const result = await client.download('test-bucket', 'test-key') @@ -253,7 +255,7 @@ describe('SecureS3Client', () => { Bucket: 'test-bucket', Key: 'test-key' }) - expect(mockS3Client.send).toHaveBeenCalled() + expect(mockS3ClientSend).toHaveBeenCalled() expect(result).toEqual({ body: mockResult.Body, etag: mockResult.ETag, @@ -269,7 +271,7 @@ describe('SecureS3Client', () => { test('should throw error when download fails', async () => { const error = new Error('Download failed') - mockS3Client.send.mockRejectedValue(error) + mockS3ClientSend.mockRejectedValue(error) await expect(client.download('test-bucket', 'test-key')).rejects.toThrow( 'Download failed' @@ -291,13 +293,13 @@ describe('SecureS3Client', () => { SecretAccessKey: 'test-secret-key', SessionToken: 'test-session-token' } - mockSTSClient.send.mockResolvedValue({ + mockSTSClientSend.mockResolvedValue({ Credentials: mockCredentials }) // Mock upload const mockUploadResult = {ETag: '"upload-etag"'} - mockS3Client.send.mockResolvedValue(mockUploadResult) + mockS3ClientSend.mockResolvedValue(mockUploadResult) await client.initialize() const result = await client.upload('test-bucket', 'test-key', 'test-body') @@ -322,7 +324,7 @@ describe('SecureS3Client', () => { ContentType: 'text/plain', ContentLength: 50 } - mockS3Client.send.mockResolvedValue(mockDownloadResult) + mockS3ClientSend.mockResolvedValue(mockDownloadResult) const downloadResult = await client.download('test-bucket', 'test-key') expect(downloadResult.body).toBe(mockDownloadResult.Body) From e4aef04a0e3c1b0c7a0d8ef8912aaa9edcfb61fb Mon Sep 17 00:00:00 2001 From: vcua-mobify Date: Fri, 12 Dec 2025 14:48:36 -0800 Subject: [PATCH 02/14] Fix mcp test --- packages/pwa-kit-mcp/jest.config.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/pwa-kit-mcp/jest.config.js b/packages/pwa-kit-mcp/jest.config.js index e94965a979..7c00b53463 100644 --- a/packages/pwa-kit-mcp/jest.config.js +++ b/packages/pwa-kit-mcp/jest.config.js @@ -18,5 +18,7 @@ module.exports = { collectCoverageFrom: ['src/**/*.js', '!src/**/*.test.js', '!src/**/*.spec.js'], coverageDirectory: 'coverage', coverageReporters: ['text', 'lcov', 'html'], - testTimeout: 10000 + testTimeout: 10000, + // Transform zod and zod-to-json-schema which use ESM syntax + transformIgnorePatterns: ['/node_modules/(?!(zod|zod-to-json-schema)/)'] } From 8bc578be55ff3eb5a9b605bd5c37982f6888dc0e Mon Sep 17 00:00:00 2001 From: vcua-mobify Date: Fri, 12 Dec 2025 14:51:37 -0800 Subject: [PATCH 03/14] Bump bundle size --- packages/template-retail-react-app/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/template-retail-react-app/package.json b/packages/template-retail-react-app/package.json index d74afa9465..0acf2075aa 100644 --- a/packages/template-retail-react-app/package.json +++ b/packages/template-retail-react-app/package.json @@ -101,11 +101,11 @@ "bundlesize": [ { "path": "build/main.js", - "maxSize": "84 kB" + "maxSize": "86 kB" }, { "path": "build/vendor.js", - "maxSize": "340 kB" + "maxSize": "363 kB" } ] } From 4e0b30d4a0061b5f9eaefc4db5ec2da8a252af28 Mon Sep 17 00:00:00 2001 From: vcua-mobify Date: Fri, 12 Dec 2025 15:31:05 -0800 Subject: [PATCH 04/14] Update snapshots --- .../desktop/__snapshots__/guest/cart-a11y-violations.json | 4 ++-- .../guest/checkout-a11y-violations-step-0.json | 4 ++-- .../guest/checkout-a11y-violations-step-1.json | 4 ++-- .../guest/checkout-a11y-violations-step-3.json | 4 ++-- .../checkout-a11y-violations-step-4-order-confirmation.json | 4 ++-- .../__snapshots__/guest/homepage-a11y-violations.json | 4 ++-- .../desktop/__snapshots__/guest/pdp-a11y-violations.json | 4 ++-- .../desktop/__snapshots__/guest/plp-a11y-violations.json | 4 ++-- .../registered/account-addresses-a11y-violations.json | 4 ++-- .../registered/account-details-a11y-violations.json | 4 ++-- .../registered/checkout-a11y-violations-step-0.json | 4 ++-- .../registered/checkout-a11y-violations-step-1.json | 4 ++-- .../registered/checkout-a11y-violations-step-2.json | 4 ++-- .../registered/checkout-a11y-violations-step-3.json | 4 ++-- .../checkout-a11y-violations-step-4-order-confirmation.json | 6 +++--- .../registered/order-history-a11y-violations.json | 4 ++-- .../__snapshots__/registered/wishlist-violations.json | 4 ++-- .../mobile/__snapshots__/guest/plp-a11y-violations.json | 4 ++-- .../registered/account-details-a11y-violations.json | 6 +++--- 19 files changed, 40 insertions(+), 40 deletions(-) diff --git a/e2e/tests/a11y/desktop/__snapshots__/guest/cart-a11y-violations.json b/e2e/tests/a11y/desktop/__snapshots__/guest/cart-a11y-violations.json index 385b929e5f..a0a7ccb9d0 100644 --- a/e2e/tests/a11y/desktop/__snapshots__/guest/cart-a11y-violations.json +++ b/e2e/tests/a11y/desktop/__snapshots__/guest/cart-a11y-violations.json @@ -4,7 +4,7 @@ "impact": "critical", "description": "Ensure an element's role supports its ARIA attributes", "help": "Elements must only use supported ARIA attributes", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/aria-allowed-attr?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/aria-allowed-attr?application=playwright", "nodes": [ { "html": "
", @@ -20,7 +20,7 @@ "impact": "moderate", "description": "Ensure landmarks are unique", "help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/landmark-unique?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright", "nodes": [ { "html": "
", diff --git a/e2e/tests/a11y/desktop/__snapshots__/guest/checkout-a11y-violations-step-0.json b/e2e/tests/a11y/desktop/__snapshots__/guest/checkout-a11y-violations-step-0.json index 381540a76d..f60330ce96 100644 --- a/e2e/tests/a11y/desktop/__snapshots__/guest/checkout-a11y-violations-step-0.json +++ b/e2e/tests/a11y/desktop/__snapshots__/guest/checkout-a11y-violations-step-0.json @@ -4,7 +4,7 @@ "impact": "moderate", "description": "Ensure landmarks are unique", "help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/landmark-unique?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright", "nodes": [ { "html": "
", @@ -20,7 +20,7 @@ "impact": "moderate", "description": "Ensure all page content is contained by landmarks", "help": "All page content should be contained by landmarks", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/region?application=playwright", "nodes": [ { "html": "", diff --git a/e2e/tests/a11y/desktop/__snapshots__/guest/checkout-a11y-violations-step-1.json b/e2e/tests/a11y/desktop/__snapshots__/guest/checkout-a11y-violations-step-1.json index 381540a76d..f60330ce96 100644 --- a/e2e/tests/a11y/desktop/__snapshots__/guest/checkout-a11y-violations-step-1.json +++ b/e2e/tests/a11y/desktop/__snapshots__/guest/checkout-a11y-violations-step-1.json @@ -4,7 +4,7 @@ "impact": "moderate", "description": "Ensure landmarks are unique", "help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/landmark-unique?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright", "nodes": [ { "html": "
", @@ -20,7 +20,7 @@ "impact": "moderate", "description": "Ensure all page content is contained by landmarks", "help": "All page content should be contained by landmarks", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/region?application=playwright", "nodes": [ { "html": "", diff --git a/e2e/tests/a11y/desktop/__snapshots__/guest/checkout-a11y-violations-step-3.json b/e2e/tests/a11y/desktop/__snapshots__/guest/checkout-a11y-violations-step-3.json index 381540a76d..f60330ce96 100644 --- a/e2e/tests/a11y/desktop/__snapshots__/guest/checkout-a11y-violations-step-3.json +++ b/e2e/tests/a11y/desktop/__snapshots__/guest/checkout-a11y-violations-step-3.json @@ -4,7 +4,7 @@ "impact": "moderate", "description": "Ensure landmarks are unique", "help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/landmark-unique?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright", "nodes": [ { "html": "
", @@ -20,7 +20,7 @@ "impact": "moderate", "description": "Ensure all page content is contained by landmarks", "help": "All page content should be contained by landmarks", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/region?application=playwright", "nodes": [ { "html": "", diff --git a/e2e/tests/a11y/desktop/__snapshots__/guest/checkout-a11y-violations-step-4-order-confirmation.json b/e2e/tests/a11y/desktop/__snapshots__/guest/checkout-a11y-violations-step-4-order-confirmation.json index 381540a76d..f60330ce96 100644 --- a/e2e/tests/a11y/desktop/__snapshots__/guest/checkout-a11y-violations-step-4-order-confirmation.json +++ b/e2e/tests/a11y/desktop/__snapshots__/guest/checkout-a11y-violations-step-4-order-confirmation.json @@ -4,7 +4,7 @@ "impact": "moderate", "description": "Ensure landmarks are unique", "help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/landmark-unique?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright", "nodes": [ { "html": "
", @@ -20,7 +20,7 @@ "impact": "moderate", "description": "Ensure all page content is contained by landmarks", "help": "All page content should be contained by landmarks", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/region?application=playwright", "nodes": [ { "html": "", diff --git a/e2e/tests/a11y/desktop/__snapshots__/guest/homepage-a11y-violations.json b/e2e/tests/a11y/desktop/__snapshots__/guest/homepage-a11y-violations.json index 385b929e5f..a0a7ccb9d0 100644 --- a/e2e/tests/a11y/desktop/__snapshots__/guest/homepage-a11y-violations.json +++ b/e2e/tests/a11y/desktop/__snapshots__/guest/homepage-a11y-violations.json @@ -4,7 +4,7 @@ "impact": "critical", "description": "Ensure an element's role supports its ARIA attributes", "help": "Elements must only use supported ARIA attributes", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/aria-allowed-attr?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/aria-allowed-attr?application=playwright", "nodes": [ { "html": "", @@ -20,7 +20,7 @@ "impact": "moderate", "description": "Ensure landmarks are unique", "help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/landmark-unique?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright", "nodes": [ { "html": "
", diff --git a/e2e/tests/a11y/desktop/__snapshots__/guest/pdp-a11y-violations.json b/e2e/tests/a11y/desktop/__snapshots__/guest/pdp-a11y-violations.json index 385b929e5f..a0a7ccb9d0 100644 --- a/e2e/tests/a11y/desktop/__snapshots__/guest/pdp-a11y-violations.json +++ b/e2e/tests/a11y/desktop/__snapshots__/guest/pdp-a11y-violations.json @@ -4,7 +4,7 @@ "impact": "critical", "description": "Ensure an element's role supports its ARIA attributes", "help": "Elements must only use supported ARIA attributes", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/aria-allowed-attr?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/aria-allowed-attr?application=playwright", "nodes": [ { "html": "", @@ -20,7 +20,7 @@ "impact": "moderate", "description": "Ensure landmarks are unique", "help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/landmark-unique?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright", "nodes": [ { "html": "
", diff --git a/e2e/tests/a11y/desktop/__snapshots__/guest/plp-a11y-violations.json b/e2e/tests/a11y/desktop/__snapshots__/guest/plp-a11y-violations.json index 385b929e5f..a0a7ccb9d0 100644 --- a/e2e/tests/a11y/desktop/__snapshots__/guest/plp-a11y-violations.json +++ b/e2e/tests/a11y/desktop/__snapshots__/guest/plp-a11y-violations.json @@ -4,7 +4,7 @@ "impact": "critical", "description": "Ensure an element's role supports its ARIA attributes", "help": "Elements must only use supported ARIA attributes", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/aria-allowed-attr?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/aria-allowed-attr?application=playwright", "nodes": [ { "html": "", @@ -20,7 +20,7 @@ "impact": "moderate", "description": "Ensure landmarks are unique", "help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/landmark-unique?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright", "nodes": [ { "html": "
", diff --git a/e2e/tests/a11y/desktop/__snapshots__/registered/account-addresses-a11y-violations.json b/e2e/tests/a11y/desktop/__snapshots__/registered/account-addresses-a11y-violations.json index 385b929e5f..a0a7ccb9d0 100644 --- a/e2e/tests/a11y/desktop/__snapshots__/registered/account-addresses-a11y-violations.json +++ b/e2e/tests/a11y/desktop/__snapshots__/registered/account-addresses-a11y-violations.json @@ -4,7 +4,7 @@ "impact": "critical", "description": "Ensure an element's role supports its ARIA attributes", "help": "Elements must only use supported ARIA attributes", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/aria-allowed-attr?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/aria-allowed-attr?application=playwright", "nodes": [ { "html": "", @@ -20,7 +20,7 @@ "impact": "moderate", "description": "Ensure landmarks are unique", "help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/landmark-unique?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright", "nodes": [ { "html": "
", diff --git a/e2e/tests/a11y/desktop/__snapshots__/registered/account-details-a11y-violations.json b/e2e/tests/a11y/desktop/__snapshots__/registered/account-details-a11y-violations.json index 385b929e5f..a0a7ccb9d0 100644 --- a/e2e/tests/a11y/desktop/__snapshots__/registered/account-details-a11y-violations.json +++ b/e2e/tests/a11y/desktop/__snapshots__/registered/account-details-a11y-violations.json @@ -4,7 +4,7 @@ "impact": "critical", "description": "Ensure an element's role supports its ARIA attributes", "help": "Elements must only use supported ARIA attributes", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/aria-allowed-attr?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/aria-allowed-attr?application=playwright", "nodes": [ { "html": "", @@ -20,7 +20,7 @@ "impact": "moderate", "description": "Ensure landmarks are unique", "help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/landmark-unique?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright", "nodes": [ { "html": "
", diff --git a/e2e/tests/a11y/desktop/__snapshots__/registered/checkout-a11y-violations-step-0.json b/e2e/tests/a11y/desktop/__snapshots__/registered/checkout-a11y-violations-step-0.json index 381540a76d..f60330ce96 100644 --- a/e2e/tests/a11y/desktop/__snapshots__/registered/checkout-a11y-violations-step-0.json +++ b/e2e/tests/a11y/desktop/__snapshots__/registered/checkout-a11y-violations-step-0.json @@ -4,7 +4,7 @@ "impact": "moderate", "description": "Ensure landmarks are unique", "help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/landmark-unique?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright", "nodes": [ { "html": "
", @@ -20,7 +20,7 @@ "impact": "moderate", "description": "Ensure all page content is contained by landmarks", "help": "All page content should be contained by landmarks", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/region?application=playwright", "nodes": [ { "html": "", diff --git a/e2e/tests/a11y/desktop/__snapshots__/registered/checkout-a11y-violations-step-1.json b/e2e/tests/a11y/desktop/__snapshots__/registered/checkout-a11y-violations-step-1.json index 381540a76d..f60330ce96 100644 --- a/e2e/tests/a11y/desktop/__snapshots__/registered/checkout-a11y-violations-step-1.json +++ b/e2e/tests/a11y/desktop/__snapshots__/registered/checkout-a11y-violations-step-1.json @@ -4,7 +4,7 @@ "impact": "moderate", "description": "Ensure landmarks are unique", "help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/landmark-unique?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright", "nodes": [ { "html": "
", @@ -20,7 +20,7 @@ "impact": "moderate", "description": "Ensure all page content is contained by landmarks", "help": "All page content should be contained by landmarks", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/region?application=playwright", "nodes": [ { "html": "", diff --git a/e2e/tests/a11y/desktop/__snapshots__/registered/checkout-a11y-violations-step-2.json b/e2e/tests/a11y/desktop/__snapshots__/registered/checkout-a11y-violations-step-2.json index 381540a76d..f60330ce96 100644 --- a/e2e/tests/a11y/desktop/__snapshots__/registered/checkout-a11y-violations-step-2.json +++ b/e2e/tests/a11y/desktop/__snapshots__/registered/checkout-a11y-violations-step-2.json @@ -4,7 +4,7 @@ "impact": "moderate", "description": "Ensure landmarks are unique", "help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/landmark-unique?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright", "nodes": [ { "html": "
", @@ -20,7 +20,7 @@ "impact": "moderate", "description": "Ensure all page content is contained by landmarks", "help": "All page content should be contained by landmarks", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/region?application=playwright", "nodes": [ { "html": "", diff --git a/e2e/tests/a11y/desktop/__snapshots__/registered/checkout-a11y-violations-step-3.json b/e2e/tests/a11y/desktop/__snapshots__/registered/checkout-a11y-violations-step-3.json index 381540a76d..f60330ce96 100644 --- a/e2e/tests/a11y/desktop/__snapshots__/registered/checkout-a11y-violations-step-3.json +++ b/e2e/tests/a11y/desktop/__snapshots__/registered/checkout-a11y-violations-step-3.json @@ -4,7 +4,7 @@ "impact": "moderate", "description": "Ensure landmarks are unique", "help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/landmark-unique?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright", "nodes": [ { "html": "
", @@ -20,7 +20,7 @@ "impact": "moderate", "description": "Ensure all page content is contained by landmarks", "help": "All page content should be contained by landmarks", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/region?application=playwright", "nodes": [ { "html": "", diff --git a/e2e/tests/a11y/desktop/__snapshots__/registered/checkout-a11y-violations-step-4-order-confirmation.json b/e2e/tests/a11y/desktop/__snapshots__/registered/checkout-a11y-violations-step-4-order-confirmation.json index c3c93ab155..fb2255774f 100644 --- a/e2e/tests/a11y/desktop/__snapshots__/registered/checkout-a11y-violations-step-4-order-confirmation.json +++ b/e2e/tests/a11y/desktop/__snapshots__/registered/checkout-a11y-violations-step-4-order-confirmation.json @@ -4,7 +4,7 @@ "impact": "critical", "description": "Ensure an element's role supports its ARIA attributes", "help": "Elements must only use supported ARIA attributes", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/aria-allowed-attr?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/aria-allowed-attr?application=playwright", "nodes": [ { "html": "", @@ -20,7 +20,7 @@ "impact": "serious", "description": "Ensure the contrast between foreground and background colors meets WCAG 2 AA minimum contrast ratio thresholds", "help": "Elements must meet minimum color contrast ratio thresholds", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/color-contrast?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/color-contrast?application=playwright", "nodes": [ { "html": "Continue Shopping", @@ -36,7 +36,7 @@ "impact": "moderate", "description": "Ensure landmarks are unique", "help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/landmark-unique?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright", "nodes": [ { "html": "
", diff --git a/e2e/tests/a11y/desktop/__snapshots__/registered/order-history-a11y-violations.json b/e2e/tests/a11y/desktop/__snapshots__/registered/order-history-a11y-violations.json index 385b929e5f..a0a7ccb9d0 100644 --- a/e2e/tests/a11y/desktop/__snapshots__/registered/order-history-a11y-violations.json +++ b/e2e/tests/a11y/desktop/__snapshots__/registered/order-history-a11y-violations.json @@ -4,7 +4,7 @@ "impact": "critical", "description": "Ensure an element's role supports its ARIA attributes", "help": "Elements must only use supported ARIA attributes", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/aria-allowed-attr?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/aria-allowed-attr?application=playwright", "nodes": [ { "html": "", @@ -20,7 +20,7 @@ "impact": "moderate", "description": "Ensure landmarks are unique", "help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/landmark-unique?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright", "nodes": [ { "html": "
", diff --git a/e2e/tests/a11y/desktop/__snapshots__/registered/wishlist-violations.json b/e2e/tests/a11y/desktop/__snapshots__/registered/wishlist-violations.json index 385b929e5f..a0a7ccb9d0 100644 --- a/e2e/tests/a11y/desktop/__snapshots__/registered/wishlist-violations.json +++ b/e2e/tests/a11y/desktop/__snapshots__/registered/wishlist-violations.json @@ -4,7 +4,7 @@ "impact": "critical", "description": "Ensure an element's role supports its ARIA attributes", "help": "Elements must only use supported ARIA attributes", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/aria-allowed-attr?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/aria-allowed-attr?application=playwright", "nodes": [ { "html": "", @@ -20,7 +20,7 @@ "impact": "moderate", "description": "Ensure landmarks are unique", "help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/landmark-unique?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright", "nodes": [ { "html": "
", diff --git a/e2e/tests/a11y/mobile/__snapshots__/guest/plp-a11y-violations.json b/e2e/tests/a11y/mobile/__snapshots__/guest/plp-a11y-violations.json index 385b929e5f..a0a7ccb9d0 100644 --- a/e2e/tests/a11y/mobile/__snapshots__/guest/plp-a11y-violations.json +++ b/e2e/tests/a11y/mobile/__snapshots__/guest/plp-a11y-violations.json @@ -4,7 +4,7 @@ "impact": "critical", "description": "Ensure an element's role supports its ARIA attributes", "help": "Elements must only use supported ARIA attributes", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/aria-allowed-attr?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/aria-allowed-attr?application=playwright", "nodes": [ { "html": "", @@ -20,7 +20,7 @@ "impact": "moderate", "description": "Ensure landmarks are unique", "help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/landmark-unique?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright", "nodes": [ { "html": "
", diff --git a/e2e/tests/a11y/mobile/__snapshots__/registered/account-details-a11y-violations.json b/e2e/tests/a11y/mobile/__snapshots__/registered/account-details-a11y-violations.json index 7ffb346986..2838683a13 100644 --- a/e2e/tests/a11y/mobile/__snapshots__/registered/account-details-a11y-violations.json +++ b/e2e/tests/a11y/mobile/__snapshots__/registered/account-details-a11y-violations.json @@ -4,7 +4,7 @@ "impact": "critical", "description": "Ensure an element's role supports its ARIA attributes", "help": "Elements must only use supported ARIA attributes", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/aria-allowed-attr?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/aria-allowed-attr?application=playwright", "nodes": [ { "html": "", @@ -20,7 +20,7 @@ "impact": "moderate", "description": "Ensure landmarks are unique", "help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination", - "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/landmark-unique?application=playwright", + "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright", "nodes": [ { "html": "
", @@ -36,7 +36,7 @@ "impact": "serious", "description": "Ensure that lists are structured correctly", "help": "
    and
      must only directly contain
    1. ,