Remove unused settings and update PMD rules to use correct Visualforce category

Author: tprouvot

.vscode/settings.json

@@ -30,11 +30,5 @@
 	"[visualforce]": {
 		"editor.defaultFormatter": "salesforce.salesforcedx-vscode-visualforce",
 		"editor.formatOnSave": false
-	},
-	"workbench.colorCustomizations": {
-		"editorRuler.foreground": "#ff4081",
-		"statusBar.background": null,
-		"activityBar.background": null
-	},
-	"xml.preferences.showSchemaDocumentationType": "none"
+	}
 }

pmd/deployRules.xml

@@ -308,7 +308,7 @@
 	<!-- <rule ref="category/apex/errorprone.xml/OverrideBothEqualsAndHashcode" /> -->
 
 	<!-- VISUALFORCE RULES -->
-	<rule ref="category/vf/security.xml/VfHtmlStyleTagXss" message="Dynamic EL content within URL in style tag should be URLENCODED or JSINHTMLENCODED as appropriate">
+	<rule ref="category/visualforce/security.xml/VfHtmlStyleTagXss" message="Dynamic EL content within URL in style tag should be URLENCODED or JSINHTMLENCODED as appropriate">
 		<!--
 					<apex:page>
 				<style>
@@ -324,12 +324,13 @@
 		<priority>3</priority>
 	</rule>
 
-	<!--Example <apex:outputText value="Potential XSS is {! here }" escape="false" /> -->
-	<!-- 	<rule ref="category/vf/security.xml/VfUnescapeEl" message="Avoid unescaped user controlled content in EL as it results in XSS.">
+	<!--Example
+	<apex:outputText value="Potential XSS is {! here }" escape="false" /> -->
+	<!-- 	<rule ref="category/visualforce/security.xml/VfUnescapeEl" message="Avoid unescaped user controlled content in EL as it results in XSS.">
 		<priority>3</priority>
 	</rule> -->
 
 	<!-- Error on apex:page action usage -->
 	<!-- <apex:page controller="AcRestActionsController" action="{!csrfInitMethod}" > -->
-	<rule ref="category/vf/security.xml/VfCsrf" />
-</ruleset>
+	<rule ref="category/visualforce/security.xml/VfCsrf" />
+</ruleset>

sfdx-source/LabsActionPlans/main/default/permissionsets/Action_Plans_Admin.permissionset-meta.xml

@@ -535,15 +535,6 @@
         <object>ActionPlan__c</object>
         <viewAllRecords>true</viewAllRecords>
     </objectPermissions>
-    <objectPermissions>
-        <allowCreate>false</allowCreate>
-        <allowDelete>false</allowDelete>
-        <allowEdit>false</allowEdit>
-        <allowRead>true</allowRead>
-        <modifyAllRecords>false</modifyAllRecords>
-        <object>Contact</object>
-        <viewAllRecords>false</viewAllRecords>
-    </objectPermissions>
     <objectPermissions>
         <allowCreate>true</allowCreate>
         <allowDelete>true</allowDelete>
@@ -653,4 +644,4 @@
         <enabled>true</enabled>
         <name>ActivitiesAccess</name>
     </userPermissions>
-</PermissionSet>
+</PermissionSet>