When LWS is off, globalThis is undefined #633

Author: VinceFINET

build/src/api/core/orgcheck-api-compressor-impl.js

@@ -15,7 +15,7 @@ export class Compressor extends CompressorIntf {
     constructor() {
         super();
         // @ts-ignore
-        this._api = globalThis?.fflate ?? null;
+        this._api = window?.fflate ?? globalThis?.fflate ?? null;
         if (!this._api) throw new Error("fflate library not found");
     }
 

build/src/api/orgcheck-api.js

@@ -135,7 +135,7 @@ export class API {
         // --------------------
         if (setup?.salesforce?.connection?.useJsForce === true) {
             // @ts-ignore 
-            this._sfdcManager = new SalesforceManager(globalThis?.jsforce ?? null, setup?.salesforce?.authentication);
+            this._sfdcManager = new SalesforceManager(window?.jsforce ?? globalThis?.jsforce ?? null, setup?.salesforce?.authentication);
         } else {
             this._sfdcManager = new SalesforceManager(setup?.salesforce?.connection?.mockImpl, {});
         }

build/src/api/scanner/orgcheck-api-lfs-scanner.js

@@ -42,38 +42,33 @@ export class LFSScanner {
      * @returns {Promise<Map<string, Array<any>>>} Map of flow version ID to LFS violations
      */
     static async scanFlows(flowRecords, CaseSafeId) {
+        let results = new Map();
         try {
             // @ts-ignore
-            const lfsCore = globalThis?.lightningflowscanner ?? null;
+            const lfsCore = window?.lightningflowscanner ?? globalThis?.lightningflowscanner ?? null;
+            if (lfsCore) {
+                // Convert flow records to LFS format
+                const lfsFlows = flowRecords.filter(record => record.Metadata) // only if flows have metadata!
+                    .map(record => {
+                        /** @type {string} */
+                        const id15 = CaseSafeId(record.Id);
+                        return {
+                            uri: id15,
+                            flow: new lfsCore.Flow(id15, this.normalizeMetadata(record.Metadata))
+                        };
+                    });
 
-            if (!lfsCore) {
-                // console.warn('LFS_Core.js not available, skipping LFS scanning');
-                return new Map();
-            }
-
-            const { Flow, scan } = lfsCore;
-
-            // Convert flow records to LFS format
-            const lfsFlows = flowRecords.filter(record => record.Metadata) // only if flows have metadata!
-                .map(record => {
-                    /** @type {string} */
-                    const id15 = CaseSafeId(record.Id);
-                    return {
-                        uri: id15,
-                        flow: new Flow(id15, this.normalizeMetadata(record.Metadata))
-                    };
-                });
+                // Scan flows
+                const scanResults = lfsCore.scan(lfsFlows);
 
-            // Scan flows
-            const scanResults = scan(lfsFlows);
-
-            // Map results: flowVersionId -> violations
-            return this.mapResults(scanResults);
+                // Map results: flowVersionId -> violations
+                results = this.mapResults(scanResults);
+            }
 
         } catch (error) {
-            console.error('Error scanning flows with LFS: ', error?.message || JSON.stringify(error));
-            return new Map();
+            console.info(`Error scanning flows with LFS: returning an empty map (error: ${error?.message})`);
         }
+        return results;
     }
 
     /**

build/src/ui/exporter/orgcheck-ui-exporter.js

@@ -12,7 +12,7 @@ export class Exporter {
      */
     static exportAsXls(source) {
         // @ts-ignore
-        const xlsx = globalThis?.XLSX ?? null;
+        const xlsx = window?.XLSX ?? globalThis?.XLSX ?? null;
         if (!xlsx) {
             throw new Error('XLSX not available, skipping XLS export');
         }

build/test/api/unit/orgcheck-api-datasets.unit.test.js

@@ -116,6 +116,12 @@ class SimpleLoggerMock extends SimpleLoggerIntf {
 describe('tests.api.unit.Datasets', () => {
 
   describe('Basic test for all datasets', () => {
+    // Mocking Lightning Flow Scanner to avoid errors in tests for datasets that do
+    //  not use it, but still test that the integration does not cause issues
+    window.lightningflowscanner = {
+      Flow: function() { return {}; },
+      scan: function() { return [];}
+    }; 
     [
       DatasetApexClasses, DatasetApexTriggers, DatasetAppPermissions, 
       DatasetCurrentUserPermissions, DatasetCustomFields, 

force-app/main/default/lwc/orgcheckApp/orgcheckApp.html

@@ -80,6 +80,7 @@ <h1><span class="slds-page-header__title slds-truncate">Welcome in Org Check ({o
                                         <li><b>fflate</b>: distributed under the MIT license, more info at <a href="https://101arrowz.github.io/fflate" target="_blank" rel="external noopener noreferrer">101arrowz.github.io/fflate</a></li>
                                         <li><b>JsForce</b>: distributed under the MIT license, more info at <a href="https://jsforce.github.io" target="_blank" rel="external noopener noreferrer">jsforce.github.io</a></li>
                                         <li><b>SheetJS</b>: distributed under the Apache license v2.0, more info at <a href="https://sheetjs.com/" target="_blank" rel="external noopener noreferrer">sheetjs.com</a></li>
+                                        <li><b>Lightning Flow Scanner</b>: distributed under the MIT License, more info at <a href="https://flow-scanner.github.io/lightning-flow-scanner" target="_blank" rel="external noopener noreferrer">flow-scanner.github.io/lightning-flow-scanner</a></li>
                                         <li><b>Xyris</b>: online website used to animated Org Checky (our mascot), more info at <a href="https://xyris.app/" target="_blank" rel="external noopener noreferrer">xyris.app</a></li>
                                     </ul>
                                 </div>

force-app/main/default/lwc/orgcheckGraphics/orgcheckGraphics.js

@@ -38,7 +38,7 @@ export default class OrgcheckGraphics extends LightningElement {
         .then(() => {
           this._apiInitialized = true;
           // @ts-ignore
-          this._api = globalThis?.d3 ?? null;
+          this._api = window?.d3 ?? globalThis?.d3 ?? null;
           // draw graph now
           this._drawGraph();
         })

package.json

@@ -18,6 +18,7 @@
     "scan:api": "sf code-analyzer run --target ./build/src/api --output-file /tmp/orgcheck-api-scan.html; open /tmp/orgcheck-api-scan.html",
     "scan:ui": "sf code-analyzer run --target ./build/src/ui --output-file /tmp/orgcheck-ui-scan.html; open /tmp/orgcheck-ui-scan.html",
     "scan:lwc": "sf code-analyzer run --target './force-app/main/default/lwc/*/*.js' --output-file /tmp/orgcheck-lwc-scan.html; open /tmp/orgcheck-lwc-scan.html",
+    "scan:securityreview": "sf code-analyzer run --rule-selector AppExchange --rule-selector Recommended:Security --output-file /tmp/orgcheck-security-scan.html; open /tmp/orgcheck-security-scan.html",
     "sf:open": "sf force org open",
     "sf:clean": "sf project deploy start --metadata-dir manifest/destructive",
     "git:clean": "git remote update origin --prune; git branch -vv | grep 'gone]' | awk '{print $1}' | xargs git branch -D ",

sfdx-project.json

@@ -5,7 +5,7 @@
       "default": false,
       "package": "Org Check",
       "versionName": "Nitrogen",
-      "versionNumber": "7.4.0.NEXT",
+      "versionNumber": "7.6.0.NEXT",
       "versionDescription": "Org Check is an easy-to-install and easy-to-use Salesforce application in order to quickly analyze your org and its technical debt.",
       "ancestorVersion": "HIGHEST"
     },
@@ -14,7 +14,7 @@
       "default": true,
       "package": "Org Check (unlocked)",
       "versionName": "Nitrogen",
-      "versionNumber": "7.4.0.NEXT",
+      "versionNumber": "7.6.0.NEXT",
       "versionDescription": "Org Check is an easy-to-install and easy-to-use Salesforce application in order to quickly analyze your org and its technical debt."
     }
   ],
@@ -26,6 +26,7 @@
     "Org Check@5.7.0-1-main": "04tKB000000DQHzYAO",
     "Org Check (unlocked)": "0Ho2X000000KyjaSAC",
     "Org Check (unlocked)@6.4.0-1": "04tKB000000DVKUYA4",
-    "Org Check (unlocked)@7.4.0-1": "04tKB000000DYYqYAO"
+    "Org Check (unlocked)@7.4.0-1": "04tKB000000DYYqYAO",
+    "Org Check (unlocked)@7.5.0-1": "04tKB000000DZIpYAO"
   }
 }