Merge pull request #231 from Sambruk/bugfix/208

Bugfix/208

Author: joesiltberg

CHANGELOG.md

@@ -7,6 +7,7 @@
   - Space for the cache file is now pre-allocated before SCIM operations start (#197)
 
 #### Bugfixes
+  - Fixed an access violation which could occur when generating activities if no groups had been loaded (#208)
   - When using the --rebuild-cache feature, a failure to GET objects will now terminate the client (#205)
 
 ## v2.18 (2024-11-19)

src/generated_load.cpp

@@ -190,7 +190,10 @@ std::shared_ptr<object_list> get_generated_activity(const std::string &type,
 
     data_server &server = data_server::instance();
     auto student_groups = server.get_by_type(master_type);
-    auto employments = server.get_by_type(related_type.first);
+
+    if (!student_groups) {
+        student_groups = std::make_shared<object_list>();
+    }
 
     for (const auto &student_group : *student_groups) {
         base_object generated_object(type);
@@ -504,7 +507,7 @@ std::shared_ptr<object_list> get_generated_employment(const std::string &type,
                             }
                         }
                         extras_set = true;
-                    } catch (const std::out_of_range& e) {
+                    } catch (const std::out_of_range&) {
                         // no match in extras for this Employment object
                     }
                 }