SF-66: The number of forms is not correct:

- Counting unique items by creation date
- Not using $parent for fetching submitted forms.

Author: 3emluk

app/components/sidebar/sidebar-forms-collapsed-directive.js

@@ -8,7 +8,7 @@ angular.module('sf').directive('sidebarFormsCollapsed', function ($routeParams,
         },
         templateUrl: 'components/sidebar/sidebar-forms-collapsed.html',
         link: function (scope) {
-            scope.submittedFormList = scope.$parent.submittedFormList;
+            scope.submittedFormList = caseService.getSubmittedFormList($routeParams.caseId);
             scope.possibleForms = scope.$parent.possibleForms;
             scope.caze = scope.$parent.caze;
 

app/components/sidebar/sidebar-forms-collapsed.html

@@ -1,5 +1,6 @@
 <div data-ng-repeat="form in possibleForms" class="main">
-    <span data-ng-repeat="submittedForm in submittedForms = (submittedFormList | filter: form.id: submittedForm.id && submittedForms.length > 0)"></span>
+    <span data-ng-repeat="submittedForm in submittedForms = (submittedFormList | filter: form.id: submittedForm.id | unique:'submissionDate') "></span>
+
     <div data-ng-if="submittedForms.length != '0'">
         <a data-ng-click="openFormInNewWindow(form.id, false)" href=""
            class="left form-name convCaseSidebar">

app/components/sidebar/sidebar-forms.html

@@ -2,7 +2,7 @@
     <a data-ng-click="openFormInNewWindow(form.id, false)" href=""
        class="left form-name convCaseSidebar">
         {{form.text}}
-        <span data-ng-repeat="submittedForm in submittedForms = (submittedFormList | filter: form.id: submittedForm.id) track by $index"></span>
+        <span data-ng-repeat="submittedForm in submittedForms = (submittedFormList | filter: form.id: submittedForm.id | unique:'submissionDate')"></span>
     </a>
     <div class="convo-status form-icons"><a href="#/cases/{{ caze[0].id }}/formhistory/{{ form.id }}"><span
             class="icon-history" title="Formulär, historik">{{submittedForms.length}} <span class="struct">Formulär, historik</span></span></a>