Fix for checks

Author: hei98

backend/samfundet/serializers.py

@@ -3,7 +3,7 @@
 import re
 import datetime
 import itertools
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, Any
 from collections import defaultdict
 
 from PIL import Image as PilImage
@@ -247,13 +247,13 @@ def get_image(self, obj: Event) -> dict:
             "tags": list(img.tags.values_list("id", flat=True))
         }
 
-    def update(self, instance, validated_data) -> Event:
+    def update(self, instance: Event, validated_data: dict[str, Any]) -> Event:
         image_id = validated_data.pop("image_id", None)
         if image_id is not None:
             try:
                 instance.image = Image.objects.get(pk=image_id)
-            except Image.DoesNotExist:
-                raise serializers.ValidationError({"image_id": "Invalid image id"})    
+            except Image.DoesNotExist as err:
+                raise serializers.ValidationError({"image_id": "Invalid image id"}) from err
 
         for attr, value in validated_data.items():
             setattr(instance, attr, value)

frontend/src/PagesAdmin/EventCreatorAdminPage/EventCreatorAdminPage.tsx

@@ -24,9 +24,9 @@ import {
 import type { DropdownOption } from '~/Components/Dropdown/Dropdown';
 import { ImagePicker } from '~/Components/ImagePicker/ImagePicker';
 import { type Tab, TabBar } from '~/Components/TabBar/TabBar';
-import { getEvent, getImages, getVenues, postEvent, putEvent } from '~/api';
+import { getEvent, getVenues, postEvent, putEvent } from '~/api';
 import { BACKEND_DOMAIN } from '~/constants';
-import type { EventDto, ImageDto } from '~/dto';
+import type { EventDto } from '~/dto';
 import { useCustomNavigate, usePrevious, useTitle } from '~/hooks';
 import { KEY } from '~/i18n/constants';
 import { venueKeys } from '~/queryKeys';

frontend/src/api.ts

@@ -294,15 +294,15 @@ export async function getEvents(): Promise<EventDto[]> {
 
 export async function postEvent(data: Partial<EventDto>): Promise<AxiosResponse<EventDto>> {
   const transformed = { ...data, image_id: data.image?.id };
-  delete transformed.image;
+  transformed.image = undefined;
   const url = BACKEND_DOMAIN + ROUTES.backend.samfundet__events_list;
   const response = await axios.post<EventDto>(url, transformed, { withCredentials: true });
   return response;
 }
 
 export async function putEvent(id: string | number, data: Partial<EventDto>): Promise<AxiosResponse<EventDto>> {
   const transformed = { ...data, image_id: data.image?.id };
-  delete transformed.image;
+  transformed.image = undefined;
   const url = BACKEND_DOMAIN + reverse({ pattern: ROUTES.backend.samfundet__events_detail, urlParams: { pk: id } });
   const response = await axios.put<EventDto>(url, transformed, { withCredentials: true });
   return response;

frontend/src/dto.ts

@@ -162,7 +162,6 @@ export type EventDto = {
 
   // General info
   id: number;
-  image_id: number;
   title_nb: string;
   title_en: string;
   description_long_nb: string;
@@ -179,7 +178,6 @@ export type EventDto = {
   registration_url?: string;
 
   // Timestamps/duration
-  image_url: string;
   start_dt: string;
   duration: number;
   end_dt: string;
@@ -195,6 +193,8 @@ export type EventDto = {
 
   // Write only:
   // Used to create new event with using id of existing imagedto
+  image_id?: number;
+  image_url: string;
   image?: ImageDto;
   capacity?: number;
 };