feat: ApplicationFileAttachmentViewSet

Author: emsoraffa

backend/samfundet/models/recruitment.py

@@ -167,7 +167,7 @@ class RecruitmentPosition(CustomBaseModel):
     # TODO: Implement interviewer functionality
     interviewers = models.ManyToManyField(to=User, help_text='Interviewers for the position', blank=True, related_name='interviewers')
 
-    #FIX: Add functionality for setting allowed attachments for application
+    # FIX: Add functionality for setting allowed attachments for application
     recruitment = models.ForeignKey(
         Recruitment,
         on_delete=models.CASCADE,
@@ -320,15 +320,16 @@ def resolve_gang(self, *, return_id: bool = False) -> Gang | int:
         return self.room.resolve_gang(return_id=return_id)
 
 
-
 class RecruitmentApplication(CustomBaseModel):
     # UUID so that applicants cannot see recruitment info with their own id number
     id = models.UUIDField(primary_key=True, default=uuid.uuid4, editable=False)
     application_text = models.TextField(help_text='Application text')
     recruitment_position = models.ForeignKey(
         RecruitmentPosition, on_delete=models.CASCADE, help_text='The position which is recruiting', related_name='applications'
     )
-    recruitment = models.ForeignKey(Recruitment, on_delete=models.CASCADE, null=True, help_text='The recruitment that is recruiting', related_name='applications')
+    recruitment = models.ForeignKey(
+        Recruitment, on_delete=models.CASCADE, null=True, help_text='The recruitment that is recruiting', related_name='applications'
+    )
     user = models.ForeignKey(User, on_delete=models.CASCADE, help_text='The user that is applying', related_name='applications')
     applicant_priority = models.PositiveIntegerField(null=True, blank=True, help_text='The priority of the application')
 
@@ -492,22 +493,24 @@ def update_applicant_state(self) -> None:
                     application.applicant_state = RecruitmentApplicantStates.NOT_WANTED
                 application.save()
 
+
 class ApplicationFileAttachment(CustomBaseModel):
-    application = models.ForeignKey(RecruitmentApplication, 
-                                    on_delete=models.CASCADE, 
-                                    related_name="attachments", 
-                                    help_text="The recruitment application this file is attached to")
-    application_file = models.FileField(upload_to="some/path")
+    application = models.ForeignKey(
+        RecruitmentApplication, on_delete=models.CASCADE, related_name='attachments', help_text='The recruitment application this file is attached to'
+    )
+    application_file = models.FileField(upload_to='some/path')
     application_file_type = models.CharField(max_length=50, blank=True)
 
     def clean(self) -> None:
         super().clean()
-        if self.file:
-            file_type = self.file.content_type
-            self.file_type = file_type
+        if self.application_file:
+            file_type = self.application_file.content_type
+            self.application_file_type = file_type or ''
             allowed_types = [
-                'image/jpeg', 'image/png',  # Images
-                'video/mp4' # Video
+                'image/jpeg',
+                'image/png',  # Images
+                'video/mp4',  # Video
+                'application/pdf',
             ]
             if file_type not in allowed_types:
                 raise ValidationError('Wrong filetype')
@@ -517,6 +520,7 @@ def clean(self) -> None:
     def __str__(self):
         return f'Attachment for {self.application} - {self.file.name}'
 
+
 class RecruitmentInterviewAvailability(CustomBaseModel):
     """This models all possible times for interviews for the given recruitment.
 

backend/samfundet/serializers.py

@@ -84,16 +84,15 @@
 class ApplicationFileAttachmentSerializer(CustomBaseSerializer):
     class Meta:
         model = ApplicationFileAttachment
+        fields = (
+            'id',
+            'application',
+            'application_file',
+            'application_file_type',
+        )
 
     def validate(self, attrs: dict) -> dict:
-        admission_image = attrs.get('admission_image')
-
-        # if admission_image:
-        #     is_image_valid(admission_image)
-        # else:
-        #     msg = 'Image is invalid'
-        #     raise serializers.ValidationError(msg, code="authorization")
-        # if
+        return attrs
 
 
 class TagSerializer(CustomBaseSerializer):

backend/samfundet/views.py

@@ -50,6 +50,7 @@
 from .homepage import homepage
 from .models.role import Role, UserOrgRole, UserGangRole, UserGangSectionRole
 from .serializers import (
+    ApplicationFileAttachmentSerializer,
     TagSerializer,
     GangSerializer,
     MenuSerializer,
@@ -143,6 +144,7 @@
     UserFeedbackModel,
 )
 from .models.recruitment import (
+    ApplicationFileAttachment,
     Interview,
     Recruitment,
     InterviewRoom,
@@ -690,6 +692,16 @@ def delete(self, request: Request) -> Response:
 # =============================== #
 
 
+class ApplicationFileAttachmentViewSet(ModelViewSet):
+    serializer_class = ApplicationFileAttachmentSerializer
+    queryset = ApplicationFileAttachment.objects.all()
+
+    # Typically, you might want extra permission logic here:
+    #   - Only the applicant or a recruiter with certain perms can read attachments
+    #   - Only the applicant can create attachments for *their own* application
+    # etc.
+
+
 @method_decorator(ensure_csrf_cookie, 'dispatch')
 class RecruitmentView(ModelViewSet):
     permission_classes = (DjangoModelPermissionsOrAnonReadOnly,)