fix

Author: babenek

.github/workflows/check.yml

@@ -93,7 +93,7 @@ jobs:
         run: |
           banner="$(python -m credsweeper --banner | grep CredSweeper | head -1)"
           echo "banner = '${banner}'"
-          if [ "CredSweeper 1.15.3 crc32:0d332b1f" != "${banner}" ]; then
+          if [ "CredSweeper 1.15.3 crc32:4dac77cb" != "${banner}" ]; then
             echo "Update the check for '${banner}'"
             exit 1
           fi

credsweeper/utils/pem_key_detector.py

@@ -90,7 +90,7 @@ def detect_pem_key(cls, config: Config, target: AnalysisTarget) -> List[LineData
                                     return line_data
                         logger.debug("Filtered with non asn1 '%s'", key_data)
                     return []
-                # PEM_END_PATTERN not in subline
+                # else - PEM_END_PATTERN not in subline
                 sanitized_line = cls.sanitize_line(subline)
                 # PEM key line should not contain spaces or . (and especially not ...)
                 for i in sanitized_line:

credsweeper/utils/util.py

@@ -263,9 +263,8 @@ def get_asn1_size(data: Union[bytes, bytearray]) -> int:
                 if data.endswith(b"\x00\x00"):
                     # assume, all data are ASN1 of various size
                     return len(data)
-                # skip the case where the ASN1 size is smaller than the actual data
-                return 0
-            if 0x80 < length:
+                # else - skip the case where the ASN1 size is smaller than the actual data
+            elif 0x80 < length:
                 byte_len = 0x7F & length
                 len_limit = 2 + byte_len
                 if 4 >= byte_len and len(data) >= len_limit:
@@ -275,12 +274,12 @@ def get_asn1_size(data: Union[bytes, bytearray]) -> int:
                         length |= data[i]
                     if len(data) >= length + len_limit:
                         return length + len_limit
-                else:
-                    # unsupported huge size
-                    return 0
-            # length is less than 0x80
-            if len(data) >= length + 2:
-                return length + 2
+                # else - unsupported huge size
+            else:
+                # length is less than 0x80
+                if len(data) >= length + 2:
+                    return length + 2
+        # fallback - unsupported
         return 0
 
     @staticmethod