[compute/cker] Reduce duplicated code.

This commit refactors dims storage initialization of Shape.

ONE-DCO-1.0-Signed-off-by: ragmani <ragmani0216@gmail.com>

Author: ragmani

runtime/compute/cker/include/cker/Shape.h

@@ -49,28 +49,13 @@ class Shape
   // Otherwise, it uses a dynamic vector.
   explicit Shape(int dimensions_count) : _size(dimensions_count)
   {
-    if (dimensions_count <= kMaxSmallSize)
-    {
-      dims_ = std::array<int32_t, kMaxSmallSize>{};
-    }
-    else
-    {
-      dims_ = std::vector<int32_t>(dimensions_count);
-    }
+    initStorage(dimensions_count);
   }
 
   // Constructor that creates a shape of given size and fills all dimensions with "value".
   Shape(int shape_size, int32_t value) : _size(0)
   {
-    if (shape_size <= kMaxSmallSize)
-    {
-      dims_ = std::array<int32_t, kMaxSmallSize>{};
-    }
-    else
-    {
-      dims_ = std::vector<int32_t>(shape_size);
-    }
-
+    initStorage(shape_size);
     for (int i = 0; i < shape_size; ++i)
     {
       SetDim(i, value);
@@ -80,16 +65,7 @@ class Shape
   // Constructor that creates a shape from an array of dimension data.
   Shape(int dimensions_count, const int32_t *dims_data) : _size(0)
   {
-    // Explicitly initialize dims_ based on dimensions_count to avoid uninitialized state.
-    if (dimensions_count <= kMaxSmallSize)
-    {
-      dims_ = std::array<int32_t, kMaxSmallSize>{};
-    }
-    else
-    {
-      dims_ = std::vector<int32_t>(dimensions_count);
-    }
-
+    initStorage(dimensions_count);
     ReplaceWith(dimensions_count, dims_data);
   }
 
@@ -98,18 +74,7 @@ class Shape
   Shape(const std::initializer_list<int> init_list) : _size(0)
   {
     const auto size = static_cast<int>(std::distance(init_list.begin(), init_list.end()));
-
-    // Explicitly initialize dims_ based on the initializer list size to prevent
-    // "maybe uninitialized" warnings when BuildFrom() is invoked.
-    if (size <= kMaxSmallSize)
-    {
-      dims_ = std::array<int32_t, kMaxSmallSize>{};
-    }
-    else
-    {
-      dims_ = std::vector<int32_t>(size);
-    }
-
+    initStorage(size);
     BuildFrom(init_list);
   }
 
@@ -207,10 +172,7 @@ class Shape
     // initialize dims_ explicitly based on dimensions_count to ensure it is in a valid state.
     if (dims_.valueless_by_exception())
     {
-      if (dimensions_count <= kMaxSmallSize)
-        dims_ = std::array<int32_t, kMaxSmallSize>{};
-      else
-        dims_ = std::vector<int32_t>(dimensions_count);
+      initStorage(dimensions_count);
     }
 
     std::vector<int32_t> oldDims;
@@ -304,21 +266,31 @@ class Shape
   bool operator!=(const Shape &comp) const { return !((*this) == comp); }
 
 private:
+  // Helper function: initialize dims_ storage based on the number of dimensions.
+  inline void initStorage(int dimensions_count)
+  {
+    if (dimensions_count <= kMaxSmallSize)
+      dims_ = std::array<int32_t, kMaxSmallSize>{};
+    else
+      dims_ = std::vector<int32_t>(dimensions_count);
+  }
+
   // For use only by ExtendedShape(), written to guarantee (return-value) copy
   // elision in C++17.
   // This creates a shape padded to the desired size with the specified value.
   Shape(int new_shape_size, const Shape &shape, int pad_value) : _size(0)
   {
     assert(new_shape_size >= shape.DimensionsCount());
     assert(new_shape_size <= kMaxSmallSize);
-    Resize(new_shape_size);
+    initStorage(new_shape_size);
     const int size_increase = new_shape_size - shape.DimensionsCount();
     for (int i = 0; i < size_increase; ++i)
     {
       SetDim(i, pad_value);
     }
     std::memcpy(DimsData() + size_increase, shape.DimsData(),
                 sizeof(int32_t) * shape.DimensionsCount());
+    _size = new_shape_size;
   }
 
   int32_t _size;