Skip to content

Commit 81b52ff

Browse files
committed
fix: avoid going into partial agg skipping
1 parent 9c92bcf commit 81b52ff

1 file changed

Lines changed: 9 additions & 2 deletions

File tree

  • datafusion/physical-plan/src/joins/hash_join

datafusion/physical-plan/src/joins/hash_join/exec.rs

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2516,9 +2516,9 @@ mod tests {
25162516
Arc::clone(&raw_schema),
25172517
vec![
25182518
Arc::new(UInt32Array::from_iter_values(
2519-
(0..num_groups).map(aggregate_join_group_key),
2519+
(0..num_groups).flat_map(|i| [aggregate_join_group_key(i); 2]),
25202520
)),
2521-
Arc::new(UInt64Array::from(vec![1; num_groups])),
2521+
Arc::new(UInt64Array::from(vec![1; num_groups * 2])),
25222522
],
25232523
)?;
25242524
let input =
@@ -2547,6 +2547,13 @@ mod tests {
25472547
partial_aggregate.execute(0, Arc::new(TaskContext::default()))?,
25482548
)
25492549
.await?;
2550+
let skipped_rows = partial_aggregate
2551+
.metrics()
2552+
.and_then(|metrics| metrics.sum_by_name("skipped_aggregation_rows"))
2553+
.map(|metric| metric.as_usize())
2554+
.unwrap_or(0);
2555+
assert_eq!(skipped_rows, 0);
2556+
25502557
let partial_input = TestMemoryExec::try_new_exec(
25512558
&[partial_batches],
25522559
Arc::clone(&partial_schema),

0 commit comments

Comments
 (0)