Skip to content

Commit 1e7e47d

Browse files
authored
fix: Restrict version check to serverpod, and serverpod_client packages (serverpod#3401)
1 parent 1c286f0 commit 1e7e47d

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

tools/serverpod_cli/lib/src/serverpod_packages_version_check/serverpod_packages_version_check.dart

+4-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,10 @@ class ServerpodPackagesVersionCheckWarnings {
1717

1818
extension on PubspecPlus {
1919
Iterable<HostedDep> get serverpodDeps =>
20-
deps.whereType<HostedDep>().where((d) => d.name.startsWith('serverpod'));
20+
deps.whereType<HostedDep>().where((d) => const [
21+
'serverpod',
22+
'serverpod_client',
23+
].contains(d.name));
2124
}
2225

2326
List<SourceSpanSeverityException> validateServerpodPackagesVersion(

tools/serverpod_cli/test/integration/serverpod_packages_version_check/serverpod_packages_version_check_test.dart

+4-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ void main() {
1616
late final explicitVersion = PubspecPlus.parse('''
1717
name: x
1818
dependencies:
19-
serverpod_shared: 1.1.0
19+
serverpod_cloud_lints: 0.9.0 # ignored as this dependency is not relevant for codegen
20+
serverpod_client: 1.1.0
2021
''');
2122

2223
test(
@@ -89,7 +90,8 @@ dependencies:
8990
late final approximateVersion = PubspecPlus.parse('''
9091
name: x
9192
dependencies:
92-
serverpod_shared: ^1.1.0
93+
serverpod_cloud_lints: 0.9.0 # ignored as this dependency is not relevant for codegen
94+
serverpod_client: ^1.1.0
9395
''');
9496

9597
group('when calling validateServerpodPackagesVersion matching version',

0 commit comments

Comments
 (0)