Lint cleanup + .fromComposition constructors (#165)

Author: SandroMaglione

packages/fpdart/example/logger/logger.dart

@@ -68,7 +68,7 @@ class Logger {
         var outputEvent = OutputEvent(level, output);
         try {
           _output.output(outputEvent);
-        } catch (e, s) {
+        } on Exception catch (e, s) {
           print(e);
           print(s);
         }

packages/fpdart/example/logger/main.dart

@@ -39,7 +39,7 @@ class Logger {
         var outputEvent = OutputEvent(level, output);
         try {
           _output.output(outputEvent);
-        } catch (e, s) {
+        } on Exception catch (e, s) {
           print(e);
           print(s);
         }

packages/fpdart/example/src/either/chain_either.dart

@@ -50,7 +50,7 @@ Future<void> placeOrder() async {
     await ordersRepository.addOrder(uid, order);
     // third await call
     await cartRepository.setCart(uid, const Cart());
-  } catch (e) {
+  } on Exception catch (e) {
     // TODO: Handle exceptions from any of the methods above
   }
 

packages/fpdart/example/src/list/overview.dart

@@ -8,8 +8,8 @@ void main() {
   [1, 2, 3, 4].head;
 
   /// Dart: Throws a [StateError] ⚠️
-  [].first;
+  <int>[].first;
 
   /// fpdart: `None()`
-  [].head;
+  <int>[].head;
 }

packages/fpdart/example/src/task/task_and_future.dart

@@ -20,25 +20,25 @@ Future<bool> withFuture() async {
 
   try {
     usernameOrName = await getUsername();
-  } catch (e) {
+  } on Exception catch (e) {
     try {
       usernameOrName = decodeName(await getEncodedName());
-    } catch (e) {
+    } on Exception catch (e) {
       throw Exception("Missing both username and name");
     }
   }
 
   try {
     email = await getEmail();
-  } catch (e) {
+  } on Exception catch (e) {
     throw Exception("Missing email");
   }
 
   try {
     final usernameOrNamePrefix = addNamePrefix(usernameOrName);
     final emailPrefix = addEmailPrefix(email);
     return await sendInformation(usernameOrNamePrefix, emailPrefix);
-  } catch (e) {
+  } on Exception catch (e) {
     throw Exception("Error when sending information");
   }
 }

packages/fpdart/example/src/task_either/finally.dart

@@ -9,7 +9,7 @@ Future<void> imperative() async {
   try {
     final response = await apiRequestMock();
     print(response);
-  } catch (e) {
+  } on Exception catch (e) {
     print("Error: $e");
   } finally {
     print("Complete!");

packages/fpdart/example/src/task_either/overview.dart

@@ -4,7 +4,7 @@ import 'package:fpdart/fpdart.dart';
 Future<int> imperative(String str) async {
   try {
     return int.parse(str);
-  } catch (e) {
+  } on Exception catch (e) {
     return -1; // What does -1 means? 🤨
   }
 }

packages/fpdart/lib/src/date.dart

@@ -3,7 +3,7 @@ import 'io.dart';
 /// Constructs a [DateTime] instance with current date and time in the local time zone.
 ///
 /// [IO] wrapper around dart `DateTime.now()`.
-IO<DateTime> get dateNow => IO(() => DateTime.now());
+IO<DateTime> get dateNow => const IO(DateTime.now);
 
 /// The number of milliseconds since the "Unix epoch" 1970-01-01T00:00:00Z (UTC).
 ///

packages/fpdart/lib/src/either.dart

@@ -15,16 +15,15 @@ Either<L, R> right<L, R>(R r) => Right<L, R>(r);
 /// Shortcut for `Either.left(l)`.
 Either<L, R> left<L, R>(L l) => Left<L, R>(l);
 
-final class _EitherThrow<L> {
+final class _EitherThrow<L> implements Exception {
   final L value;
   const _EitherThrow(this.value);
 }
 
 typedef DoAdapterEither<L> = R Function<R>(Either<L, R>);
-DoAdapterEither<L> _doAdapter<L>() =>
-    <R>(Either<L, R> either) => either.getOrElse(
-          (l) => throw _EitherThrow(l),
-        );
+DoAdapterEither<L> _doAdapter<L>() => <R>(either) => either.getOrElse(
+      (l) => throw _EitherThrow(l),
+    );
 
 typedef DoFunctionEither<L, R> = R Function(DoAdapterEither<L> $);
 
@@ -70,7 +69,7 @@ sealed class Either<L, R> extends HKT2<_EitherHKT, L, R>
   /// If this [Either] is [Left], return `b`.
   @override
   C foldLeft<C>(C b, C Function(C acc, R b) f) =>
-      foldMap<Endo<C>>(dualEndoMonoid(), (b) => (C c) => f(c, b))(b);
+      foldMap<Endo<C>>(dualEndoMonoid(), (b) => (c) => f(c, b))(b);
 
   /// Use `monoid` to combine the value of [Right] applied to `f`.
   @override
@@ -135,8 +134,7 @@ sealed class Either<L, R> extends HKT2<_EitherHKT, L, R>
   /// Apply the function contained inside `a` to change the value on the [Right] from
   /// type `R` to a value of type `C`.
   @override
-  Either<L, C> ap<C>(covariant Either<L, C Function(R r)> a) =>
-      a.flatMap((f) => map(f));
+  Either<L, C> ap<C>(covariant Either<L, C Function(R r)> a) => a.flatMap(map);
 
   /// If this [Either] is a [Right], then return the result of calling `then`.
   /// Otherwise return [Left].
@@ -311,7 +309,7 @@ sealed class Either<L, R> extends HKT2<_EitherHKT, L, R>
         resultList.add(e._value);
       } else {
         throw Exception(
-          "[fpdart]: Error when mapping Either, it should be either Left or Right.",
+          '[fpdart]: Error when mapping Either, it should be either Left or Right.',
         );
       }
     }
@@ -383,7 +381,7 @@ sealed class Either<L, R> extends HKT2<_EitherHKT, L, R>
         resultListRights.add(e._value);
       } else {
         throw Exception(
-          "[fpdart]: Error when mapping Either, it should be either Left or Right.",
+          '[fpdart]: Error when mapping Either, it should be either Left or Right.',
         );
       }
     }
@@ -412,7 +410,7 @@ sealed class Either<L, R> extends HKT2<_EitherHKT, L, R>
   /// - If [Option] is [None], then return [Left] containing the result of `onNone`
   factory Either.fromOption(Option<R> m, L Function() onNone) => m.match(
         () => Either.left(onNone()),
-        (r) => Either.of(r),
+        Either<L, R>.of,
       );
 
   /// If calling `predicate` with `r` returns `true`, then return `Right(r)`.
@@ -450,7 +448,11 @@ sealed class Either<L, R> extends HKT2<_EitherHKT, L, R>
   /// **Note**: Make sure to specify the types of [Either] (`Either<L, R>.safeCast`
   /// instead of `Either.safeCast`), otherwise this will always return [Right]!
   factory Either.safeCast(
+    // `dynamic`s are use for safe-casting
+    //ignore: avoid_annotating_with_dynamic
     dynamic value,
+    // `dynamic`s are use for safe-casting
+    //ignore: avoid_annotating_with_dynamic
     L Function(dynamic value) onError,
   ) =>
       Either.safeCastStrict<L, R, dynamic>(value, onError);
@@ -577,7 +579,7 @@ class Right<L, R> extends Either<L, R> {
 
   @override
   TaskEither<L, R2> bindFuture<R2>(Future<Either<L, R2>> Function(R r) f) =>
-      TaskEither(() async => f(_value));
+      TaskEither(() => f(_value));
 
   @override
   TaskEither<L, R> toTaskEither() => TaskEither.of(_value);

packages/fpdart/lib/src/extension/curry_extension.dart

@@ -90,8 +90,7 @@ extension UncurryExtension4<Input1, Input2, Input3, Input4, Output>
   ///
   /// Inverse of `curry`.
   Output Function(Input1, Input2, Input3, Input4) get uncurry =>
-      (Input1 input1, Input2 input2, Input3 input3, Input4 input4) =>
-          this(input1)(input2)(input3)(input4);
+      (input1, input2, input3, input4) => this(input1)(input2)(input3)(input4);
 }
 
 extension CurryExtension5<Input1, Input2, Input3, Input4, Input5, Output>